summaryrefslogtreecommitdiff
path: root/ef/6717f869358a7fd5393f0bf22d29500e9b61d7
blob: 86e5501824a5f53928bbd3a46f8a649832944ec8 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194]
	helo=mx.sourceforge.net)
	by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
	(envelope-from <gavinandresen@gmail.com>) id 1R1Jiy-0007ju-EP
	for bitcoin-development@lists.sourceforge.net;
	Wed, 07 Sep 2011 15:07:36 +0000
Received-SPF: pass (sog-mx-4.v43.ch3.sourceforge.com: domain of gmail.com
	designates 209.85.161.47 as permitted sender)
	client-ip=209.85.161.47; envelope-from=gavinandresen@gmail.com;
	helo=mail-fx0-f47.google.com; 
Received: from mail-fx0-f47.google.com ([209.85.161.47])
	by sog-mx-4.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128)
	(Exim 4.76) id 1R1Jiu-0002ui-9V
	for bitcoin-development@lists.sourceforge.net;
	Wed, 07 Sep 2011 15:07:36 +0000
Received: by fxg11 with SMTP id 11so912529fxg.34
	for <bitcoin-development@lists.sourceforge.net>;
	Wed, 07 Sep 2011 08:07:26 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.223.54.17 with SMTP id o17mr2060964fag.61.1315408046041; Wed,
	07 Sep 2011 08:07:26 -0700 (PDT)
Received: by 10.152.36.233 with HTTP; Wed, 7 Sep 2011 08:07:25 -0700 (PDT)
In-Reply-To: <201109061655.30148.luke@dashjr.org>
References: <CABsx9T1juB-0hr9NW=PoO5eh_Aqhzkiv3tnXTSTsjBKiy4y0JA@mail.gmail.com>
	<201109061655.30148.luke@dashjr.org>
Date: Wed, 7 Sep 2011 11:07:25 -0400
Message-ID: <CABsx9T22rOFrnPGtbaBA9VP2F9vyxTovmjSDUsMLQFOyhs7ZZw@mail.gmail.com>
From: Gavin Andresen <gavinandresen@gmail.com>
To: Luke-Jr <luke@dashjr.org>
Content-Type: text/plain; charset=ISO-8859-1
X-Spam-Score: -1.6 (-)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
	See http://spamassassin.org/tag/ for more details.
	-1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for
	sender-domain
	0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider
	(gavinandresen[at]gmail.com)
	-0.0 SPF_PASS               SPF: sender matches SPF record
	-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from
	author's domain
	0.1 DKIM_SIGNED            Message has a DKIM or DK signature,
	not necessarily valid
	-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
	0.0 AWL AWL: From: address is in the auto white-list
X-Headers-End: 1R1Jiu-0002ui-9V
Cc: bitcoin-development@lists.sourceforge.net
Subject: Re: [Bitcoin-development] 0.4rc1 known bugs
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
	<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
	<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Wed, 07 Sep 2011 15:07:36 -0000

On Tue, Sep 6, 2011 at 4:55 PM, Luke-Jr <luke@dashjr.org> wrote:
> Got a fix for the encrypted-wallet mining issue:
> - unique_coinbase

Turned this into a pull request:
  https://github.com/bitcoin/bitcoin/pull/505

I reviewed the code but have not tested.

Rough sketch of a test plan:

Run clean testnet-in-a-box bitcoind, with -keypool=1
Encrypt the wallet
Run bitcoind getnewaddress until it tell you keypool is exhausted
Generate a couple of blocks via internal miner -- verify: coinbase
transactions have unique txids even though they pay-to default key
Generate a couple of blocks via getwork RPC call -- verify: coinbase
transactions have unique txids


-- 
--
Gavin Andresen