Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1R1Jiy-0007ju-EP for bitcoin-development@lists.sourceforge.net; Wed, 07 Sep 2011 15:07:36 +0000 Received-SPF: pass (sog-mx-4.v43.ch3.sourceforge.com: domain of gmail.com designates 209.85.161.47 as permitted sender) client-ip=209.85.161.47; envelope-from=gavinandresen@gmail.com; helo=mail-fx0-f47.google.com; Received: from mail-fx0-f47.google.com ([209.85.161.47]) by sog-mx-4.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128) (Exim 4.76) id 1R1Jiu-0002ui-9V for bitcoin-development@lists.sourceforge.net; Wed, 07 Sep 2011 15:07:36 +0000 Received: by fxg11 with SMTP id 11so912529fxg.34 for ; Wed, 07 Sep 2011 08:07:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.54.17 with SMTP id o17mr2060964fag.61.1315408046041; Wed, 07 Sep 2011 08:07:26 -0700 (PDT) Received: by 10.152.36.233 with HTTP; Wed, 7 Sep 2011 08:07:25 -0700 (PDT) In-Reply-To: <201109061655.30148.luke@dashjr.org> References: <201109061655.30148.luke@dashjr.org> Date: Wed, 7 Sep 2011 11:07:25 -0400 Message-ID: From: Gavin Andresen To: Luke-Jr Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -1.6 (-) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (gavinandresen[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 AWL AWL: From: address is in the auto white-list X-Headers-End: 1R1Jiu-0002ui-9V Cc: bitcoin-development@lists.sourceforge.net Subject: Re: [Bitcoin-development] 0.4rc1 known bugs X-BeenThere: bitcoin-development@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Sep 2011 15:07:36 -0000 On Tue, Sep 6, 2011 at 4:55 PM, Luke-Jr wrote: > Got a fix for the encrypted-wallet mining issue: > - unique_coinbase Turned this into a pull request: https://github.com/bitcoin/bitcoin/pull/505 I reviewed the code but have not tested. Rough sketch of a test plan: Run clean testnet-in-a-box bitcoind, with -keypool=1 Encrypt the wallet Run bitcoind getnewaddress until it tell you keypool is exhausted Generate a couple of blocks via internal miner -- verify: coinbase transactions have unique txids even though they pay-to default key Generate a couple of blocks via getwork RPC call -- verify: coinbase transactions have unique txids -- -- Gavin Andresen