summaryrefslogtreecommitdiff
path: root/b1/53af3a50e31d13f58b5f353a49f60e5758533e
blob: 35b2e2ac0c9a9a192561ad9127bde7df68ce9297 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
Return-Path: <morcos@gmail.com>
Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org
	[172.17.192.35])
	by mail.linuxfoundation.org (Postfix) with ESMTPS id A7F0FE12
	for <bitcoin-dev@lists.linuxfoundation.org>;
	Wed, 17 Feb 2016 02:28:32 +0000 (UTC)
X-Greylist: whitelisted by SQLgrey-1.7.6
Received: from mail-io0-f179.google.com (mail-io0-f179.google.com
	[209.85.223.179])
	by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 0F5CA196
	for <bitcoin-dev@lists.linuxfoundation.org>;
	Wed, 17 Feb 2016 02:28:32 +0000 (UTC)
Received: by mail-io0-f179.google.com with SMTP id l127so16119668iof.3
	for <bitcoin-dev@lists.linuxfoundation.org>;
	Tue, 16 Feb 2016 18:28:32 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	bh=++hdfkmeA7pnLVnKYSd5d4S60XJtUlHkmLyjphLPOwY=;
	b=CfBMWYS1MByolCXn7XqmcRqOsa4AHLAwlZjaU1jGurFBE0DtfxgrAu8lPcBa2RV3eF
	Yn7/6k5jOMfNpJWOhh69Da3Wxt56rVPeKmB+TLfrnfRP7rvkxF7pg/GV9Ld2uzydMaPN
	Y3l+gLMs/0sUY6oA9Ef8DR9iOgU79YNRjF2iGBc+rmB0wd7a+ixA+yF6PVXohRgpYKPE
	ozUeG88TrIxtSc3umuidGnGvue7IxEL1jUDXWgcYrqmarsgscQeiLK1NPRZPMuqSeQWo
	Tg9P5rUMlOCFPZ1q9Mlzed5sxb+6hWMjD5G3bWjBZCuL9KpErXbnjX2m3JwUVkM5BXrl
	sQMw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20130820;
	h=x-gm-message-state:mime-version:in-reply-to:references:date
	:message-id:subject:from:to:cc:content-type;
	bh=++hdfkmeA7pnLVnKYSd5d4S60XJtUlHkmLyjphLPOwY=;
	b=Y1E5XOLr9SDQcclbAGlwpaxUivv2uccd5DLBDHsibqWvcLVOqi4iJZp1TNyEI5sjR7
	6njEpmP3QKd/a3DXlqvNBC3aptLi89K8nmFatR32tmvYHJzi+1AA66vseIGeGM0+DB6F
	eo/R8PysoHja5vdPukI341zTEGezR1qwQPquKEswkyyoFQ6gtH7/iN7joUIt7Ld/lwuD
	zZ1yuBTKJhEZ9yBotv27WpCRUewPrXascL9wI5pQadZPnsHsuwc/JT6UhdIMmNZQeEh3
	1g0NdSfA8PuUbEnI5ZNylr/QcDsXgRzk8gIeBPfyKhKTyBtqRGAdLAzrsiC2Lq25wJfK
	DyLA==
X-Gm-Message-State: AG10YORyMopmS3XAo6wjEyo5rS5f+2aYR+I99o4mcQGZCNAIi2G4rmRu+NJh/FSKnkq4JIiITbF3mJpUvyOmNQ==
MIME-Version: 1.0
X-Received: by 10.107.10.147 with SMTP id 19mr719178iok.46.1455676111389; Tue,
	16 Feb 2016 18:28:31 -0800 (PST)
Received: by 10.64.113.193 with HTTP; Tue, 16 Feb 2016 18:28:31 -0800 (PST)
In-Reply-To: <201602170046.17166.luke@dashjr.org>
References: <CAPWm=eXi98cC0KP=5WayU05hezDFswrPe+vA58cTHvVLc80OzQ@mail.gmail.com>
	<201602170046.17166.luke@dashjr.org>
Date: Tue, 16 Feb 2016 20:28:31 -0600
Message-ID: <CAPWm=eVdMy0Fp_pGq6mpt1J-pH_zmA=ca9peM=pL=Gp-GyDBLw@mail.gmail.com>
From: Alex Morcos <morcos@gmail.com>
To: Luke Dashjr <luke@dashjr.org>
Content-Type: multipart/alternative; boundary=001a113eddf2872ea8052bee0177
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, HTML_MESSAGE,
	RCVD_IN_DNSWL_LOW, URIBL_SBL autolearn=ham version=3.3.1
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
	smtp1.linux-foundation.org
Cc: Bitcoin Dev <bitcoin-dev@lists.linuxfoundation.org>
Subject: Re: [bitcoin-dev] [BIP Proposal] New "feefilter" p2p message
X-BeenThere: bitcoin-dev@lists.linuxfoundation.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Bitcoin Development Discussion <bitcoin-dev.lists.linuxfoundation.org>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/bitcoin-dev>,
	<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/>
List-Post: <mailto:bitcoin-dev@lists.linuxfoundation.org>
List-Help: <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev>,
	<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Feb 2016 02:28:32 -0000

--001a113eddf2872ea8052bee0177
Content-Type: text/plain; charset=UTF-8

On Tue, Feb 16, 2016 at 6:46 PM, Luke Dashjr <luke@dashjr.org> wrote:

> On Tuesday, February 16, 2016 8:20:26 PM Alex Morcos via bitcoin-dev wrote:
> > # The feefilter message is defined as a message containing an int64_t
> where
> > pchCommand == "feefilter"
>
> What happened to extensibility? And why waste 64 bits for what is almost
> certainly a small number?
>

I thought that extensibility was already sufficient with the command string
system.  If we come up with a better version of the feefilter later we can
just give it a different command name.  This seemed to encapsulate a fairly
complete idea for now.  As for the 8 bytes, it didn't seem necessary to me
to over optimize with a custom encoding for what amounts to well under 20%
of ping traffic.  (pings are sent every 2 mins per peer, feefilters on
average every 10 mins, but when the quantized value to be sent would be the
same it is skipped)


> > # The fee filter is additive with a bloom filter for transactions so if
> an
> > SPV client were to load a bloom filter and send a feefilter message,
> > transactions would only be relayed if they passed both filters.
>
> This seems to make feefilter entirely useless for wallets?
>
>
I don't follow this comment?  Transactions aren't synced with the wallet
unless they are accepted into the mempool.  Sending feefilter messages
should not reduce the number of transactions that are accepted to the
mempool.


> Luke
>

--001a113eddf2872ea8052bee0177
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><div class=3D"gmail_extra"><br><div class=3D"gmail_quo=
te">On Tue, Feb 16, 2016 at 6:46 PM, Luke Dashjr <span dir=3D"ltr">&lt;<a h=
ref=3D"mailto:luke@dashjr.org" target=3D"_blank">luke@dashjr.org</a>&gt;</s=
pan> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex=
;border-left:1px #ccc solid;padding-left:1ex"><span class=3D"">On Tuesday, =
February 16, 2016 8:20:26 PM Alex Morcos via bitcoin-dev wrote:<br>
&gt; # The feefilter message is defined as a message containing an int64_t =
where<br>
&gt; pchCommand =3D=3D &quot;feefilter&quot;<br>
<br>
</span>What happened to extensibility? And why waste 64 bits for what is al=
most<br>
certainly a small number?<br></blockquote><div><br></div><div>I thought tha=
t extensibility was already sufficient with the command string system.=C2=
=A0 If we come up with a better version of the feefilter later we can just =
give it a different command name.=C2=A0 This seemed to encapsulate a fairly=
 complete idea for now.=C2=A0 As for the 8 bytes, it didn&#39;t seem necess=
ary to me to over optimize with a custom encoding for what amounts to well =
under 20% of ping traffic. =C2=A0(pings are sent every 2 mins per peer, fee=
filters on average every 10 mins, but when the quantized value to be sent w=
ould be the same it is skipped)</div><div><br></div><blockquote class=3D"gm=
ail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-le=
ft:1ex">
<span class=3D""><br>
&gt; # The fee filter is additive with a bloom filter for transactions so i=
f an<br>
&gt; SPV client were to load a bloom filter and send a feefilter message,<b=
r>
&gt; transactions would only be relayed if they passed both filters.<br>
<br>
</span>This seems to make feefilter entirely useless for wallets?<br>
<span class=3D"HOEnZb"><font color=3D"#888888"><br></font></span></blockquo=
te><div><br></div><div>I don&#39;t follow this comment?=C2=A0 Transactions =
aren&#39;t synced with the wallet unless they are accepted into the mempool=
.=C2=A0 Sending feefilter messages should not reduce the number of transact=
ions that are accepted to the mempool.</div><div>=C2=A0</div><blockquote cl=
ass=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;p=
adding-left:1ex"><span class=3D"HOEnZb"><font color=3D"#888888">
Luke<br>
</font></span></blockquote></div><br></div></div>

--001a113eddf2872ea8052bee0177--