MIME-Version: 1.0
In-Reply-To: <201602170046.17166.luke@dashjr.org>
References: <CAPWm=eXi98cC0KP=5WayU05hezDFswrPe+vA58cTHvVLc80OzQ@mail.gmail.com>
	<201602170046.17166.luke@dashjr.org>
Date: Tue, 16 Feb 2016 20:28:31 -0600
Message-ID: <CAPWm=eVdMy0Fp_pGq6mpt1J-pH_zmA=ca9peM=pL=Gp-GyDBLw@mail.gmail.com>
From: Alex Morcos <morcos@gmail.com>
To: Luke Dashjr <luke@dashjr.org>
Content-Type: multipart/alternative; boundary=001a113eddf2872ea8052bee0177
Cc: Bitcoin Dev <bitcoin-dev@lists.linuxfoundation.org>
Subject: Re: [bitcoin-dev] [BIP Proposal] New "feefilter" p2p message
Precedence: list

--001a113eddf2872ea8052bee0177
Content-Type: text/plain; charset=UTF-8

On Tue, Feb 16, 2016 at 6:46 PM, Luke Dashjr <luke@dashjr.org> wrote:

> On Tuesday, February 16, 2016 8:20:26 PM Alex Morcos via bitcoin-dev wrote:
> > # The feefilter message is defined as a message containing an int64_t
> where
> > pchCommand == "feefilter"
>
> What happened to extensibility? And why waste 64 bits for what is almost
> certainly a small number?
>

I thought that extensibility was already sufficient with the command string
system.  If we come up with a better version of the feefilter later we can
just give it a different command name.  This seemed to encapsulate a fairly
complete idea for now.  As for the 8 bytes, it didn't seem necessary to me
to over optimize with a custom encoding for what amounts to well under 20%
of ping traffic.  (pings are sent every 2 mins per peer, feefilters on
average every 10 mins, but when the quantized value to be sent would be the
same it is skipped)


> > # The fee filter is additive with a bloom filter for transactions so if
> an
> > SPV client were to load a bloom filter and send a feefilter message,
> > transactions would only be relayed if they passed both filters.
>
> This seems to make feefilter entirely useless for wallets?
>
>
I don't follow this comment?  Transactions aren't synced with the wallet
unless they are accepted into the mempool.  Sending feefilter messages
should not reduce the number of transactions that are accepted to the
mempool.


> Luke
>

--001a113eddf2872ea8052bee0177
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><div class=3D"gmail_extra"><br><div class=3D"gmail_quo=
te">On Tue, Feb 16, 2016 at 6:46 PM, Luke Dashjr <span dir=3D"ltr">&lt;<a h=
ref=3D"mailto:luke@dashjr.org" target=3D"_blank">luke@dashjr.org</a>&gt;</s=
pan> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex=
;border-left:1px #ccc solid;padding-left:1ex"><span class=3D"">On Tuesday, =
February 16, 2016 8:20:26 PM Alex Morcos via bitcoin-dev wrote:<br>
&gt; # The feefilter message is defined as a message containing an int64_t =
where<br>
&gt; pchCommand =3D=3D &quot;feefilter&quot;<br>
<br>
</span>What happened to extensibility? And why waste 64 bits for what is al=
most<br>
certainly a small number?<br></blockquote><div><br></div><div>I thought tha=
t extensibility was already sufficient with the command string system.=C2=
=A0 If we come up with a better version of the feefilter later we can just =
give it a different command name.=C2=A0 This seemed to encapsulate a fairly=
 complete idea for now.=C2=A0 As for the 8 bytes, it didn&#39;t seem necess=
ary to me to over optimize with a custom encoding for what amounts to well =
under 20% of ping traffic. =C2=A0(pings are sent every 2 mins per peer, fee=
filters on average every 10 mins, but when the quantized value to be sent w=
ould be the same it is skipped)</div><div><br></div><blockquote class=3D"gm=
ail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-le=
ft:1ex">
<span class=3D""><br>
&gt; # The fee filter is additive with a bloom filter for transactions so i=
f an<br>
&gt; SPV client were to load a bloom filter and send a feefilter message,<b=
r>
&gt; transactions would only be relayed if they passed both filters.<br>
<br>
</span>This seems to make feefilter entirely useless for wallets?<br>
<span class=3D"HOEnZb"><font color=3D"#888888"><br></font></span></blockquo=
te><div><br></div><div>I don&#39;t follow this comment?=C2=A0 Transactions =
aren&#39;t synced with the wallet unless they are accepted into the mempool=
.=C2=A0 Sending feefilter messages should not reduce the number of transact=
ions that are accepted to the mempool.</div><div>=C2=A0</div><blockquote cl=
ass=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;p=
adding-left:1ex"><span class=3D"HOEnZb"><font color=3D"#888888">
Luke<br>
</font></span></blockquote></div><br></div></div>

--001a113eddf2872ea8052bee0177--