1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
|
Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194]
helo=mx.sourceforge.net)
by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
(envelope-from <olivier@trillion01.com>) id 1VS15o-0001U3-LG
for bitcoin-development@lists.sourceforge.net;
Fri, 04 Oct 2013 08:50:36 +0000
Received-SPF: neutral (sog-mx-4.v43.ch3.sourceforge.com: 74.220.220.113 is
neither permitted nor denied by domain of trillion01.com)
client-ip=74.220.220.113; envelope-from=olivier@trillion01.com;
helo=outbound-ss-336.hostmonster.com;
Received: from outbound-ss-336.hostmonster.com ([74.220.220.113])
by sog-mx-4.v43.ch3.sourceforge.com with smtp (Exim 4.76)
id 1VS15n-0001yP-OT for bitcoin-development@lists.sourceforge.net;
Fri, 04 Oct 2013 08:50:36 +0000
Received: (qmail 22210 invoked by uid 0); 4 Oct 2013 03:23:50 -0000
Received: from unknown (HELO box610.bluehost.com) (70.40.220.110)
by oproxy13.mail.unifiedlayer.com with SMTP; 4 Oct 2013 03:23:50 -0000
Received: from [173.179.63.169] (port=48930 helo=[192.168.1.104])
by box610.bluehost.com with esmtpsa (TLSv1:RC4-SHA:128) (Exim 4.80)
(envelope-from <olivier@trillion01.com>)
id 1VRvza-0001Bu-Hg; Thu, 03 Oct 2013 21:23:50 -0600
Message-ID: <1380857029.932.49.camel@Wailaba2>
From: Olivier Langlois <olivier@trillion01.com>
To: Ron <rdwnj@yahoo.com>
Date: Thu, 03 Oct 2013 23:23:49 -0400
In-Reply-To: <1380770163.7534.YahooMailNeo@web124502.mail.ne1.yahoo.com>
References: <1380770163.7534.YahooMailNeo@web124502.mail.ne1.yahoo.com>
Organization: Trillion01 Inc
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.8.5
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Identified-User: {5686:box610.bluehost.com:olivierl:trillion01.com}
{sentby:smtp auth 173.179.63.169 authed with
olivier@trillion01.com}
X-Spam-Score: 2.3 (++)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
See http://spamassassin.org/tag/ for more details.
1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT
[74.220.220.113 listed in bb.barracudacentral.org]
0.7 SPF_NEUTRAL SPF: sender does not match SPF record (neutral)
X-Headers-End: 1VS15n-0001yP-OT
Cc: "bitcoin-development@lists.sourceforge.net"
<bitcoin-development@lists.sourceforge.net>
Subject: Re: [Bitcoin-development] on CDB::Rewrite()
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Fri, 04 Oct 2013 08:50:36 -0000
> Upon looking at the 0.8.5 & earlier code for CDB:Rewrite(), in the
> files db.h and db.cpp, you will notice that in db.h it is declared
> bool static, but in db.cpp it isn't. Is this a problem? Or a feature?
> Or nothing at all?
It is perfect C++ code.
> Furthermore, it is called only in wallet.cpp
> -->CWallet::EncryptWallet() but its return value is ignored? Again,
> intentional or a bug or a feature or a ...?
possibly a minor bug. Minor because over 99% of the time it is called, the Rewrite() function will succeed.
Maybe CWallet::EncryptWallet() should return false to its callers when
CDB::Rewrite fails.
|
