Received-SPF: neutral (sog-mx-4.v43.ch3.sourceforge.com: 74.220.220.113 is
	neither permitted nor denied by domain of trillion01.com)
	client-ip=74.220.220.113; envelope-from=olivier@trillion01.com;
	helo=outbound-ss-336.hostmonster.com; 
Message-ID: <1380857029.932.49.camel@Wailaba2>
From: Olivier Langlois <olivier@trillion01.com>
To: Ron <rdwnj@yahoo.com>
Date: Thu, 03 Oct 2013 23:23:49 -0400
In-Reply-To: <1380770163.7534.YahooMailNeo@web124502.mail.ne1.yahoo.com>
References: <1380770163.7534.YahooMailNeo@web124502.mail.ne1.yahoo.com>
Organization: Trillion01 Inc
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Cc: "bitcoin-development@lists.sourceforge.net"
	<bitcoin-development@lists.sourceforge.net>
Subject: Re: [Bitcoin-development] on CDB::Rewrite()
Precedence: list


> Upon looking at the 0.8.5 & earlier code for CDB:Rewrite(), in the
> files db.h and db.cpp, you will notice that in db.h it is declared
> bool static, but in db.cpp it isn't. Is this a problem? Or a feature?
> Or nothing at all?

It is perfect C++ code.

> Furthermore, it is called only in wallet.cpp
> -->CWallet::EncryptWallet() but its return value is ignored? Again,
> intentional or a bug or a feature or a ...?

possibly a minor bug. Minor because over 99% of the time it is called, the Rewrite() function will succeed.

Maybe CWallet::EncryptWallet() should return false to its callers when
CDB::Rewrite fails.