summaryrefslogtreecommitdiff
path: root/ed/5b803d53fb931f22f8768837185cef9d233ce4
blob: f60cc84e3c58166af504b88ea0563b7044c70c91 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191]
	helo=mx.sourceforge.net)
	by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
	(envelope-from <mh.in.england@gmail.com>) id 1XEi4P-0008WF-W4
	for bitcoin-development@lists.sourceforge.net;
	Tue, 05 Aug 2014 16:58:42 +0000
Received-SPF: pass (sog-mx-1.v43.ch3.sourceforge.com: domain of gmail.com
	designates 209.85.219.54 as permitted sender)
	client-ip=209.85.219.54; envelope-from=mh.in.england@gmail.com;
	helo=mail-oa0-f54.google.com; 
Received: from mail-oa0-f54.google.com ([209.85.219.54])
	by sog-mx-1.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128)
	(Exim 4.76) id 1XEi4N-0002dE-9M
	for bitcoin-development@lists.sourceforge.net;
	Tue, 05 Aug 2014 16:58:41 +0000
Received: by mail-oa0-f54.google.com with SMTP id n16so883228oag.13
	for <bitcoin-development@lists.sourceforge.net>;
	Tue, 05 Aug 2014 09:58:32 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.182.233.230 with SMTP id tz6mr7426188obc.53.1407257911739;
	Tue, 05 Aug 2014 09:58:31 -0700 (PDT)
Sender: mh.in.england@gmail.com
Received: by 10.76.35.234 with HTTP; Tue, 5 Aug 2014 09:58:31 -0700 (PDT)
In-Reply-To: <CAJHLa0NdJhGyFfhzhxmL3=qNjYed0+FQ-X4EQdrVMR3K4Het7Q@mail.gmail.com>
References: <CANEZrP1mU6iS6NRyK6iJtg4BEQ3nQRFc-dVwaOd+P_NFThqxjw@mail.gmail.com>
	<CAJHLa0NdJhGyFfhzhxmL3=qNjYed0+FQ-X4EQdrVMR3K4Het7Q@mail.gmail.com>
Date: Tue, 5 Aug 2014 18:58:31 +0200
X-Google-Sender-Auth: KpPkMCgADVWbLxVfEgj43HwIfpk
Message-ID: <CANEZrP2n9uRxbpyvF8D0478umbJ-K_sz9V8ahz5EXaCQRaM8sw@mail.gmail.com>
From: Mike Hearn <mike@plan99.net>
To: Jeff Garzik <jgarzik@bitpay.com>
Content-Type: multipart/alternative; boundary=001a11c30012efcd1d04ffe4c380
X-Spam-Score: -0.5 (/)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
	See http://spamassassin.org/tag/ for more details.
	-1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for
	sender-domain
	0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider
	(mh.in.england[at]gmail.com)
	-0.0 SPF_PASS               SPF: sender matches SPF record
	1.0 HTML_MESSAGE           BODY: HTML included in message
	0.1 DKIM_SIGNED            Message has a DKIM or DK signature,
	not necessarily valid
	-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
X-Headers-End: 1XEi4N-0002dE-9M
Cc: Bitcoin Dev <bitcoin-development@lists.sourceforge.net>
Subject: Re: [Bitcoin-development] How to create a pull tester JAR
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
	<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
	<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Tue, 05 Aug 2014 16:58:42 -0000

--001a11c30012efcd1d04ffe4c380
Content-Type: text/plain; charset=UTF-8

No problem.

The pull tester entry point can be found here:

https://github.com/bitcoinj/bitcoinj/blob/master/core/src/test/java/com/google/bitcoin/core/BitcoindComparisonTool.java

(nb: in the near future I will be re-namespacing the library from
com.google.bitcoin to org.bitcoinj to reflect that it no longer has
anything to do with Google and then this link will break).

The code itself is a rather bad example of copy/paste coding and I can say
that, because Matt knows it and already plans to refactor things ;) So if
anyone is thinking of adding tests to the framework coordinate with him
first to ensure you don't end up conflicting with a big refactor/rewrite.

--001a11c30012efcd1d04ffe4c380
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">No problem.<div><br></div><div>The pull tester entry point=
 can be found here:</div><div><br></div><div><a href=3D"https://github.com/=
bitcoinj/bitcoinj/blob/master/core/src/test/java/com/google/bitcoin/core/Bi=
tcoindComparisonTool.java">https://github.com/bitcoinj/bitcoinj/blob/master=
/core/src/test/java/com/google/bitcoin/core/BitcoindComparisonTool.java</a>=
<br>
</div><div><br></div><div>(nb: in the near future I will be re-namespacing =
the library from com.google.bitcoin to org.bitcoinj to reflect that it no l=
onger has anything to do with Google and then this link will break).</div>
<div><br></div><div>The code itself is a rather bad example of copy/paste c=
oding and I can say that, because Matt knows it and already plans to refact=
or things ;) So if anyone is thinking of adding tests to the framework coor=
dinate with him first to ensure you don&#39;t end up conflicting with a big=
 refactor/rewrite.</div>
<div><br></div><div><br></div></div>

--001a11c30012efcd1d04ffe4c380--