1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
|
Return-Path: <gmaxwell@gmail.com>
Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org
[172.17.192.35])
by mail.linuxfoundation.org (Postfix) with ESMTPS id 7869CBBC
for <bitcoin-dev@lists.linuxfoundation.org>;
Tue, 12 Mar 2019 22:14:25 +0000 (UTC)
X-Greylist: whitelisted by SQLgrey-1.7.6
Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com
[209.85.208.52])
by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 0D8672C4
for <bitcoin-dev@lists.linuxfoundation.org>;
Tue, 12 Mar 2019 22:14:24 +0000 (UTC)
Received: by mail-ed1-f52.google.com with SMTP id e4so3697905edi.3
for <bitcoin-dev@lists.linuxfoundation.org>;
Tue, 12 Mar 2019 15:14:24 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to;
bh=3jr8hu03zH1kZPL8PbjVJKbvZgmFIkTs/shAg8C8l3s=;
b=aBGBsdC1cQ1uM26DPlCauMf0Art5XS+gvP+vfErWegL6Ty0kYWYKunAkhMA91pVz3A
iH6Cb3ozU8wBxcFBdnLp6LGytrGELS1qdJ6MlqqTxBzlfngXLy8/Z4nE2pqDxdDVXCIu
K0oYN1j8IQoqhEOWv2AhlyIAeX7lUGhLRdgXQnbCX9LqCnMEdc1LJS1q/GOkNdSQjCWh
N79dIRmrYgvglOM/UXY9L+ISFOjT/sSZ1ygi4DdYjBdV/kh4kWBhQ7nQv6As3dwpuCuw
DltXYPkjAWv9kHZFBWidXVkoatemgDBX8z0RSEt7rMKnByuf98RVZLdnCwqUFNCqFmK2
xwnA==
X-Gm-Message-State: APjAAAWZCPNlPVuDChrWxmdO2qD5g1morEq5biyGXVgXaIbcqxcCfpfe
Dgqn9Zt7cRtrHP/NMCSF2XOtTEi6gy18jqG1v5Ei3w==
X-Google-Smtp-Source: APXvYqywktmS0fa0V/lOJwSP7rdss90s1aSRlIsNdX00p8g2nyPFvAfGXaqRI4iI6m6HQGbTSDrDeBXjtG/NqrNhaqc=
X-Received: by 2002:a17:906:2001:: with SMTP id
1mr8093403ejo.243.1552428863594;
Tue, 12 Mar 2019 15:14:23 -0700 (PDT)
MIME-Version: 1.0
References: <CAK51vgDO2Tg38XbW0pqAnO3ETJ_qf8owRsUYsTXmrf7H2yGZtw@mail.gmail.com>
<q5otmg$4vh7$1@blaine.gmane.org>
<78CAF294-56E2-477C-B46F-C65A56357820@sprovoost.nl>
<q5rm39$87ck$1@blaine.gmane.org>
<CAAS2fgR5D_jo6eZp5Z09TzBg8ux8wP24=km_0O-XhLsJQPtVxw@mail.gmail.com>
<q68p34$1pc8$1@blaine.gmane.org>
In-Reply-To: <q68p34$1pc8$1@blaine.gmane.org>
From: Gregory Maxwell <greg@xiph.org>
Date: Tue, 12 Mar 2019 22:14:10 +0000
Message-ID: <CAAS2fgS-+ucC2gfYGhEfKx0Upct45gcU2smTv_QVmb=NoU3sCw@mail.gmail.com>
To: Andreas Schildbach <andreas@schildbach.de>,
Bitcoin Protocol Discussion <bitcoin-dev@lists.linuxfoundation.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,
RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
smtp1.linux-foundation.org
X-Mailman-Approved-At: Wed, 13 Mar 2019 00:41:38 +0000
Subject: Re: [bitcoin-dev] Removal of reject network messages from Bitcoin
Core (BIP61)
X-BeenThere: bitcoin-dev@lists.linuxfoundation.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Bitcoin Protocol Discussion <bitcoin-dev.lists.linuxfoundation.org>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/bitcoin-dev>,
<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/>
List-Post: <mailto:bitcoin-dev@lists.linuxfoundation.org>
List-Help: <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev>,
<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Mar 2019 22:14:25 -0000
On Tue, Mar 12, 2019 at 7:45 PM Andreas Schildbach via bitcoin-dev
<bitcoin-dev@lists.linuxfoundation.org> wrote:
> These two cases are understood and handled by current code. Generally
> the idea is take reject messages serious, but don't overrate the lack
> of. Luckily, network confirmations fill the gap. (Yes, a timeout is
I'd like to better understand this, but it would be easier to just
read the code than ask a bunch of questions. I tried looking for the
handling of reject messages in Android Bitcoin Wallet and BitcoinJ
and didn't really find and handling other than logging exceptions.
Would you mind giving me a couple pointers to where in the code
they're handled?
|
