summaryrefslogtreecommitdiff
path: root/e1/ca7963ccfa83f7494810687f473d66df015203
blob: 4199c3d3b159da0928362d356beae6044c7f600e (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194]
	helo=mx.sourceforge.net)
	by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
	(envelope-from <sean@msgilligan.com>) id 1YhQru-0004GF-IG
	for bitcoin-development@lists.sourceforge.net;
	Sun, 12 Apr 2015 23:00:46 +0000
X-ACL-Warn: 
Received: from mail-pd0-f170.google.com ([209.85.192.170])
	by sog-mx-4.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128)
	(Exim 4.76) id 1YhQrs-0002h7-AQ
	for bitcoin-development@lists.sourceforge.net;
	Sun, 12 Apr 2015 23:00:46 +0000
Received: by pdbnk13 with SMTP id nk13so86735259pdb.0
	for <bitcoin-development@lists.sourceforge.net>;
	Sun, 12 Apr 2015 16:00:38 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20130820;
	h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to
	:subject:references:in-reply-to:content-type;
	bh=q7yoiTkuo+XPVW3YyoOrcQrBXHyY4OyvLtSWcLZWeU4=;
	b=B/STz7yxjZ9tJ9rVXE5xO4+8mlQcRrNbyTvAhCreSGwQqz9IIp3ML48XbzZIUabUnJ
	Bo01VQ402vJUwG767oiox23ToqMnd+FZCa/Itq5twT8BzhYUcW3Sk9BG/ycMzuVjsog8
	G0Zrbr7huQB2SwXILp5sN05it/49Dn/yBUp8DXBygaTnbVU0kIMCiV3MxUWUTZI7lRYQ
	iU85cOK7qs2b68i9Io+17BqVmeliu8Gs2wlTjx4fuqoeiVc3lt9CzvgGpuHkDqhBiBBO
	vg84N3aDWkNGNtPp5ZCQyfWK4GoYKVHeRxCeIj2z5gB6LOyHjQ9BUxXyfqm/+RookjY0
	/ZTA==
X-Gm-Message-State: ALoCoQkXpd0Cq58ZudFofXf8G4bXo6tozz8ihDoB58h5yt4TPJwSnCSeRXoIAx+6OlHGZqbbFvVg
X-Received: by 10.68.135.199 with SMTP id pu7mr21011251pbb.153.1428878176223; 
	Sun, 12 Apr 2015 15:36:16 -0700 (PDT)
Received: from seanmb.att.net ([2602:306:ce08:9dc0:f5ca:572e:ee19:e397])
	by mx.google.com with ESMTPSA id qh9sm5216259pbc.24.2015.04.12.15.36.13
	(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
	Sun, 12 Apr 2015 15:36:14 -0700 (PDT)
Message-ID: <552AF35C.7060407@msgilligan.com>
Date: Sun, 12 Apr 2015 15:36:12 -0700
From: Sean Gilligan <sean@msgilligan.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9;
	rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Pieter Wuille <pieter.wuille@gmail.com>, 
	Bitcoin Dev <bitcoin-development@lists.sourceforge.net>
References: <CAPg+sBjNkzqTUupx5QYZ_uzMwAdY4qRc+PGR5R9qCKUxxcHx7g@mail.gmail.com>
In-Reply-To: <CAPg+sBjNkzqTUupx5QYZ_uzMwAdY4qRc+PGR5R9qCKUxxcHx7g@mail.gmail.com>
Content-Type: multipart/alternative;
	boundary="------------040503030007050105080107"
X-Spam-Score: 1.0 (+)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
	See http://spamassassin.org/tag/ for more details.
	1.0 HTML_MESSAGE           BODY: HTML included in message
X-Headers-End: 1YhQrs-0002h7-AQ
Subject: Re: [Bitcoin-development] Deprecating Bitcoin Core's
 regtest-specific `setgenerate` behaviour
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
	<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
	<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Sun, 12 Apr 2015 23:00:46 -0000

This is a multi-part message in MIME format.
--------------040503030007050105080107
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

I would recommend adding the new method and deprecating (as in warning
against using) the old one for one major release. Then removing it
altogether in the following major release.

I have written a Java RPC client and Groovy/Spock functional tests
<https://github.com/msgilligan/bitcoin-spock> that use the current call.
A separate `generate` or `generateblocks` call is a great idea.

However, I try to keep my tests compatible with the current stable and
unstable versions of Bitcoin Core (and the Omni Core fork) and would
have to write code that checks the RPC server version (or checks for the
presence of the new call, falling back to the old one) to support the
use cases that I need to support. Not a huge deal, but I'm probably not
the only one.

-- Sean


On 4/12/15 7:26 AM, Pieter Wuille wrote:
> Hello everyone,
>
> Bitcoin Core's `setgenerate` RPC call has had a special meaning for
> -regtest (namely instantaneously mining a number of blocks, instead of
> starting a background CPU miner).
>
> We're planning to deprecate that overloaded behaviour, and replace it
> with a separate RPC call `generate`. Is there any software or user who
> would need compatibility with the old behaviour? We're generally very
> conservative in changing RPC behaviour, but as this is not related to
> any production functionality, we may as well just switch it.
>
> Note that the bitcoin.org <http://bitcoin.org> developer documentation
> will need to be updated.
>
> -- 
> Pieter
>
>
>
> ------------------------------------------------------------------------------
> BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
> Develop your own process in accordance with the BPMN 2 standard
> Learn Process modeling best practices with Bonita BPM through live exercises
> http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
> source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
>
>
> _______________________________________________
> Bitcoin-development mailing list
> Bitcoin-development@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/bitcoin-development


--------------040503030007050105080107
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: 7bit

<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">I would recommend adding the new method
      and deprecating (as in warning against using) the old one for one
      major release. Then removing it altogether in the following major
      release.<br>
      <br>
      I have written a Java RPC client and Groovy/Spock functional tests
      <a class="moz-txt-link-rfc2396E" href="https://github.com/msgilligan/bitcoin-spock">&lt;https://github.com/msgilligan/bitcoin-spock&gt;</a> that use the
      current call. A separate `generate` or `generateblocks` call is a
      great idea.<br>
      <br>
      However, I try to keep my tests compatible with the current stable
      and unstable versions of Bitcoin Core (and the Omni Core fork) and
      would have to write code that checks the RPC server version (or
      checks for the presence of the new call, falling back to the old
      one) to support the use cases that I need to support. Not a huge
      deal, but I'm probably not the only one.<br>
      <br>
      -- Sean<br>
      <br>
      <br>
      On 4/12/15 7:26 AM, Pieter Wuille wrote:<br>
    </div>
    <blockquote
cite="mid:CAPg+sBjNkzqTUupx5QYZ_uzMwAdY4qRc+PGR5R9qCKUxxcHx7g@mail.gmail.com"
      type="cite">
      <div dir="ltr">
        <div>
          <div>
            <div>Hello everyone,<br>
              <br>
            </div>
            Bitcoin Core's `setgenerate` RPC call has had a special
            meaning for -regtest (namely instantaneously mining a number
            of blocks, instead of starting a background CPU miner).<br>
            <br>
            We're planning to deprecate that overloaded behaviour, and
            replace it with a separate RPC call `generate`. Is there any
            software or user who would need compatibility with the old
            behaviour? We're generally very conservative in changing RPC
            behaviour, but as this is not related to any production
            functionality, we may as well just switch it.<br>
            <br>
          </div>
          Note that the <a moz-do-not-send="true"
            href="http://bitcoin.org">bitcoin.org</a> developer
          documentation will need to be updated.<br>
          <br>
          -- <br>
        </div>
        Pieter<br>
        <br>
      </div>
      <br>
      <fieldset class="mimeAttachmentHeader"></fieldset>
      <br>
      <pre wrap="">------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
<a class="moz-txt-link-freetext" href="http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual">http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual</a>- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&amp;utm_medium=email&amp;utm_campaign=VA_SF</pre>
      <br>
      <fieldset class="mimeAttachmentHeader"></fieldset>
      <br>
      <pre wrap="">_______________________________________________
Bitcoin-development mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Bitcoin-development@lists.sourceforge.net">Bitcoin-development@lists.sourceforge.net</a>
<a class="moz-txt-link-freetext" href="https://lists.sourceforge.net/lists/listinfo/bitcoin-development">https://lists.sourceforge.net/lists/listinfo/bitcoin-development</a>
</pre>
    </blockquote>
    <br>
  </body>
</html>

--------------040503030007050105080107--