summaryrefslogtreecommitdiff
path: root/cd/5505cb9dcd25259056300bc155970fd6209775
blob: bff98e5bed0c900b9c3853a66f6a4581a1511d6e (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191]
	helo=mx.sourceforge.net)
	by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
	(envelope-from <jgarzik@bitpay.com>) id 1WrroN-0005kX-FH
	for bitcoin-development@lists.sourceforge.net;
	Tue, 03 Jun 2014 16:43:43 +0000
Received-SPF: pass (sog-mx-1.v43.ch3.sourceforge.com: domain of bitpay.com
	designates 209.85.212.171 as permitted sender)
	client-ip=209.85.212.171; envelope-from=jgarzik@bitpay.com;
	helo=mail-wi0-f171.google.com; 
Received: from mail-wi0-f171.google.com ([209.85.212.171])
	by sog-mx-1.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128)
	(Exim 4.76) id 1WrroL-00077Q-Jx
	for bitcoin-development@lists.sourceforge.net;
	Tue, 03 Jun 2014 16:43:43 +0000
Received: by mail-wi0-f171.google.com with SMTP id cc10so6811032wib.16
	for <bitcoin-development@lists.sourceforge.net>;
	Tue, 03 Jun 2014 09:43:35 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20130820;
	h=x-gm-message-state:mime-version:in-reply-to:references:from:date
	:message-id:subject:to:cc:content-type;
	bh=ipEzKTBdN8VWVQ4RhUfHz/tlIMoQKam9fEO94Q9s/cI=;
	b=FpJ7YsGGoCmX3v6Zcg38MMJ7CIz1+jpQWP7i3OW36LSPd/RYB+AwFdW6Ui7jOYZEQi
	POghautBYpbpHrCzGNb7uwsFyCMWDCLrMvmg1ra4p1teqv5NJyfKDH6i3Pm0L+plD5jo
	qD2xSrKD0nzPMx8IhigbERKYh9Bvf1vJDwxcwF1tTiuBjTuD54YYNvVeiBKbz/DsryOb
	ZAxfppUGotBkEqyKbcKAlLxqLbiO8O+O21tJ+JBm0qNy/J4B1J1nKZNFmQCPJyFFayIZ
	cOFO6JSs+xfxt8yf4eYRMiGbiw2TmfM1UisQEwHVgigePamtnTVNreS6X6irABNDUf2j
	hDhw==
X-Gm-Message-State: ALoCoQkF2p3+KZ78mPqE/pJdJyMjNHDNgEEvgkpSqXiHlSvWiCdOcEC2tjSj4OVfnh+EdiLk5Y7F
X-Received: by 10.194.87.200 with SMTP id ba8mr62749737wjb.28.1401813815090;
	Tue, 03 Jun 2014 09:43:35 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.194.240.166 with HTTP; Tue, 3 Jun 2014 09:43:15 -0700 (PDT)
In-Reply-To: <CANFXpYOdmweoxXRM_LcnB-jFNHt8kj_B0jTFZ00Jffi7UHvwPA@mail.gmail.com>
References: <CANFXpYOdmweoxXRM_LcnB-jFNHt8kj_B0jTFZ00Jffi7UHvwPA@mail.gmail.com>
From: Jeff Garzik <jgarzik@bitpay.com>
Date: Tue, 3 Jun 2014 12:43:15 -0400
Message-ID: <CAJHLa0OiFCX_CT-OLBaFHB5SGL0ADsXm7gQrsRs7inu=qM1E6g@mail.gmail.com>
To: Toshi Morita <toshi@peernova.com>
Content-Type: text/plain; charset=UTF-8
X-Spam-Score: -1.6 (-)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
	See http://spamassassin.org/tag/ for more details.
	-1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for
	sender-domain
	-0.0 SPF_PASS               SPF: sender matches SPF record
	-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from
	author's domain
	0.1 DKIM_SIGNED            Message has a DKIM or DK signature,
	not necessarily valid
	-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
X-Headers-End: 1WrroL-00077Q-Jx
Cc: bitcoin-development <bitcoin-development@lists.sourceforge.net>
Subject: Re: [Bitcoin-development] Another uninitialized memory problem
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
	<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
	<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Tue, 03 Jun 2014 16:43:43 -0000

I think I see the problem.


On Mon, Jun 2, 2014 at 4:01 PM, Toshi Morita <toshi@peernova.com> wrote:
> I'm seeing another uninitialized memory problem in bitcoind using valgrind:
>
> tm@tm-VirtualBox:~/bitcoind/bitcoin/src$ valgrind ./bitcoind
> ==2337== Memcheck, a memory error detector
> ==2337== Copyright (C) 2002-2012, and GNU GPL'd, by Julian Seward et al.
> ==2337== Using Valgrind-3.8.1 and LibVEX; rerun with -h for copyright info
> ==2337== Command: ./bitcoind
> ==2337==
> ==2337== Conditional jump or move depends on uninitialised value(s)
> ==2337==    at 0x319176: CWallet::LoadKeyMetadata(CPubKey const&,
> CKeyMetadata const&) (wallet.cpp:110)
> ==2337==    by 0x33645A: ReadKeyValue(CWallet*, CDataStream&, CDataStream&,
> CWalletScanState&, std::string&, std::string&) (walletdb.cpp:509)
> ==2337==    by 0x3374F0: CWalletDB::LoadWallet(CWallet*) (walletdb.cpp:623)
> ==2337==    by 0x3218FD: CWallet::LoadWallet(bool&) (wallet.cpp:1485)
> ==2337==    by 0x157F16: AppInit2(boost::thread_group&) (init.cpp:958)
> ==2337==    by 0x140142: AppInit(int, char**) (bitcoind.cpp:143)
> ==2337==    by 0x13649E: main (bitcoind.cpp:180)
> ==2337==
>
>
> ------------------------------------------------------------------------------
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and their
> applications. Written by three acclaimed leaders in the field,
> this first edition is now available. Download your free book today!
> http://p.sf.net/sfu/NeoTech
> _______________________________________________
> Bitcoin-development mailing list
> Bitcoin-development@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/bitcoin-development
>



-- 
Jeff Garzik
Bitcoin core developer and open source evangelist
BitPay, Inc.      https://bitpay.com/