1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
|
Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194]
helo=mx.sourceforge.net)
by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
(envelope-from <witchspace81@gmail.com>) id 1RHumk-000544-AH
for bitcoin-development@lists.sourceforge.net;
Sun, 23 Oct 2011 09:56:06 +0000
Received-SPF: pass (sog-mx-4.v43.ch3.sourceforge.com: domain of gmail.com
designates 209.85.213.47 as permitted sender)
client-ip=209.85.213.47; envelope-from=witchspace81@gmail.com;
helo=mail-yw0-f47.google.com;
Received: from mail-yw0-f47.google.com ([209.85.213.47])
by sog-mx-4.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128)
(Exim 4.76) id 1RHumj-0005R6-Ku
for bitcoin-development@lists.sourceforge.net;
Sun, 23 Oct 2011 09:56:06 +0000
Received: by ywf9 with SMTP id 9so3165187ywf.34
for <bitcoin-development@lists.sourceforge.net>;
Sun, 23 Oct 2011 02:56:00 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.182.50.8 with SMTP id y8mr1844147obn.79.1319363760161; Sun, 23
Oct 2011 02:56:00 -0700 (PDT)
Received: by 10.182.34.226 with HTTP; Sun, 23 Oct 2011 02:56:00 -0700 (PDT)
In-Reply-To: <CA+s+GJBo90gH4pRx7+vnHgy5y6bWF7My69jNj6J-RHw7bBqH8g@mail.gmail.com>
References: <CAMm66_=eqw9VqYrs5kv_i1di1FmDtP8X1dgBH90N0CuVvZswMA@mail.gmail.com>
<CA+s+GJBo90gH4pRx7+vnHgy5y6bWF7My69jNj6J-RHw7bBqH8g@mail.gmail.com>
Date: Sun, 23 Oct 2011 11:56:00 +0200
Message-ID: <CAJNQ0ssSQ0egHZ8YWFzrGv=LjfWQqV9V7qSeB01Zg2C4-LSZGQ@mail.gmail.com>
From: John Smith <witchspace81@gmail.com>
To: Bitcoin Dev <bitcoin-development@lists.sourceforge.net>
Content-Type: multipart/alternative; boundary=f46d0444741d41044e04aff45066
X-Spam-Score: -0.5 (/)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
See http://spamassassin.org/tag/ for more details.
-1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for
sender-domain
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider
(witchspace81[at]gmail.com)
-0.0 SPF_PASS SPF: sender matches SPF record
0.1 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in
digit (witchspace81[at]gmail.com)
1.0 HTML_MESSAGE BODY: HTML included in message
-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from
author's domain
0.1 DKIM_SIGNED Message has a DKIM or DK signature,
not necessarily valid
-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
X-Headers-End: 1RHumj-0005R6-Ku
Subject: [Bitcoin-development] Fwd: bitcoin scope issue in main.cpp
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Sun, 23 Oct 2011 09:56:06 -0000
--f46d0444741d41044e04aff45066
Content-Type: text/plain; charset=ISO-8859-1
FYI
It's in a disabled feature (replacement), so I'm not sure how important this
is, but it doesn't look good.
---------- Forwarded message ----------
From: Dean Gores <dmgores@gmail.com>
Date: Sun, Oct 23, 2011 at 11:15 AM
Subject: bitcoin scope issue in main.cpp
To: laanwj@gmail.com
You have "i" and "output" declared in the same scope in "main.cpp",
AcceptToMemoryPool. Below is the offending code.
for (int i = 0; i < vin.size(); i++)
{
COutPoint outpoint = vin[i].prevout;
if (!mapNextTx.count(outpoint) ||
mapNextTx[outpoint].ptx != ptxOld)
return false;
}
Cheers,
Dean Gores
--f46d0444741d41044e04aff45066
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
FYI<br>It's in a disabled feature (replacement), so I'm not sure ho=
w important this is, but it doesn't look good.<br><div class=3D"gmail_q=
uote"><br><div class=3D"gmail_quote">---------- Forwarded message ---------=
-<br>
From: <b class=3D"gmail_sendername">Dean Gores</b> <span dir=3D"ltr"><<a=
href=3D"mailto:dmgores@gmail.com" target=3D"_blank">dmgores@gmail.com</a>&=
gt;</span><br>Date: Sun, Oct 23, 2011 at 11:15 AM<br>
Subject: bitcoin scope issue in main.cpp<br>To: <a href=3D"mailto:laanwj@gm=
ail.com" target=3D"_blank">laanwj@gmail.com</a><br><br><br>You have "i=
" and "output" declared in the same scope in "main.cpp&=
quot;,<br>
AcceptToMemoryPool. =A0Below is the offending code.<br>
<br>
=A0 =A0 =A0 =A0 =A0 =A0for (int i =3D 0; i < vin.size(); i++)<br>
=A0 =A0 =A0 =A0 =A0 =A0{<br>
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0COutPoint outpoint =3D vin[i].prevout;<br>
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if (!mapNextTx.count(outpoint) ||<br>
mapNextTx[outpoint].ptx !=3D ptxOld)<br>
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return false;<br>
=A0 =A0 =A0 =A0 =A0 =A0}<br>
<br>
<br>
Cheers,<br>
<font color=3D"#888888">Dean Gores<br>
</font></div><br>
</div><br>
--f46d0444741d41044e04aff45066--
|
