1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
|
Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193]
helo=mx.sourceforge.net)
by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
(envelope-from <turkeybreast@yahoo.com>) id 1UpFhY-0004F8-QF
for bitcoin-development@lists.sourceforge.net;
Wed, 19 Jun 2013 10:33:20 +0000
X-ACL-Warn:
Received: from nm45-vm4.bullet.mail.bf1.yahoo.com ([216.109.115.63])
by sog-mx-3.v43.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256)
(Exim 4.76) id 1UpFhX-0000rk-Hf
for bitcoin-development@lists.sourceforge.net;
Wed, 19 Jun 2013 10:33:20 +0000
Received: from [66.196.81.172] by nm45.bullet.mail.bf1.yahoo.com with NNFMP;
19 Jun 2013 10:33:14 -0000
Received: from [98.139.212.237] by tm18.bullet.mail.bf1.yahoo.com with NNFMP;
19 Jun 2013 10:33:14 -0000
Received: from [127.0.0.1] by omp1046.mail.bf1.yahoo.com with NNFMP;
19 Jun 2013 10:33:14 -0000
X-Yahoo-Newman-Property: ymail-3
X-Yahoo-Newman-Id: 22105.71101.bm@omp1046.mail.bf1.yahoo.com
Received: (qmail 20631 invoked by uid 60001); 19 Jun 2013 10:33:13 -0000
X-YMail-OSG: VVQFTFkVM1kFS39kgSZIs8v9SRLre1ipYjPrCz_orpa.t76
EUO_R6VWmlA2MkGSWnUYk9bLkSkF7LrRgo2IJXOgjIJ2i0FgOaieYDlwgcfq
2XgZn5MwMC.UVz8y4uwIvyl8gRM1h6XehkZSyvb2U4mgI0hPj8NVgj1R0pyx
9KmjmiNghzv.MMCsf2qsld.42pfNMJjP3wBdA9oVprgJhkEbC5nGPIkmaAqr
yV8hS9INENuj3W8XnwgcobhYe4sUr_Utmb7DJ8ITWWQjq3KOMxsuR_xuYKX_
Gy1oRqq17O_jWcJ1d.A1kXapJQDlp4P941uEKGB7k14LYADUNI_tZnKEfSnC
trqjWkT0C0gS6vyQBw4E9s5CK2RSxj39YgDqQ1li29slvaauzpzIKFIT7HJi
cE8jZDljxyaqeGUOjAsJlccov5M1QVzD7Ww_KbuvssmbcSud3k82EvUNJpqL
0AIzU4z._4GpcYp85HXVY7zlxfzgMZTYtLkUSq9rcUv92AILl2XWxv78_Il_
P5tRivut2JU1tZsDKi.45Ali7WpREdLOSGbVjW.2iLuHoyiA..QR4vnkFbzu
nKEaDacqQjZk3s47oMrX.NE3dT86sB2iJAZqdTSHQoSCguud58eBGqeAo0A- -
Received: from [87.160.130.27] by web162701.mail.bf1.yahoo.com via HTTP;
Wed, 19 Jun 2013 03:33:13 PDT
X-Rocket-MIMEInfo: 002.001,
SXQncyBhIHByb2JsZW0gaWYgeW91IHdvcmsgd2l0aCBpdGVyYXRvcnMgdG8gZGVzZXJpYWxpemUgdGhlIGJ5dGUgc3RyZWFtLiBFdmVuIGZhaWxpbmcgdGhhdCwgaXQncyBqdXN0IHNsb3BweSBwcm9ncmFtbWluZy4gV2hhdCBoYXBwZW5zIGluIHRoZSBmdXR1cmUgd2hlbiBuZXcgZmllbGRzIGFyZSBhZGRlZCB0byB0aGUgdmVyc2lvbiBtZXNzYWdlPyBJdCdzIG5vdCBhIGJpZyBkZWFsIHRvIHNheSB0aGF0IHRoaXMgcHJvdG9jb2wgdmVyc2lvbiBoYXMgWCBudW1iZXIgb2YgZmllbGRzLCB0aGF0IChoaWdoZXIBMAEBAQE-
X-Mailer: YahooMailWebService/0.8.147.553
References: <1371577555.61696.YahooMailNeo@web162703.mail.bf1.yahoo.com>
<CANEZrP0ViJSQr_UUxLqM-eFTir=-FGwZ2cSxuPgaVi=KiM8gsA@mail.gmail.com>
<1371594630.18036.YahooMailNeo@web162703.mail.bf1.yahoo.com>
<CANEZrP3D6TRzzJOZ-mW67nJk_hqApt9quCYyoM8oF=ugDW_F6g@mail.gmail.com>
Message-ID: <1371637993.17115.YahooMailNeo@web162701.mail.bf1.yahoo.com>
Date: Wed, 19 Jun 2013 03:33:13 -0700 (PDT)
From: Turkey Breast <turkeybreast@yahoo.com>
To: "bitcoin-development@lists.sourceforge.net"
<bitcoin-development@lists.sourceforge.net>
In-Reply-To: <CANEZrP3D6TRzzJOZ-mW67nJk_hqApt9quCYyoM8oF=ugDW_F6g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
boundary="-350752386-1044354069-1371637993=:17115"
X-Spam-Score: -0.4 (/)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
See http://spamassassin.org/tag/ for more details.
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,
no trust [216.109.115.63 listed in list.dnswl.org]
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider
(turkeybreast[at]yahoo.com)
-1.3 RP_MATCHES_RCVD Envelope sender domain matches handover relay
domain 1.0 HTML_MESSAGE BODY: HTML included in message
-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from
author's domain
0.1 DKIM_SIGNED Message has a DKIM or DK signature,
not necessarily valid
-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
X-Headers-End: 1UpFhX-0000rk-Hf
Subject: Re: [Bitcoin-development] Missing fRelayTxes in version message
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
Reply-To: Turkey Breast <turkeybreast@yahoo.com>
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Wed, 19 Jun 2013 10:33:21 -0000
---350752386-1044354069-1371637993=:17115
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
It's a problem if you work with iterators to deserialize the byte stream. E=
ven failing that, it's just sloppy programming. What happens in the future =
when new fields are added to the version message? It's not a big deal to sa=
y that this protocol version has X number of fields, that (higher) protocol=
version message has X + N number of fields. Deterministic number of fields=
per protocol version is sensical and how Bitcoin has been for a long time.=
=0A=0AAnd yes, it was a problem for me that caused a lot of confusion why t=
his byte didn't exist in many version messages despite the standard saying =
it should and the code in bitcoind indicating it should. Nowhere was this w=
ritten. It doesn't help other implementations to have an unclear behaviour =
that depends on some magic from one implementation.=0A=0A=0A=0A____________=
____________________=0A From: Mike Hearn <mike@plan99.net>=0ATo: Turkey Bre=
ast <turkeybreast@yahoo.com> =0ACc: "bitcoin-development@lists.sourceforge.=
net" <bitcoin-development@lists.sourceforge.net> =0ASent: Wednesday, June 1=
9, 2013 11:39 AM=0ASubject: Re: [Bitcoin-development] Missing fRelayTxes in=
version message=0A =0A=0A=0AIt has to be optional because old clients don'=
t send it, obviously.=0A=0AWhy is this even an issue? There's no problem wi=
th variable length messages in any codebase that I'm aware of. Is this solv=
ing some actual problem?=0A=0A=0A=0AOn Wed, Jun 19, 2013 at 12:30 AM, Turke=
y Breast <turkeybreast@yahoo.com> wrote:=0A=0AThat's me. I never said to ma=
ke all messages fixed length. I said to make a fixed number of fields per p=
rotocol. So given a protocol version number, you know the number of fields =
in a message. This is not only easier for parsing messages, but just good p=
ractice. I don't see why a 1 byte flag needs to be optional anyway.=0A>=0A>=
=0A>=0A>=0A>________________________________=0A> From: Mike Hearn <mike@pla=
n99.net>=0A>To: Turkey Breast <turkeybreast@yahoo.com> =0A>Cc: Bitcoin Dev =
<bitcoin-development@lists.sourceforge.net> =0A>Sent: Tuesday, June 18, 201=
3 9:48 PM=0A>Subject: Re: [Bitcoin-development] Missing fRelayTxes in versi=
on message=0A> =0A>=0A>=0A>It's not a bug (although there was recently a ch=
ange to make bitcoind/qt always send this field anyway).=A0=0A>=0A>=0A>I do=
n't know where Amir is going with BIP 60. Version messages have always been=
variable length. There's nothing inherent in the Bitcoin protocol that say=
s all messages are fixed length, indeed, tx messages are allowed to have ar=
bitrary data appended after them that gets relayed.=0A>=0A>=0A>=0A>On Tue, =
Jun 18, 2013 at 7:45 PM, Turkey Breast <turkeybreast@yahoo.com> wrote:=0A>=
=0A>See this BIP. I'm not sure if this is a bug or what, but it would be go=
od if messages always had a fixed number of fields per protocol version.=0A=
>>=0A>>=0A>>https://en.bitcoin.it/wiki/BIP_0060#Code_Updates=0A>>=0A>>=0A>>=
This BIP details everything that needs to be done and proposes a protocol u=
pgrade.=0A>>=0A>>----------------------------------------------------------=
--------------------=0A>>This SF.net email is sponsored by Windows:=0A>>=0A=
>>Build for Windows Store.=0A>>=0A>>http://p.sf.net/sfu/windows-dev2dev=0A>=
>_______________________________________________=0A>>Bitcoin-development ma=
iling list=0A>>Bitcoin-development@lists.sourceforge.net=0A>>https://lists.=
sourceforge.net/lists/listinfo/bitcoin-development=0A>>=0A>>=0A>=0A>=0A>=0A=
>--------------------------------------------------------------------------=
----=0A>This SF.net email is sponsored by Windows:=0A>=0A>Build for Windows=
Store.=0A>=0A>http://p.sf.net/sfu/windows-dev2dev=0A>_____________________=
__________________________=0A>Bitcoin-development mailing list=0A>Bitcoin-d=
evelopment@lists.sourceforge.net=0A>https://lists.sourceforge.net/lists/lis=
tinfo/bitcoin-development=0A>=0A>
---350752386-1044354069-1371637993=:17115
Content-Type: text/html; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
<html><body><div style=3D"color:#000; background-color:#fff; font-family:ti=
mes new roman, new york, times, serif;font-size:12pt"><div><span>It's a pro=
blem if you work with iterators to deserialize the byte stream. Even failin=
g that, it's just sloppy programming. What happens in the future when new f=
ields are added to the version message? It's not a big deal to say that thi=
s protocol version has X number of fields, that (higher) protocol version m=
essage has X + N number of fields. Deterministic number of fields per proto=
col version is sensical and how Bitcoin has been for a long time.</span></d=
iv><div style=3D"color: rgb(0, 0, 0); font-size: 16px; font-family: times n=
ew roman,new york,times,serif; background-color: transparent; font-style: n=
ormal;"><br><span></span></div><div style=3D"color: rgb(0, 0, 0); font-size=
: 16px; font-family: times new roman,new york,times,serif; background-color=
: transparent; font-style: normal;"><span>And yes, it was a problem for me
that caused a lot of confusion why this byte didn't exist in many version =
messages despite the standard saying it should and the code in bitcoind ind=
icating it should. Nowhere was this written. It doesn't help other implemen=
tations to have an unclear behaviour that depends on some magic from one im=
plementation.<br></span></div><div><br></div> <div style=3D"font-family: t=
imes new roman, new york, times, serif; font-size: 12pt;"> <div style=3D"fo=
nt-family: times new roman, new york, times, serif; font-size: 12pt;"> <div=
dir=3D"ltr"> <hr size=3D"1"> <font face=3D"Arial" size=3D"2"> <b><span st=
yle=3D"font-weight:bold;">From:</span></b> Mike Hearn <mike@plan99.net&g=
t;<br> <b><span style=3D"font-weight: bold;">To:</span></b> Turkey Breast &=
lt;turkeybreast@yahoo.com> <br><b><span style=3D"font-weight: bold;">Cc:=
</span></b> "bitcoin-development@lists.sourceforge.net" <bitcoin-develop=
ment@lists.sourceforge.net> <br> <b><span style=3D"font-weight:
bold;">Sent:</span></b> Wednesday, June 19, 2013 11:39 AM<br> <b><span sty=
le=3D"font-weight: bold;">Subject:</span></b> Re: [Bitcoin-development] Mis=
sing fRelayTxes in version message<br> </font> </div> <div class=3D"y_msg_c=
ontainer"><br>=0A<meta http-equiv=3D"x-dns-prefetch-control" content=3D"off=
"><div id=3D"yiv2021377370"><div dir=3D"ltr">It has to be optional because =
old clients don't send it, obviously.<div><br></div><div style=3D"">Why is =
this even an issue? There's no problem with variable length messages in any=
codebase that I'm aware of. Is this solving some actual problem?</div>=0A<=
/div><div class=3D"yiv2021377370gmail_extra"><br><br><div class=3D"yiv20213=
77370gmail_quote">On Wed, Jun 19, 2013 at 12:30 AM, Turkey Breast <span dir=
=3D"ltr"><<a rel=3D"nofollow" ymailto=3D"mailto:turkeybreast@yahoo.com" =
target=3D"_blank" href=3D"mailto:turkeybreast@yahoo.com">turkeybreast@yahoo=
.com</a>></span> wrote:<br>=0A<blockquote class=3D"yiv2021377370gmail_qu=
ote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex=
;"><div><div style=3D"font-size:12pt;font-family:times new roman, new york,=
times, serif;"><div><span>That's me. I never said to make all messages fix=
ed length. I said to make a fixed number of fields per protocol. So given a=
protocol version number, you know the number of fields in a message. This =
is not only easier for parsing messages, but just good practice. I don't se=
e why a 1 byte flag needs to be optional anyway.<br>=0A</span></div><div cl=
ass=3D"yiv2021377370hm yiv2021377370HOEnZb"><div><br></div> </div><div sty=
le=3D"font-family:times new roman, new york, times, serif;font-size:12pt;">=
<div class=3D"yiv2021377370hm yiv2021377370HOEnZb"> </div><div style=3D"fon=
t-family:times new roman, new york, times, serif;font-size:12pt;">=0A<div c=
lass=3D"yiv2021377370hm yiv2021377370HOEnZb"> <div dir=3D"ltr"> <hr size=3D=
"1"> <font face=3D"Arial"> <b><span style=3D"font-weight:bold;">From:</spa=
n></b> Mike Hearn <<a rel=3D"nofollow" ymailto=3D"mailto:mike@plan99.net=
" target=3D"_blank" href=3D"mailto:mike@plan99.net">mike@plan99.net</a>>=
<br> <b><span style=3D"font-weight:bold;">To:</span></b> Turkey Breast <=
<a rel=3D"nofollow" ymailto=3D"mailto:turkeybreast@yahoo.com" target=3D"_bl=
ank" href=3D"mailto:turkeybreast@yahoo.com">turkeybreast@yahoo.com</a>> =
<br>=0A<b><span style=3D"font-weight:bold;">Cc:</span></b>=0A Bitcoin Dev &=
lt;<a rel=3D"nofollow" ymailto=3D"mailto:bitcoin-development@lists.sourcefo=
rge.net" target=3D"_blank" href=3D"mailto:bitcoin-development@lists.sourcef=
orge.net">bitcoin-development@lists.sourceforge.net</a>> <br> <b><span s=
tyle=3D"font-weight:bold;">Sent:</span></b> Tuesday, June 18, 2013 9:48 PM<=
br>=0A <b><span style=3D"font-weight:bold;">Subject:</span></b> Re: [Bitcoi=
n-development] Missing fRelayTxes in version message<br> </font> </div></di=
v><div><div class=3D"yiv2021377370h5"> <div><br>=0A<div><div dir=3D"ltr">It=
's not a bug (although there was recently a change to make bitcoind/qt alwa=
ys send this field anyway). <div><br></div><div>I don't know where Ami=
r is going with BIP 60. Version messages have always been variable length. =
There's nothing inherent in the Bitcoin protocol that says all messages are=
fixed length, indeed, tx messages are allowed to have arbitrary data appen=
ded after them that gets relayed.</div>=0A=0A</div><div><br><br><div>On Tue=
, Jun 18, 2013 at 7:45 PM, Turkey Breast <span dir=3D"ltr"><<a rel=3D"no=
follow" ymailto=3D"mailto:turkeybreast@yahoo.com" target=3D"_blank" href=3D=
"mailto:turkeybreast@yahoo.com">turkeybreast@yahoo.com</a>></span> wrote=
:<br>=0A<blockquote style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;p=
adding-left:1ex;"><div><div style=3D"font-size:12pt;font-family:times new r=
oman, new york, times, serif;"><div>See this BIP. I'm not sure if this is a=
bug or what, but it would be good if messages always had a fixed number of=
fields per protocol version.</div>=0A=0A<div><br></div><div style=3D"font-=
style:normal;font-size:16px;background-color:transparent;font-family:times =
new roman, new york, times, serif;"><a rel=3D"nofollow" target=3D"_blank" h=
ref=3D"https://en.bitcoin.it/wiki/BIP_0060#Code_Updates">https://en.bitcoin=
.it/wiki/BIP_0060#Code_Updates</a></div>=0A=0A<div style=3D"font-style:norm=
al;font-size:16px;background-color:transparent;font-family:times new roman,=
new york, times, serif;"><br></div><div style=3D"font-style:normal;font-si=
ze:16px;background-color:transparent;font-family:times new roman, new york,=
times, serif;">=0A=0AThis BIP details everything that needs to be done and=
proposes a protocol upgrade.<br></div></div></div><br>--------------------=
----------------------------------------------------------<br>=0AThis <a re=
l=3D"nofollow" target=3D"_blank" href=3D"http://sf.net/">SF.net</a> email i=
s sponsored by Windows:<br>=0A<br>=0ABuild for Windows Store.<br>=0A<br>=0A=
http://p.sf.net/sfu/windows-dev2dev<br>____________________________________=
___________<br>=0ABitcoin-development mailing list<br>=0A<a rel=3D"nofollow=
" ymailto=3D"mailto:Bitcoin-development@lists.sourceforge.net" target=3D"_b=
lank" href=3D"mailto:Bitcoin-development@lists.sourceforge.net">Bitcoin-dev=
elopment@lists.sourceforge.net</a><br>=0A<a rel=3D"nofollow" target=3D"_bla=
nk" href=3D"https://lists.sourceforge.net/lists/listinfo/bitcoin-developmen=
t">https://lists.sourceforge.net/lists/listinfo/bitcoin-development</a><br>=
=0A<br></blockquote></div><br></div>=0A</div><br><br></div> </div></div></d=
iv> </div> </div></div><br>-----------------------------------------------=
-------------------------------<br>=0AThis SF.net email is sponsored by Win=
dows:<br>=0A<br>=0ABuild for Windows Store.<br>=0A<br>=0A<a rel=3D"nofollow=
" target=3D"_blank" href=3D"http://p.sf.net/sfu/windows-dev2dev">http://p.s=
f.net/sfu/windows-dev2dev</a><br>__________________________________________=
_____<br>=0ABitcoin-development mailing list<br>=0A<a rel=3D"nofollow" ymai=
lto=3D"mailto:Bitcoin-development@lists.sourceforge.net" target=3D"_blank" =
href=3D"mailto:Bitcoin-development@lists.sourceforge.net">Bitcoin-developme=
nt@lists.sourceforge.net</a><br>=0A<a rel=3D"nofollow" target=3D"_blank" hr=
ef=3D"https://lists.sourceforge.net/lists/listinfo/bitcoin-development">htt=
ps://lists.sourceforge.net/lists/listinfo/bitcoin-development</a><br>=0A<br=
></blockquote></div><br></div>=0A</div><meta http-equiv=3D"x-dns-prefetch-c=
ontrol" content=3D"on"><br><br></div> </div> </div> </div></body></html>
---350752386-1044354069-1371637993=:17115--
|
