1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
|
Return-Path: <felix.wolfsteller@gmail.com>
Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org
[172.17.192.35])
by mail.linuxfoundation.org (Postfix) with ESMTPS id 88F5011C4
for <bitcoin-dev@lists.linuxfoundation.org>;
Mon, 15 Jan 2018 14:33:30 +0000 (UTC)
X-Greylist: whitelisted by SQLgrey-1.7.6
Received: from mail-io0-f182.google.com (mail-io0-f182.google.com
[209.85.223.182])
by smtp1.linuxfoundation.org (Postfix) with ESMTPS id B134E5B7
for <bitcoin-dev@lists.linuxfoundation.org>;
Mon, 15 Jan 2018 14:33:29 +0000 (UTC)
Received: by mail-io0-f182.google.com with SMTP id k18so13244817ioc.11
for <bitcoin-dev@lists.linuxfoundation.org>;
Mon, 15 Jan 2018 06:33:29 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=mime-version:in-reply-to:references:from:date:message-id:subject:to;
bh=qwkgHkdMDuGJKwB95L6mbfStVUCZdKoKVGbYWoOvrAA=;
b=Hz0KD2caZDcR78YowuQjvIzBgasQMJgiWmkDyOU06M8hwmHa17lQpuLNV5Jda57Pas
lcE71p7849sJ0xoVYyVGX08sO99CeLzFyOecFNJVUV1aOSFOEzk1vyabJTqq8AYS1Y6n
7f9JwLwEf+867wS2/AOctUNuUyizgGXO1eiwWCmCOmz1iP2grKDaY+N1yVfpvpbF7utM
kHXonhqyfGRoHfg1O0JQ8xr0QJCbMs/eMrExlib4Cl0ayVeOct1yHrLXCfIXXtitZRoQ
rg9zKz5LkZ++qOJJG1R9Y5+xSRqaQca0eFoIOZCjP3MKpdL7xiY87Sf79p3u7XOgEHqw
+nbg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:in-reply-to:references:from:date
:message-id:subject:to;
bh=qwkgHkdMDuGJKwB95L6mbfStVUCZdKoKVGbYWoOvrAA=;
b=MfcyqkliVdmMT4kL8MekKuNLgU7KSH/+mTBvi9BRTQ+p0YnrXYEBO55LuhUGfIMmbe
vxNHEkRdJyEmVgi1byT1Ym+pbzwKMeaGAhRsuXs2RjaRX9VEZjzcpj6yPZSGKem9oydJ
9HQF0wy+Pk9v7pfwiXZbxStNAK2Jcr7SG46U+Z2VGsCpvnMcsHKIyMICnu7i7ph3ixJd
hpnUyR+9jaE/SuMNlMP9ZLHeqNcFO8qhpjeIMwZPv88SdG9rL1shgNcLDW0LmZ4YEOex
40txcHTJukPhniEmujF4/+awF2n3lQJE9vJn3JekvEZXy+BA/QG/75ljsgTZVC1DXylq
oI4w==
X-Gm-Message-State: AKGB3mLHvBAx9Mc5uO4SViij9GHZ2kg43qBRv+VOpZPkGpV2OV4lMcIk
TUBID0x2Y/yMGYzSAj8adpmObMpaHAmiNN+Aurat5A==
X-Google-Smtp-Source: ACJfBotS1RJiiodsacfQA4PsADNQ93X3uWJ01a9ekx5EPU9KWRh01WsqhiTn83QLZpMXJnobIP20i9OEJu2aOog4ld8=
X-Received: by 10.107.197.5 with SMTP id v5mr34763754iof.281.1516026808800;
Mon, 15 Jan 2018 06:33:28 -0800 (PST)
MIME-Version: 1.0
Received: by 10.2.151.198 with HTTP; Mon, 15 Jan 2018 06:33:28 -0800 (PST)
In-Reply-To: <CALHCSvOn8YxFqGu4yXDPnFunNzmy=cmdwKBNmAL45Ymta3REig@mail.gmail.com>
References: <CALHCSvOn8YxFqGu4yXDPnFunNzmy=cmdwKBNmAL45Ymta3REig@mail.gmail.com>
From: Felix Wolfsteller <felix.wolfsteller@gmail.com>
Date: Mon, 15 Jan 2018 15:33:28 +0100
Message-ID: <CALHCSvMFro4v8g0f1yFT6jUdry7wKpJZyYgFU0NTbm2LG-5GRw@mail.gmail.com>
To: bitcoin-dev@lists.linuxfoundation.org
Content-Type: multipart/alternative; boundary="94eb2c18a43e689c570562d17f44"
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, HTML_MESSAGE,
RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
smtp1.linux-foundation.org
X-Mailman-Approved-At: Mon, 15 Jan 2018 22:43:06 +0000
Subject: Re: [bitcoin-dev] Update links (use ssl-variant) to
opensource.org/[..x..]MIT ?
X-BeenThere: bitcoin-dev@lists.linuxfoundation.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Bitcoin Protocol Discussion <bitcoin-dev.lists.linuxfoundation.org>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/bitcoin-dev>,
<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/>
List-Post: <mailto:bitcoin-dev@lists.linuxfoundation.org>
List-Help: <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev>,
<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Jan 2018 14:33:30 -0000
--94eb2c18a43e689c570562d17f44
Content-Type: text/plain; charset="UTF-8"
I am a bit disappointed about the feedback (just received one off-list ;)
), but understand now that this mailing list is protocol-only discussions.
So - sorry for that. Anybody interested can follow progress here:
https://github.com/bitcoin/bitcoin/issues/12190
Thanks, Felix
On Thu, Jan 4, 2018 at 11:08 AM, Felix Wolfsteller <
felix.wolfsteller@gmail.com> wrote:
> Hey there
> Most source files contain the "default" copyright-header (also build by a
> script in devtools/copyright_header.py), which points out that the MIT
> license can be found in the COPYING file or at http://www.opensource.org/
> licenses/mit-license.php.
>
> However, the provided link is 1) using http where it could use https, 2)
> resulting in a redirect (https://opensource.org/licenses/mit-license.php)
> anyway.
> I am strongly in favor of using https where possible (I guess there are
> many other non-ssl links in the code base, but lets tackle the easier ones
> first).
>
> I propose that I
> 1) create a issue on github,
> 2) `sed -i` the relevant links,
> 3) create a PR on github,
> 4) come back to the mailing list.
>
> This change would affect a few hundred files I guess.
>
> A question remaining is this change would require a
> copyright-year-extension (to 2018), too.
>
> An example header can be seen e.g. here
> https://github.com/bitcoin/bitcoin/blob/a9a49e6e7e8df13d80a6dc3245ce7e
> f041942e9b/src/consensus/merkle.cpp#L3
>
> I'd be happy about quick feedback - do not know the culture here, yet.
>
> Have fun
> Felix
>
--94eb2c18a43e689c570562d17f44
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr"><div>I am a bit disappointed about the feedback (just rece=
ived one off-list ;) ), but understand now that this mailing list is protoc=
ol-only discussions. So - sorry for that. Anybody interested can follow pro=
gress here:<br><a href=3D"https://github.com/bitcoin/bitcoin/issues/12190">=
https://github.com/bitcoin/bitcoin/issues/12190</a><br></div>Thanks, Felix<=
br></div><div class=3D"gmail_extra"><br><div class=3D"gmail_quote">On Thu, =
Jan 4, 2018 at 11:08 AM, Felix Wolfsteller <span dir=3D"ltr"><<a href=3D=
"mailto:felix.wolfsteller@gmail.com" target=3D"_blank">felix.wolfsteller@gm=
ail.com</a>></span> wrote:<br><blockquote class=3D"gmail_quote" style=3D=
"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir=3D=
"ltr"><div><div><div>Hey there<br></div>Most source files contain the "=
;default" copyright-header (also build by a script in devtools/copyrig=
ht_header.py), which points out that the MIT license can be found in the CO=
PYING file or at <span class=3D"m_5618360175334424174gmail-pl-c"><a href=3D=
"http://www.opensource.org/licenses/mit-license.php" target=3D"_blank">http=
://www.opensource.org/<wbr>licenses/mit-license.php</a>.<br><br></span></di=
v><span class=3D"m_5618360175334424174gmail-pl-c">However, the provided lin=
k is 1) using http where it could use https, 2) resulting in a redirect (<a=
href=3D"https://opensource.org/licenses/mit-license.php" target=3D"_blank"=
>https://opensource.org/<wbr>licenses/mit-license.php</a>) anyway.<br></spa=
n></div><span class=3D"m_5618360175334424174gmail-pl-c">I am strongly in fa=
vor of using https where possible (I guess there are many other non-ssl lin=
ks in the code base, but lets tackle the easier ones first).<br></span><div=
><span class=3D"m_5618360175334424174gmail-pl-c"><br></span><div><span clas=
s=3D"m_5618360175334424174gmail-pl-c">I propose that I</span></div><div><sp=
an class=3D"m_5618360175334424174gmail-pl-c">1) create a issue on github,</=
span></div><div><span class=3D"m_5618360175334424174gmail-pl-c">2) `sed -i`=
the relevant links,<br></span></div><div><span class=3D"m_5618360175334424=
174gmail-pl-c">3) create a PR on github,</span></div><div><span class=3D"m_=
5618360175334424174gmail-pl-c">4) come back to the mailing list.</span></di=
v><div><span class=3D"m_5618360175334424174gmail-pl-c"><br></span></div><di=
v><span class=3D"m_5618360175334424174gmail-pl-c">This change would affect =
a few hundred files I guess.<br></span></div><div><span class=3D"m_56183601=
75334424174gmail-pl-c"><br></span></div><div><span class=3D"m_5618360175334=
424174gmail-pl-c">A question remaining is this change would require a copyr=
ight-year-extension (to 2018), too.</span></div><div><span class=3D"m_56183=
60175334424174gmail-pl-c"><br></span></div><div><span class=3D"m_5618360175=
334424174gmail-pl-c">An example header can be seen e.g. here<br></span></di=
v><div><span class=3D"m_5618360175334424174gmail-pl-c"><a href=3D"https://g=
ithub.com/bitcoin/bitcoin/blob/a9a49e6e7e8df13d80a6dc3245ce7ef041942e9b/src=
/consensus/merkle.cpp#L3" target=3D"_blank">https://github.com/bitcoin/<wbr=
>bitcoin/blob/<wbr>a9a49e6e7e8df13d80a6dc3245ce7e<wbr>f041942e9b/src/consen=
sus/<wbr>merkle.cpp#L3</a><br></span></div><div><span class=3D"m_5618360175=
334424174gmail-pl-c"><br></span></div><div><span class=3D"m_561836017533442=
4174gmail-pl-c">I'd be happy about quick feedback - do not know the cul=
ture here, yet.</span></div><div><span class=3D"m_5618360175334424174gmail-=
pl-c"><br></span></div><div><span class=3D"m_5618360175334424174gmail-pl-c"=
>Have fun</span></div><span class=3D"HOEnZb"><font color=3D"#888888"><div><=
span class=3D"m_5618360175334424174gmail-pl-c">Felix<br></span></div></font=
></span></div></div>
</blockquote></div><br></div>
--94eb2c18a43e689c570562d17f44--
|
