summaryrefslogtreecommitdiff
path: root/b4/f6efcb043956c9f9f95974f7925c4b4b49336c
blob: 8599f781a25aabf641f150aee64f2f4072c19962 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
Return-Path: <eric@voskuil.org>
Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org
	[172.17.192.35])
	by mail.linuxfoundation.org (Postfix) with ESMTPS id DF81E72A
	for <bitcoin-dev@lists.linuxfoundation.org>;
	Mon, 13 Feb 2017 10:54:21 +0000 (UTC)
X-Greylist: whitelisted by SQLgrey-1.7.6
Received: from mail-pf0-f178.google.com (mail-pf0-f178.google.com
	[209.85.192.178])
	by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 63665CD
	for <bitcoin-dev@lists.linuxfoundation.org>;
	Mon, 13 Feb 2017 10:54:20 +0000 (UTC)
Received: by mail-pf0-f178.google.com with SMTP id e4so26872979pfg.1
	for <bitcoin-dev@lists.linuxfoundation.org>;
	Mon, 13 Feb 2017 02:54:20 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=voskuil-org.20150623.gappssmtp.com; s=20150623;
	h=subject:to:references:cc:from:message-id:date:user-agent
	:mime-version:in-reply-to;
	bh=xq/H1Z8n0S9CqY8Kkwv/scpfQRtIDflQxrUYW7tehO4=;
	b=if5Y7E+0tLrWi1cGhiVTmk0WnD9c+j3nuPHVqDMrTkujS5lqPk/x1a9L000BpAkvBa
	CdaQWndAJ3tevRGMzQ+OfupXHiifzKq/LIhk2pfRvw06OiMcU7SiAJU38ZcpLMqBpAU2
	LC2euFjFdDBtsuUHXr2yIZXLn1sjHiE57uJGfcKXjjC0dX7ubmxxc9cHcjY7h0fEPtFA
	VWp+7JRR0F/NmE8qo0wYImq+4PAGnMpQN+Kwrx2H41ukSW73bc/4BEifz8bBQ7wMCn4P
	H65EfO+KLBbe394qcV1FYM+t+2rDZuwpESoPooLcFCWOlrbtI3yrTjjixsOnVZh7Ac8e
	QZ6g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20161025;
	h=x-gm-message-state:subject:to:references:cc:from:message-id:date
	:user-agent:mime-version:in-reply-to;
	bh=xq/H1Z8n0S9CqY8Kkwv/scpfQRtIDflQxrUYW7tehO4=;
	b=pNxRpHoQ+G56813f4/itl+o4SRL0Yw6acp3FHa/3ASPw2+PyIwL1M+sixyBB83sJp0
	Pj5tBbFyPEFiBPh+RI5Rp2QSu5W56jO7graYAV51pyJaaenZfXEFEvZQ6H58EOZJNR/C
	dkT4aiw0r+c7zvQvhG6d+SN44BcJEDhWUx8Uhs2aupeujGVFKTdQU/w1u6Mbvk6zExTq
	LtiselWD8D1koYEw2HAXnNCdFRtCm8ZzUW19qerBkuEelpGW/49jvRvYWoX3bTFcqLGj
	gy12JYwM6vUs+PK3SLwujfbvnZA7v04BKHZZnqtLBytAeTkGrkzUXCWkGNXut25HhU7Z
	6RMw==
X-Gm-Message-State: AMke39nr6Zu6rdgmNzT9Skqm+ndmif6JVN5gV6P2o0MfS8XX2G9FZUghIygxKKaizlLZCg==
X-Received: by 10.98.252.203 with SMTP id e194mr25275646pfh.8.1486983259916;
	Mon, 13 Feb 2017 02:54:19 -0800 (PST)
Received: from ?IPv6:2601:600:9000:d69e:29fe:db3d:631d:9499?
	([2601:600:9000:d69e:29fe:db3d:631d:9499])
	by smtp.gmail.com with ESMTPSA id
	19sm13928953pfj.107.2017.02.13.02.54.18
	(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
	Mon, 13 Feb 2017 02:54:18 -0800 (PST)
To: Matt Corallo <lf-lists@mattcorallo.com>,
	Bitcoin Protocol Discussion <bitcoin-dev@lists.linuxfoundation.org>,
	Pieter Wuille <pieter.wuille@gmail.com>
References: <ba422d5e-8e96-3475-2a29-80d89fd67322@voskuil.org>
	<CAPg+sBhDjVuN6=tdvUcSY5OCdJD7s3Jp90K1qx0iRX+2WppUQQ@mail.gmail.com>
	<dde5349d-c430-ad57-30c7-77954ff1a94d@voskuil.org>
	<424C9E40-0B90-46A6-9C5E-30AE3E84E119@mattcorallo.com>
From: Eric Voskuil <eric@voskuil.org>
X-Enigmail-Draft-Status: N1110
Message-ID: <9ca02a65-23df-5eb4-f9bd-7e05b54ec4ea@voskuil.org>
Date: Mon, 13 Feb 2017 02:54:23 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
	Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <424C9E40-0B90-46A6-9C5E-30AE3E84E119@mattcorallo.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="rLjSAArkAN4xWPuSQ4FlU5RdD4aD4VV56"
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
	smtp1.linux-foundation.org
X-Mailman-Approved-At: Mon, 13 Feb 2017 11:43:34 +0000
Cc: libbitcoin@lists.dyne.org
Subject: Re: [bitcoin-dev] BIP151 protocol incompatibility
X-BeenThere: bitcoin-dev@lists.linuxfoundation.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Bitcoin Protocol Discussion <bitcoin-dev.lists.linuxfoundation.org>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/bitcoin-dev>,
	<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/>
List-Post: <mailto:bitcoin-dev@lists.linuxfoundation.org>
List-Help: <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev>,
	<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Feb 2017 10:54:22 -0000

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--rLjSAArkAN4xWPuSQ4FlU5RdD4aD4VV56
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 02/13/2017 02:16 AM, Matt Corallo wrote:
> For the reasons Pieter listed, an explicit part of our version
handshake and protocol negotiation is the exchange of otherwise-ignored
messages to set up optional features.

Only if the peer is at the protocol level that allows the message:

compact blocks:

https://github.com/bitcoin/bitcoin/blob/master/src/protocol.h#L217-L242

fee filter:

https://github.com/bitcoin/bitcoin/blob/master/src/protocol.h#L211-L216

send headers:

https://github.com/bitcoin/bitcoin/blob/master/src/protocol.h#L204-L210

filters:

https://github.com/bitcoin/bitcoin/blob/master/src/protocol.h#L170-L196

> Peers that do not support this ignore such messages, just as if they
had indicated they wouldn't support it, see, eg BIP 152's handshake. Not
sure why you consider this backwards incompatible, as I would say it's
pretty clearly allowing old nodes to communicate just fine.

No, it is not the same as BIP152. Control messages apart from BIP151 are
not sent until *after* the version is negotiated.

I assume that BIP151 is different in this manner because it has a desire
to negotiate encryption before any other communications, including versio=
n.

e


--rLjSAArkAN4xWPuSQ4FlU5RdD4aD4VV56
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQEcBAEBAgAGBQJYoZBfAAoJEDzYwH8LXOFOQgUIAJf2JQ6x2sDvZl2EsfWjp+2W
7pOFOZpQl3RrlOxB43lS0WyPsqjuIZNfx2b3UGJYU051bJJku8FskiTv+WHQ520E
yXPu9Je+dqbdUzchR1w7bql1iH5z8MaBw2lT9siWEmXfQnmTdtPjYrykUlb6s/GB
W1Tj06HWFI8SiEAgn+AVIYr1Wj1DXwNd06DIabAIIZ7tGYBtTlhUN0GbUPEfkqxr
UNDxKeS3/ASMZTHaObq/yC3ZN30/al7fi6OGPhjcmByCtljWOBq84CjHwbSg4DHg
L1YnuRA67mdT+VO2lqUGKyHPGGBXiqFr3C/4C8ui2O93Hp8oRB/lVHYA4dPA54E=
=Ayxv
-----END PGP SIGNATURE-----

--rLjSAArkAN4xWPuSQ4FlU5RdD4aD4VV56--