summaryrefslogtreecommitdiff
path: root/a6/07f94e266dc793cdebb65f13f9ef33d6e97b20
blob: 59b956c07f3a7a2637f3bc7b68d62ca86eed3eb3 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193]
	helo=mx.sourceforge.net)
	by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
	(envelope-from <michael.offel@web.de>) id 1RR40S-0007ok-Tp
	for bitcoin-development@lists.sourceforge.net;
	Thu, 17 Nov 2011 15:36:04 +0000
Received: from fmmailgate02.web.de ([217.72.192.227])
	by sog-mx-3.v43.ch3.sourceforge.com with esmtp (Exim 4.76)
	id 1RR40N-0004Xz-DM for bitcoin-development@lists.sourceforge.net;
	Thu, 17 Nov 2011 15:36:04 +0000
Received: from moweb002.kundenserver.de (moweb002.kundenserver.de
	[172.19.20.108])
	by fmmailgate02.web.de (Postfix) with ESMTP id C790C1BAEFBC8
	for <bitcoin-development@lists.sourceforge.net>;
	Thu, 17 Nov 2011 16:35:53 +0100 (CET)
Received: from miopc ([87.194.33.247]) by smtp.web.de (mrweb001) with ESMTPA
	(Nemesis) id 0Lb1rd-1R2gPw2TDV-00kefa; Thu, 17 Nov 2011 16:35:53 +0100
From: "Michael Offel" <michael.offel@web.de>
To: "'Bitcoin Dev'" <bitcoin-development@lists.sourceforge.net>
References: <CABsx9T2vRq++uqu=23YG86uQ=9ZpwjYv_8hOinWRyrd9YLv_PQ@mail.gmail.com>
In-Reply-To: <CABsx9T2vRq++uqu=23YG86uQ=9ZpwjYv_8hOinWRyrd9YLv_PQ@mail.gmail.com>
Date: Thu, 17 Nov 2011 15:35:36 -0000
Message-ID: <002d01cca53e$9552d1d0$bff87570$@offel@web.de>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Office Outlook 12.0
Thread-Index: AcylNUgyVupM8YmyTEieTGsreLhG1QACTw5w
Content-Language: en-gb
X-Provags-ID: V02:K0:l8NDYIgMnwZSVmjfqfeVbaLT2iWXrEQ3fop9UutVMvI
	fPnEzRoETnlZ/1CxeASH/GkIkug2SQ99/hRG9QbIGHxudRDBNs
	qWr3dlMz7g4hbyN3o/nJvYJn7Au4li8nnI5qIJFi3e4mNnXCGk
	v7U+vfcEJ4WOfrLiQEMtq9D7e/8W4TNfc0lcr4QTkZ4zVCX0WI
	XXiFfUj93g8kLGzFWXi7A==
X-Spam-Score: -1.2 (-)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
	See http://spamassassin.org/tag/ for more details.
	-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,
	no trust [217.72.192.227 listed in list.dnswl.org]
	0.0 MSGID_MULTIPLE_AT Message-ID contains multiple '@' characters
	0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider
	(michael.offel[at]web.de)
	-1.2 RP_MATCHES_RCVD Envelope sender domain matches handover relay
	domain
X-Headers-End: 1RR40N-0004Xz-DM
Subject: Re: [Bitcoin-development] There will be a release candidate 6...
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
	<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
	<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Thu, 17 Nov 2011 15:36:05 -0000

If you are going to support this use case, you should also notify the user
on wallet changes that results in invalidated backup. For example whenever
the key pool gets extended.

-----Original Message-----
From: Gavin Andresen [mailto:gavinandresen@gmail.com] 
Sent: 17 November 2011 14:28
To: Bitcoin Dev
Subject: [Bitcoin-development] There will be a release candidate 6...

I got email from a tester who gave this feedback:

> I think that user behaviour: encrypt wallet -> backup -> do some 
> activity -> restore backup -> BOOM. Is perfectly natural user 
> behaviour and it will happen. For example when generating a wallet on 
> a secure computer and then moving it to an insecure one.

I agree that is likely to happen and, when it does, will be disastrous.
So I'll be reworking the wallet encrypt/rewrite code today and creating a
release candidate 6.

My previous attempt (encrypt, invalidating keypool, then unlock and write a
new keypool) resulted in unencrypted private keys in the new wallet.

I think this will work, I'll implement and test today.

Invalidate all the old keypool keys in the old wallet.Write new keypool keys
to the old wallet.Encrypt all the keys in the old wallet.Rewrite the old
wallet to create a new wallet.Shutdown/restart.
IF ANYBODY IS WILLING TO HELP:

There is still a mysterious problem with bdb throwing an exception when
dbenv.close(0) is called during shutdown. If you can compile a -g version of
bdb and then step through DbEnv::close in a debugger and tell me why it is
throwing an exception that would be extremely helpful.
--
--
Gavin Andresen

----------------------------------------------------------------------------
--
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security threats,
fraudulent activity, and more. Splunk takes this data and makes sense of it.
IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
_______________________________________________
Bitcoin-development mailing list
Bitcoin-development@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bitcoin-development