summaryrefslogtreecommitdiff
path: root/a3/1c5542d3880665af6f23d00d9676ed91c3d082
blob: fb69e85dfa3b932764efaa8b1f17d91bb1ceea59 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194]
	helo=mx.sourceforge.net)
	by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
	(envelope-from <pieter.wuille@gmail.com>) id 1Whagb-00033T-1h
	for bitcoin-development@lists.sourceforge.net;
	Tue, 06 May 2014 08:25:13 +0000
Received-SPF: pass (sog-mx-4.v43.ch3.sourceforge.com: domain of gmail.com
	designates 209.85.213.181 as permitted sender)
	client-ip=209.85.213.181; envelope-from=pieter.wuille@gmail.com;
	helo=mail-ig0-f181.google.com; 
Received: from mail-ig0-f181.google.com ([209.85.213.181])
	by sog-mx-4.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128)
	(Exim 4.76) id 1Whaga-0007Dm-61
	for bitcoin-development@lists.sourceforge.net;
	Tue, 06 May 2014 08:25:12 +0000
Received: by mail-ig0-f181.google.com with SMTP id h3so2650105igd.14
	for <bitcoin-development@lists.sourceforge.net>;
	Tue, 06 May 2014 01:25:06 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.50.85.37 with SMTP id e5mr30342623igz.43.1399364706254; Tue,
	06 May 2014 01:25:06 -0700 (PDT)
Received: by 10.50.100.72 with HTTP; Tue, 6 May 2014 01:25:06 -0700 (PDT)
In-Reply-To: <da34991a7a2db8f6f15401ed614cfe1e.squirrel@fulvetta.riseup.net>
References: <CACUQsLJwNo=GtcozCRpZU9PDDJE1fY-mnMomCUtf0WCsgGEnfA@mail.gmail.com>
	<da34991a7a2db8f6f15401ed614cfe1e.squirrel@fulvetta.riseup.net>
Date: Tue, 6 May 2014 10:25:06 +0200
Message-ID: <CAPg+sBj4e-rXxjda9=_q6R+wxUfufGnvLU0v=BmQ1+g742BMKA@mail.gmail.com>
From: Pieter Wuille <pieter.wuille@gmail.com>
To: odinn.cyberguerrilla@riseup.net
Content-Type: text/plain; charset=ISO-8859-1
X-Spam-Score: -1.6 (-)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
	See http://spamassassin.org/tag/ for more details.
	-1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for
	sender-domain
	0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider
	(pieter.wuille[at]gmail.com)
	-0.0 SPF_PASS               SPF: sender matches SPF record
	-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from
	author's domain
	0.1 DKIM_SIGNED            Message has a DKIM or DK signature,
	not necessarily valid
	-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
X-Headers-End: 1Whaga-0007Dm-61
Cc: Bitcoin Dev <bitcoin-development@lists.sourceforge.net>
Subject: Re: [Bitcoin-development] Bug in key.cpp
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
	<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
	<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Tue, 06 May 2014 08:25:13 -0000

On Tue, May 6, 2014 at 5:12 AM,  <odinn.cyberguerrilla@riseup.net> wrote:
> You are right there is a bug in there.
>
> But the value is not 25% I think.  Tinker some more. :-)
>
>>
>> Afaict, 3 is a perfectly valid value, meaning 25% of sig-> key recoveries
>> would fail erroneously...

Values 2 and 3 are only needed in theory. They together shouldn't
occur more than once in 2**127 (when the signature value is between
the group size and the field size).

That said, this is indeed a bug.

-- 
Pieter