summaryrefslogtreecommitdiff
path: root/a1/c2b050d11774a6ae76d28cdfeaef194d7b98b1
blob: 578c3b23b15dd055fb21fa7bebb755de78c5b817 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193]
	helo=mx.sourceforge.net)
	by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
	(envelope-from <gronager@ceptacle.com>) id 1Rt5N6-0006Fx-5j
	for bitcoin-development@lists.sourceforge.net;
	Thu, 02 Feb 2012 22:43:16 +0000
X-ACL-Warn: 
Received: from 2508ds5-oebr.0.fullrate.dk ([95.166.54.49]
	helo=mail.ceptacle.com)
	by sog-mx-3.v43.ch3.sourceforge.com with esmtp (Exim 4.76)
	id 1Rt5N4-0000wv-LX for bitcoin-development@lists.sourceforge.net;
	Thu, 02 Feb 2012 22:43:16 +0000
Received: from localhost (localhost [127.0.0.1])
	by mail.ceptacle.com (Postfix) with ESMTP id B6FB4169B8C8;
	Thu,  2 Feb 2012 23:43:08 +0100 (CET)
X-Virus-Scanned: amavisd-new at ceptacle.com
Received: from mail.ceptacle.com ([127.0.0.1])
	by localhost (server.ceptacle.private [127.0.0.1]) (amavisd-new,
	port 10024)
	with ESMTP id WptH-Td7Fn+i; Thu,  2 Feb 2012 23:43:07 +0100 (CET)
Received: from [10.0.1.28] (2508ds5-oebr.0.fullrate.dk [95.166.54.49])
	by mail.ceptacle.com (Postfix) with ESMTPSA id D8448169B8BE;
	Thu,  2 Feb 2012 23:43:07 +0100 (CET)
Mime-Version: 1.0 (Apple Message framework v1251.1)
Content-Type: text/plain; charset=iso-8859-1
From: =?iso-8859-1?Q?Michael_Gr=F8nager?= <gronager@ceptacle.com>
In-Reply-To: <201202021130.12213.luke@dashjr.org>
Date: Thu, 2 Feb 2012 23:43:07 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <50342F76-062C-4A88-A5DA-A77C799AEC80@ceptacle.com>
References: <31B4BA03-FE8A-4730-9EFD-9850BC894C3B@ceptacle.com>
	<201202021130.12213.luke@dashjr.org>
To: "Luke-Jr" <luke@dashjr.org>
X-Mailer: Apple Mail (2.1251.1)
X-Spam-Score: 0.0 (/)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
	See http://spamassassin.org/tag/ for more details.
X-Headers-End: 1Rt5N4-0000wv-LX
Cc: bitcoin-development@lists.sourceforge.net
Subject: Re: [Bitcoin-development] libcoin (HEAD) now supports boost < 1.47
	- please test
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
	<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
	<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Thu, 02 Feb 2012 22:43:16 -0000

Thanks for the patch and the detective work!

Enabling dynamic libs was on my TODO, but on the =
Redmond_OS_not_to_be_mentioned you need to :
* prepend class definitions with __declspec(dllexport) when you compile =
the dll
* prepend class definitions with __declspec(dllimport) when you use the =
dll
I just love the way they spoil their developers...

I have the framework to automate this with CMake from a former project, =
but I havn't tested it for libcoin yet, hence the static build. And =
well, iOS also has this fetich for static libs.

I also recall another issue with dll's: If you define a global variable =
it is shared between all executables using this dll. I have still a =
handful of globals to clean out, namely those related to logging - I =
will do so, but it has not yet been a top priority.=20

So, feel free to use dynamic libs on unix'es, but on windows it is .libs =
for a little while longer.

Will fix the Qt stuff in CMake - thanks!

Cheers,

Michael


On 02/02/2012, at 17:30, Luke-Jr wrote:

> On Thursday, February 02, 2012 8:46:05 AM Michael Gr=F8nager wrote:
>> Please test and feed back.
>=20
> I found the problem: you are trying to use static libraries. Best =
practices=20
> are to use shared libraries (except for specific scenarios like =
universal=20
> "Linux" binaries) and most distros do not have static libraries =
installed by=20
> default.
>=20
> The coinQt stuff was also creating a problem.
>=20
> I am able to build with this patch:
> diff --git a/CMakeLists.txt b/CMakeLists.txt
> index dea37c4..b876881 100644
> --- a/CMakeLists.txt
> +++ b/CMakeLists.txt
> @@ -352,7 +352,7 @@ ENDIF(BDB_FOUND)
> #Note: We need as a minimum Boost 1.47 to support the signal_set used =
in=20
> Server. A backup signal_set has been created, though.
> SET(Boost_NO_BOOST_CMAKE ON)
> SET(Boost_ADDITIONAL_VERSIONS "1.47" "1.47.0" "1.48" "1.48.0")
> -SET(Boost_USE_STATIC_LIBS        ON)
> +#SET(Boost_USE_STATIC_LIBS        ON)
> SET(Boost_USE_MULTITHREADED      ON)
> SET(Boost_USE_STATIC_RUNTIME    OFF)
>=20
> @@ -804,9 +804,9 @@ SET(PKGCONFIG_FILES
> #  libcoin-coinMine
> )
>=20
> -IF(QT4_FOUND)
> -  SET(PKGCONFIG_FILES ${PKGCONFIG_FILES} libcoin-coinQt)
> -ENDIF(QT4_FOUND)
> +#IF(QT4_FOUND)
> +#  SET(PKGCONFIG_FILES ${PKGCONFIG_FILES} libcoin-coinQt)
> +#ENDIF(QT4_FOUND)
>=20
> FOREACH(PKGCONFIG_FILE ${PKGCONFIG_FILES})
>   =
CONFIGURE_FILE(${PROJECT_SOURCE_DIR}/packaging/pkgconfig/${PKGCONFIG_FILE}=
.pc.in
> diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
> index 0011392..67044d1 100644
> --- a/src/CMakeLists.txt
> +++ b/src/CMakeLists.txt
> @@ -19,9 +19,9 @@ FOREACH( mylibfolder
>=20
> ENDFOREACH()
>=20
> -IF (QT4_FOUND AND NOT ANDROID)
> -    ADD_SUBDIRECTORY(coinQt)
> -ENDIF()
> +#IF (QT4_FOUND AND NOT ANDROID)
> +#    ADD_SUBDIRECTORY(coinQt)
> +#ENDIF()
>=20
> IF(ANDROID)
>     configure_file("${LIBCOIN_ANDROID_TEMPLATES}/Android.mk.src.in"=20
> "${CMAKE_CURRENT_BINARY_DIR}/Android.mk")

Michael Gronager, PhD
Director, Ceptacle
Jens Juels Gade 33
2100 Copenhagen E
Mobile: +45 31 45 14 01
E-mail: gronager@ceptacle.com
Web: http://www.ceptacle.com/