summaryrefslogtreecommitdiff
path: root/9f/8920076c0f1738ae9fc44f3b7b6bc1918af16f
blob: 8b607efa880c8c402d4d3edf5931e4dd936ecbcc (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193]
	helo=mx.sourceforge.net)
	by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
	(envelope-from <michael@ndrix.org>) id 1RIOMy-00051d-9X
	for bitcoin-development@lists.sourceforge.net;
	Mon, 24 Oct 2011 17:31:28 +0000
X-ACL-Warn: 
Received: from out5.smtp.messagingengine.com ([66.111.4.29])
	by sog-mx-3.v43.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256)
	(Exim 4.76) id 1RIOMx-000542-0m
	for bitcoin-development@lists.sourceforge.net;
	Mon, 24 Oct 2011 17:31:28 +0000
Received: from compute3.internal (compute3.nyi.mail.srv.osa [10.202.2.43])
	by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id 9430620908
	for <bitcoin-development@lists.sourceforge.net>;
	Mon, 24 Oct 2011 13:14:10 -0400 (EDT)
Received: from frontend1.nyi.mail.srv.osa ([10.202.2.160])
	by compute3.internal (MEProxy); Mon, 24 Oct 2011 13:14:10 -0400
X-Sasl-enc: 6Gbf3K/usqW2fP/Cmx9459JkEhBcU9pbYlvyUKJxwSVX 1319476450
Received: from mail-wy0-f175.google.com (mail-wy0-f175.google.com
	[74.125.82.175])
	by mail.messagingengine.com (Postfix) with ESMTPSA id 4976740BEFA
	for <bitcoin-development@lists.sourceforge.net>;
	Mon, 24 Oct 2011 13:14:10 -0400 (EDT)
Received: by wyg19 with SMTP id 19so9411192wyg.34
	for <bitcoin-development@lists.sourceforge.net>;
	Mon, 24 Oct 2011 10:14:09 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.227.11.75 with SMTP id s11mr9837551wbs.62.1319476449586; Mon,
	24 Oct 2011 10:14:09 -0700 (PDT)
Received: by 10.180.96.101 with HTTP; Mon, 24 Oct 2011 10:14:09 -0700 (PDT)
In-Reply-To: <CABsx9T2v4uhUdsWEg58Xs2OhOf3ED0Q2LGmkrRpdJDxvVMexdQ@mail.gmail.com>
References: <44861.134.106.52.172.1319444997.squirrel@webmail.uni-osnabrueck.de>
	<CABsx9T2v4uhUdsWEg58Xs2OhOf3ED0Q2LGmkrRpdJDxvVMexdQ@mail.gmail.com>
Date: Mon, 24 Oct 2011 11:14:09 -0600
Message-ID: <CAFHuXub-XSS5zKfCvhuK4GH3MKOaSqsyWT4Px9en+2p7_USG-Q@mail.gmail.com>
From: Michael Hendricks <michael@ndrix.org>
To: Gavin Andresen <gavinandresen@gmail.com>
Content-Type: multipart/alternative; boundary=002215974d36112e1904b00e8d5b
X-Spam-Score: 1.0 (+)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
	See http://spamassassin.org/tag/ for more details.
	1.0 HTML_MESSAGE           BODY: HTML included in message
	0.1 DKIM_SIGNED            Message has a DKIM or DK signature,
	not necessarily valid
	-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
X-Headers-End: 1RIOMx-000542-0m
Cc: Bitcoin Dev <bitcoin-development@lists.sourceforge.net>
Subject: Re: [Bitcoin-development] Determine input addresses of a transaction
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
	<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
	<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Mon, 24 Oct 2011 17:31:28 -0000

--002215974d36112e1904b00e8d5b
Content-Type: text/plain; charset=UTF-8

On Mon, Oct 24, 2011 at 8:55 AM, Gavin Andresen <gavinandresen@gmail.com>wrote:

> If you assume the client has all previous transactions, then you could
> get the transaction input's prevout (from the memory pool or disk) and
> then ExtractAddress() from it. That is probably a bad idea for
> listtransactions, since fetching all the previous inputs from disk
> just so you can check to see if they're 'green' violates the "a
> feature shouldn't cost anything if it is not being used" design
> principle.
>

Are there current users of gettransaction for whom the performance penalty
would be problematic?  If so, perhaps gettransaction could take an optional
second argument includeinputaddresses which defaults to false.

-- 
Michael

--002215974d36112e1904b00e8d5b
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div class=3D"gmail_quote">On Mon, Oct 24, 2011 at 8:55 AM, Gavin Andresen =
<span dir=3D"ltr">&lt;<a href=3D"mailto:gavinandresen@gmail.com">gavinandre=
sen@gmail.com</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" st=
yle=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class=3D"im"><span style=3D"background-color: transparent; ">If you as=
sume the client has all previous transactions, then you could</span></div>
get the transaction input&#39;s prevout (from the memory pool or disk) and<=
br>
then ExtractAddress() from it. That is probably a bad idea for<br>
listtransactions, since fetching all the previous inputs from disk<br>
just so you can check to see if they&#39;re &#39;green&#39; violates the &q=
uot;a<br>
feature shouldn&#39;t cost anything if it is not being used&quot; design<br=
>
principle.<br></blockquote><div><br></div><div><span style=3D"background-co=
lor: transparent; ">Are there current users of gettransaction for whom the =
performance penalty would be problematic? =C2=A0If so, perhaps gettransacti=
on could take an optional second argument includeinputaddresses which defau=
lts to false.</span></div>
<div><br></div><div>--=C2=A0</div><div>Michael</div></div>

--002215974d36112e1904b00e8d5b--