summaryrefslogtreecommitdiff
path: root/86/40dd15d4596bcccc454d1f7c06838bba642f76
blob: 75cadafc2113217f412ff6aa7f7c9f547a595dc8 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
Return-Path: <pete@petertodd.org>
Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org
	[172.17.192.35])
	by mail.linuxfoundation.org (Postfix) with ESMTPS id 3BCD183D
	for <bitcoin-dev@lists.linuxfoundation.org>;
	Thu, 20 Aug 2015 09:13:47 +0000 (UTC)
X-Greylist: from auto-whitelisted by SQLgrey-1.7.6
Received: from outmail148100.authsmtp.co.uk (outmail148100.authsmtp.co.uk
	[62.13.148.100])
	by smtp1.linuxfoundation.org (Postfix) with ESMTP id 5597C1C2
	for <bitcoin-dev@lists.linuxfoundation.org>;
	Thu, 20 Aug 2015 09:13:46 +0000 (UTC)
Received: from mail-c235.authsmtp.com (mail-c235.authsmtp.com [62.13.128.235])
	by punt15.authsmtp.com (8.14.2/8.14.2/) with ESMTP id t7K9DfwI031850;
	Thu, 20 Aug 2015 10:13:41 +0100 (BST)
Received: from muck ([72.143.234.218]) (authenticated bits=128)
	by mail.authsmtp.com (8.14.2/8.14.2/) with ESMTP id t7K9DZBX065595
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);
	Thu, 20 Aug 2015 10:13:39 +0100 (BST)
Date: Thu, 20 Aug 2015 02:13:34 -0700
From: Peter Todd <pete@petertodd.org>
To: Mike Hearn <hearn@vinumeris.com>
Message-ID: <20150820091334.GA5448@muck>
References: <CALqxMTFkgGx0FxMiZ77inOZSs_+TQ88Wpj-q-c12COkO9tP4gQ@mail.gmail.com>
	<CA+w+GKTXAvq76sX4ttiYHhRcGp1MOynGAovYs8Dq1A1Q=9K4KQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="rwEMma7ioTxnRzrJ"
Content-Disposition: inline
In-Reply-To: <CA+w+GKTXAvq76sX4ttiYHhRcGp1MOynGAovYs8Dq1A1Q=9K4KQ@mail.gmail.com>
X-Server-Quench: bf4a89f0-471b-11e5-b398-002590a15da7
X-AuthReport-Spam: If SPAM / abuse - report it at:
	http://www.authsmtp.com/abuse
X-AuthRoute: OCd2Yg0TA1ZNQRgX IjsJECJaVQIpKltL GxAVKBZePFsRUQkR
	aQdMdAIUGUATAgsB AmMbWlReUV57XWM7 bAhPbAFefEhNWxto
	UUBWR1pVCwQmRRt6 D2p0IHFycQBDcXs+ ZEdjV3YVDhJ+JE50
	FE5JEWoHN3phaTUa TRJbfgtJcANIexZF O1F6ACIKLwdSbGoL
	FQ4vNDcwO3BTJTpg CisMMVkVQEBDLgJ0 aRcYHl0A
X-Authentic-SMTP: 61633532353630.1023:706
X-AuthFastPath: 0 (Was 255)
X-AuthSMTP-Origin: 72.143.234.218/587
X-AuthVirus-Status: No virus detected - but ensure you scan with your own
	anti-virus system.
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW
	autolearn=ham version=3.3.1
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
	smtp1.linux-foundation.org
Cc: Bitcoin Dev <bitcoin-dev@lists.linuxfoundation.org>
Subject: Re: [bitcoin-dev] Bitcoin XT Fork
X-BeenThere: bitcoin-dev@lists.linuxfoundation.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Bitcoin Development Discussion <bitcoin-dev.lists.linuxfoundation.org>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/bitcoin-dev>,
	<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/>
List-Post: <mailto:bitcoin-dev@lists.linuxfoundation.org>
List-Help: <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev>,
	<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Aug 2015 09:13:47 -0000


--rwEMma7ioTxnRzrJ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Aug 20, 2015 at 11:00:14AM +0200, Mike Hearn via bitcoin-dev wrote:
> >
> > It is just that no one else is reckless enough to bypass the review pro=
cess
>=20
>=20
> I keep seeing this notion crop up.
>=20
> I want to kill this idea right now:
>=20
>    - There were months of public discussion leading to up the authoring of
>    BIP 101, both on this mailing list and elsewhere.
>=20
>    - BIP 101 was submitted for review via the normal process. Jeff Garzik
>    specifically called Gavin out on Twitter and thanked him for following=
 the
>    process:
>=20
>    https://twitter.com/jgarzik/status/614412097359708160
>=20
>    https://github.com/bitcoin/bips/pull/163
>=20
>    As you can see, other than a few minor typo fixes and a comment by sip=
a,
>    there was no other review offered.
>=20
>    - The implementation for BIP 101 was submitted to Bitcoin Core as a pu=
ll
>    request, to invoke the code review process:
>=20
>    https://github.com/bitcoin/bitcoin/pull/6341
>=20
>    Some minor code layout suggestions were made by Cory and incorporated.
>    Peter popped up to say there was no chance it'd ever be accepted .....=
 and
>    no further review was done.

No, I said there was no chance it'd be accepted "due to a number of
BIP-level issues in addition to debate about the patch itself. For
instance, Gavin has never given any details about testing; at minimum
we'd need a BIP16 style quality assurance document. We also frown on
writing software with building expiration dates, let alone expiration
dates that trigger non-deterministically. (Note how my recently merged
CLTV considered the year 2038 problem to avoid needing a hard fork at
that date)"

Of course no further review was done - issues were identified and they
didn't get fixed. Why would we do further review on something that was
broken whose author wasn't interested in fixing even non-controversial
and obvious problems?

The process is to do review, fix issues identified, and repeat until all
issues are fixed.

--=20
'peter'[:-1]@petertodd.org
00000000000000000402fe6fb9ad613c93e12bddfc6ec02a2bd92f002050594d

--rwEMma7ioTxnRzrJ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----

iQGrBAEBCACVBQJV1Zo8XhSAAAAAABUAQGJsb2NraGFzaEBiaXRjb2luLm9yZzAw
MDAwMDAwMDAwMDAwMDAwNDAyZmU2ZmI5YWQ2MTNjOTNlMTJiZGRmYzZlYzAyYTJi
ZDkyZjAwMjA1MDU5NGQvFIAAAAAAFQARcGthLWFkZHJlc3NAZ251cGcub3JncGV0
ZUBwZXRlcnRvZC5vcmcACgkQwIXyHOf0udyC7QgAhO1mY/Tk0GlujChVVFx/HFjV
ozYQrEjWdOotW4sp79/B8tOsGyvOe+5+rcXgXS4Fc7Uq3GQfuqKD96WGtAQBHLCs
U367TeV+4tTA6flbd4+mx0F2Y/OJrYUh24N/jE76aPJHyaIJyyGyq8qGu/RK3U5X
oz3qcaj/APBXPm0uYMTHDwg3tp84DHZnZ/uHfB87BWkE03ciUeR0hnV8k7Q/333l
e135t15W+P2ixOj+jMThQ0oEOppEC1TU3W+nfBh57lA4WvOzPSQPl1uoi68ideOW
dzFXJy68MiRREJcdDzUTDP83PmIbFOJ85Ng1NeCnM/pTDg+F/HkOQZNgX64gLw==
=8BzH
-----END PGP SIGNATURE-----

--rwEMma7ioTxnRzrJ--