summaryrefslogtreecommitdiff
path: root/7a/24889ff001cb35564d1200f12e2d9d51497ace
blob: 7ccb604beb24d63382eed88730311fcbbc78f7ed (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191]
	helo=mx.sourceforge.net)
	by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
	(envelope-from <wtogami@gmail.com>) id 1Vo1i7-0002Gi-Co
	for bitcoin-development@lists.sourceforge.net;
	Wed, 04 Dec 2013 01:57:07 +0000
Received-SPF: pass (sog-mx-1.v43.ch3.sourceforge.com: domain of gmail.com
	designates 209.85.192.175 as permitted sender)
	client-ip=209.85.192.175; envelope-from=wtogami@gmail.com;
	helo=mail-pd0-f175.google.com; 
Received: from mail-pd0-f175.google.com ([209.85.192.175])
	by sog-mx-1.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128)
	(Exim 4.76) id 1Vo1i6-0004sT-3I
	for bitcoin-development@lists.sourceforge.net;
	Wed, 04 Dec 2013 01:57:07 +0000
Received: by mail-pd0-f175.google.com with SMTP id w10so21162849pde.6
	for <bitcoin-development@lists.sourceforge.net>;
	Tue, 03 Dec 2013 17:57:00 -0800 (PST)
MIME-Version: 1.0
X-Received: by 10.68.232.37 with SMTP id tl5mr42549531pbc.86.1386122220236;
	Tue, 03 Dec 2013 17:57:00 -0800 (PST)
Received: by 10.66.158.129 with HTTP; Tue, 3 Dec 2013 17:57:00 -0800 (PST)
In-Reply-To: <CA+s+GJA-rXF7spPwLDJv-hGRk-obohdJDHQ9D6bDTdh1UGZVEQ@mail.gmail.com>
References: <CAEz79PptC4VZr19iHYx5iA2K8SZ2aJbUvnt8_ZGRwbBJ6=WW3A@mail.gmail.com>
	<CA+s+GJA-rXF7spPwLDJv-hGRk-obohdJDHQ9D6bDTdh1UGZVEQ@mail.gmail.com>
Date: Tue, 3 Dec 2013 15:57:00 -1000
Message-ID: <CAEz79Pp0LXfvLo85_FVcL-gLLYYon0SLHoG40qTfFDs59f40yw@mail.gmail.com>
From: "Warren Togami Jr." <wtogami@gmail.com>
To: Bitcoin Dev <bitcoin-development@lists.sourceforge.net>
Content-Type: multipart/alternative; boundary=047d7b3395e58d77c004ecabbaa7
X-Spam-Score: -0.6 (/)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
	See http://spamassassin.org/tag/ for more details.
	-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,
	no trust [209.85.192.175 listed in list.dnswl.org]
	0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked.
	See
	http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
	for more information. [URIs: github.com]
	-1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for
	sender-domain
	0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider
	(wtogami[at]gmail.com)
	-0.0 SPF_PASS               SPF: sender matches SPF record
	1.0 HTML_MESSAGE           BODY: HTML included in message
	-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from
	author's domain
	0.1 DKIM_SIGNED            Message has a DKIM or DK signature,
	not necessarily valid
	-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
X-Headers-End: 1Vo1i6-0004sT-3I
Subject: Re: [Bitcoin-development] Coin Control, Send crash on MacOS X
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
	<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
	<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Wed, 04 Dec 2013 01:57:07 -0000

--047d7b3395e58d77c004ecabbaa7
Content-Type: text/plain; charset=UTF-8

On Sun, Dec 1, 2013 at 1:19 AM, Wladimir <laanwj@gmail.com> wrote:

> On Sun, Dec 1, 2013 at 12:05 PM, Warren Togami Jr. <wtogami@gmail.com>wrote:
>
>> https://github.com/litecoin-project/bitcoinomg/commits/0.8.5-OMG6
>> http://download1.rpmfusion.org/~warren/bitcoin-0.8.5-OMG6/
>> I've been backporting patches from master and Litecoin to make a Bitcoin
>> 0.8 client with more features.  It works quite well on Linux and Win32.
>>
>> http://pastebin.com/g8QqheGc
>> Today we discovered a rare crash that can happen on MacOS X. toffoo and
>> coblee reproduced it on MacOS X 10.9 and I reproduced it on 10.6.8. It
>> seems to be some kind of race condition involving SendCoinsEntry::clear().
>>
>>
>>    1. 11  QtGui                               0x00e28141
>>    QWidget::setFocus(Qt::FocusReason) + 289
>>    2. 12  org.bitcoinfoundation.Bitcoin-Qt    0x002ca665
>>    SendCoinsEntry::clear() + 101
>>
>>
> I don't think the setFocus should be in clear() in the first place. It
> conflates clearing the widgets and changing the focus.
>
> If the automatic focus change is desirable at all it could be moved to a
> seperate function "focusPayTo".
>
> In any case it's just a nicety and should just be removed if it causes
> problems.
>
> Wladimir
>
>
Did as you suggested, removed both setFocus() calls that happen after Send
is clicked

http://pastebin.com/j4adDpsM
Now it crashes in something else within qt.

I'm trying other things...

Warren

--047d7b3395e58d77c004ecabbaa7
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_extra"><div class=3D"gmail_quote">On S=
un, Dec 1, 2013 at 1:19 AM, Wladimir <span dir=3D"ltr">&lt;<a href=3D"mailt=
o:laanwj@gmail.com" target=3D"_blank">laanwj@gmail.com</a>&gt;</span> wrote=
:<br><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bo=
rder-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:so=
lid;padding-left:1ex">
<div dir=3D"ltr"><div class=3D"im">On Sun, Dec 1, 2013 at 12:05 PM, Warren =
Togami Jr. <span dir=3D"ltr">&lt;<a href=3D"mailto:wtogami@gmail.com" targe=
t=3D"_blank">wtogami@gmail.com</a>&gt;</span> wrote:<br></div><div class=3D=
"gmail_extra">
<div class=3D"gmail_quote"><div class=3D"im">
<blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-=
left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;p=
adding-left:1ex"><div dir=3D"ltr"><a href=3D"https://github.com/litecoin-pr=
oject/bitcoinomg/commits/0.8.5-OMG6" target=3D"_blank">https://github.com/l=
itecoin-project/bitcoinomg/commits/0.8.5-OMG6</a><div>

<a href=3D"http://download1.rpmfusion.org/~warren/bitcoin-0.8.5-OMG6/" targ=
et=3D"_blank">http://download1.rpmfusion.org/~warren/bitcoin-0.8.5-OMG6/</a=
><div>
<div>I&#39;ve been backporting patches from master and Litecoin to make a B=
itcoin 0.8 client with more features. =C2=A0It works quite well on Linux an=
d Win32.</div><div><br></div><div><a href=3D"http://pastebin.com/g8QqheGc" =
target=3D"_blank">http://pastebin.com/g8QqheGc</a><br>


</div><div>Today we discovered a rare crash that can happen on MacOS X. tof=
foo and coblee reproduced it on MacOS X 10.9 and I reproduced it on 10.6.8.=
 It seems to be some kind of race condition involving=C2=A0SendCoinsEntry::=
clear().</div>


<div><br></div><div><ol style=3D"margin:0px;padding:0px 0px 0px 48px;color:=
rgb(172,172,172);font-family:Consolas,Menlo,Monaco,&#39;Lucida Console&#39;=
,&#39;Liberation Mono&#39;,&#39;DejaVu Sans Mono&#39;,&#39;Bitstream Vera S=
ans Mono&#39;,monospace,serif;font-size:12px;line-height:21px;background-co=
lor:rgb(248,248,248)">


<li><div style=3D"padding:0px 5px;vertical-align:top;color:rgb(0,0,0);borde=
r-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204)=
;background-color:rgb(255,255,255)">11 =C2=A0QtGui =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 0x00e28141 QWidget::setFocus(Qt::FocusReason) + 289</div>


</li><li><div style=3D"padding:0px 5px;vertical-align:top;color:rgb(0,0,0);=
border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204=
,204);background-color:rgb(255,255,255)">12 =C2=A0org.bitcoinfoundation.Bit=
coin-Qt=C2=A0 =C2=A0 0x002ca665 SendCoinsEntry::clear() + 101</div>

</li></ol></div></div></div></div></blockquote><div><br></div></div><div>I =
don&#39;t think the setFocus should be in clear() in the first place. It co=
nflates clearing the widgets and changing the focus.</div><div><br></div>
<div>
If the automatic focus change is desirable at all it could be moved to a se=
perate function &quot;focusPayTo&quot;.</div><div><br></div><div>In any cas=
e it&#39;s just a nicety and should just be removed if it causes problems.<=
/div>
<span class=3D""><font color=3D"#888888">
<div><br></div><div>Wladimir</div><div><br></div></font></span></div></div>=
</div>
</blockquote></div><br></div><div class=3D"gmail_extra">Did as you suggeste=
d, removed both setFocus() calls that happen after Send is clicked</div><di=
v class=3D"gmail_extra"><br></div><div class=3D"gmail_extra"><a href=3D"htt=
p://pastebin.com/j4adDpsM">http://pastebin.com/j4adDpsM</a><div>
Now it crashes in something else within qt.</div><div><br></div><div>I&#39;=
m trying other things...</div><div><br></div><div>Warren</div><div class=3D=
"gmail_extra"><br></div></div></div>

--047d7b3395e58d77c004ecabbaa7--