summaryrefslogtreecommitdiff
path: root/5a/32abbbd3166453b9f952114226320b732f9555
blob: 3d8943818b0f9dd669b92cee01fd5e54e372b928 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
Return-Path: <sdaftuar@gmail.com>
Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org
	[172.17.192.35])
	by mail.linuxfoundation.org (Postfix) with ESMTPS id DABED1A33
	for <bitcoin-dev@lists.linuxfoundation.org>;
	Thu, 24 Sep 2015 18:56:24 +0000 (UTC)
X-Greylist: whitelisted by SQLgrey-1.7.6
Received: from mail-ob0-f170.google.com (mail-ob0-f170.google.com
	[209.85.214.170])
	by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 4E5B1E5
	for <bitcoin-dev@lists.linuxfoundation.org>;
	Thu, 24 Sep 2015 18:56:24 +0000 (UTC)
Received: by obbbh8 with SMTP id bh8so65449232obb.0
	for <bitcoin-dev@lists.linuxfoundation.org>;
	Thu, 24 Sep 2015 11:56:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	bh=bJDb1uFP2TRTV1rPYl+BXvVwrAvSu8ubJHO3FK8tf/U=;
	b=GerZ+xl2Q0yESHWoFlixGBZVt+rNjyWiaHnLXVJccQ/y/3HJTQxxveYUSETStNTXJN
	9Q3IaxWdEj2LcC14XL7x3Y7fEUcqppERz77Hzn5/h8r4HWq39YbDgt7FCRPM1TLBNnRV
	ubKuxro4DX3Wo6pCiuTCtEBfEbFzhMy4RLEisSArDQRZSM2USfzc9Vtt/uJiPbRvNXoK
	INoYBVK3LwKkGsqC1Dd/yQuG+C2vH6F6uk4EZrZOQw4JewjQmk0TmzWJQUxz0U/W7dLF
	6/Kfht4CSGIstvpj5yXt46Fu4nH5Vg4sEy1ftus+NRyDpmA8Cw5gvTFgiDmk1WWYe+WT
	cK6A==
MIME-Version: 1.0
X-Received: by 10.60.43.105 with SMTP id v9mr767500oel.6.1443120983599; Thu,
	24 Sep 2015 11:56:23 -0700 (PDT)
Received: by 10.202.197.83 with HTTP; Thu, 24 Sep 2015 11:56:23 -0700 (PDT)
In-Reply-To: <10E4880B-1B3F-40AF-88DD-65D152533DFC@petertodd.org>
References: <CAFp6fsHBbyVo21DnQKGBVJ7P=8NqOGJ-jv0-MH9WaBD6vauudA@mail.gmail.com>
	<CAE-z3OUKTKh5-SHkiawr4R58Fdg9N6_1PLjW19YsF-K9OOjQow@mail.gmail.com>
	<CAFp6fsEq0So3nUtRrn1G3Q-sEFUpK7myxfvT9-p9LNkxPGYoTw@mail.gmail.com>
	<10E4880B-1B3F-40AF-88DD-65D152533DFC@petertodd.org>
Date: Thu, 24 Sep 2015 14:56:23 -0400
Message-ID: <CAFp6fsFgkGV93PrdJPXnS880weNX=bXd17H1u5V7VBucTtW=7A@mail.gmail.com>
From: Suhas Daftuar <sdaftuar@gmail.com>
To: Peter Todd <pete@petertodd.org>
Content-Type: multipart/alternative; boundary=001a11c2f316987324052082c960
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_LOW
	autolearn=ham version=3.3.1
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
	smtp1.linux-foundation.org
Cc: Suhas Daftuar via bitcoin-dev <bitcoin-dev@lists.linuxfoundation.org>
Subject: Re: [bitcoin-dev] [BIP Proposal] New "sendheaders" p2p message
X-BeenThere: bitcoin-dev@lists.linuxfoundation.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Bitcoin Development Discussion <bitcoin-dev.lists.linuxfoundation.org>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/bitcoin-dev>,
	<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/>
List-Post: <mailto:bitcoin-dev@lists.linuxfoundation.org>
List-Help: <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev>,
	<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Sep 2015 18:56:25 -0000

--001a11c2f316987324052082c960
Content-Type: text/plain; charset=UTF-8

I considered that as well, but it seemed to me that other software on the
network (say, different wallet implementations) might prefer the option of
being able to bump up their protocol version in the future to pick up some
other change, without having to also opt-in to receiving
headers-announcements for blocks.

In particular, inv-based block announcements aren't going away (even in my
implementation of headers announcements, there are some edge cases where
the code would need to fall back to an inv announcement), so forcing all
software on the network to upgrade to supporting headers announcements,
whether now or in the future, seems too drastic -- I could imagine some
software not being very concerned about optimizing block relay in this
particular way.

On Thu, Sep 24, 2015 at 2:41 PM, Peter Todd <pete@petertodd.org> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
>
>
> On 24 September 2015 14:37:40 GMT-04:00, Suhas Daftuar via bitcoin-dev <
> bitcoin-dev@lists.linuxfoundation.org> wrote:
> >On Thu, Sep 24, 2015 at 2:17 PM, Tier Nolan via bitcoin-dev <
> >bitcoin-dev@lists.linuxfoundation.org> wrote:
> >
> >>
> >> Is there actually a requirement for the new message?  New nodes could
> >just
> >> unilaterally switch to sending headers and current nodes would be
> >> compatible.
> >>
> >
> >I don't believe that unilaterally switching to headers announcements
> >would
> >work for all network participants -- both for users running older
> >Bitcoin
> >Core versions (anything before 0.10, which I believe all ignore headers
> >messages) and for non-Bitcoin Core software that participates on the
> >network (which may ignore headers messages too, I'm not sure what all
> >is
> >out there).
>
> You can enable the behaviour based on advertised p2p network version.
> -----BEGIN PGP SIGNATURE-----
>
> iQE9BAEBCgAnIBxQZXRlciBUb2RkIDxwZXRlQHBldGVydG9kZC5vcmc+BQJWBEO5
> AAoJEMCF8hzn9Lncz4MH/3ztGWdFvMWWcwQsjIRH+eP6PH57WaEru1smmFYOmKrj
> djdiRVdxfChxRqP3adO21RUKKchjl8DNjrFJHPFz75FSM0cDcD0QAGAHilVdnICE
> LEIlTEoiIc0f1z9f/EJHSHPhiUXMnjpl/l7PYJFZV3Lt2Bl30yLsNnrp9qxjR30n
> 3nykZjyRad4JSavdTP6Evd3qaqwGXNUWsdObXNI+WPKlrw6hczlhFDKQ7RC1FPQU
> Rbgb21pavtqLUTwbBZGUisAAc94e2Gama1p3ioUFklbVtLTdw+FtxPgV/0ZS75OR
> V9pCXIbg9VM6QY4+9gYnP635+qCkqAJ4tBsYGmsT8yA=
> =cF4B
> -----END PGP SIGNATURE-----
>
>

--001a11c2f316987324052082c960
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">I considered that as well, but it seemed to me that other =
software on the network (say, different wallet implementations) might prefe=
r the option of being able to bump up their protocol version in the future =
to pick up some other change, without having to also opt-in to receiving he=
aders-announcements for blocks.<div><br></div><div>In particular, inv-based=
 block announcements aren&#39;t going away (even in my implementation of he=
aders announcements, there are some edge cases where the code would need to=
 fall back to an inv announcement), so forcing all software on the network =
to upgrade to supporting headers announcements, whether now or in the futur=
e, seems too drastic -- I could imagine some software not being very concer=
ned about optimizing block relay in this particular way.</div></div><div cl=
ass=3D"gmail_extra"><br><div class=3D"gmail_quote">On Thu, Sep 24, 2015 at =
2:41 PM, Peter Todd <span dir=3D"ltr">&lt;<a href=3D"mailto:pete@petertodd.=
org" target=3D"_blank">pete@petertodd.org</a>&gt;</span> wrote:<br><blockqu=
ote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc s=
olid;padding-left:1ex">-----BEGIN PGP SIGNED MESSAGE-----<br>
Hash: SHA512<br>
<span class=3D""><br>
<br>
<br>
On 24 September 2015 14:37:40 GMT-04:00, Suhas Daftuar via bitcoin-dev &lt;=
<a href=3D"mailto:bitcoin-dev@lists.linuxfoundation.org">bitcoin-dev@lists.=
linuxfoundation.org</a>&gt; wrote:<br>
&gt;On Thu, Sep 24, 2015 at 2:17 PM, Tier Nolan via bitcoin-dev &lt;<br>
&gt;<a href=3D"mailto:bitcoin-dev@lists.linuxfoundation.org">bitcoin-dev@li=
sts.linuxfoundation.org</a>&gt; wrote:<br>
&gt;<br>
&gt;&gt;<br>
&gt;&gt; Is there actually a requirement for the new message?=C2=A0 New nod=
es could<br>
&gt;just<br>
&gt;&gt; unilaterally switch to sending headers and current nodes would be<=
br>
&gt;&gt; compatible.<br>
&gt;&gt;<br>
&gt;<br>
&gt;I don&#39;t believe that unilaterally switching to headers announcement=
s<br>
&gt;would<br>
&gt;work for all network participants -- both for users running older<br>
&gt;Bitcoin<br>
&gt;Core versions (anything before 0.10, which I believe all ignore headers=
<br>
&gt;messages) and for non-Bitcoin Core software that participates on the<br=
>
&gt;network (which may ignore headers messages too, I&#39;m not sure what a=
ll<br>
&gt;is<br>
&gt;out there).<br>
<br>
</span>You can enable the behaviour based on advertised p2p network version=
.<br>
-----BEGIN PGP SIGNATURE-----<br>
<br>
iQE9BAEBCgAnIBxQZXRlciBUb2RkIDxwZXRlQHBldGVydG9kZC5vcmc+BQJWBEO5<br>
AAoJEMCF8hzn9Lncz4MH/3ztGWdFvMWWcwQsjIRH+eP6PH57WaEru1smmFYOmKrj<br>
djdiRVdxfChxRqP3adO21RUKKchjl8DNjrFJHPFz75FSM0cDcD0QAGAHilVdnICE<br>
LEIlTEoiIc0f1z9f/EJHSHPhiUXMnjpl/l7PYJFZV3Lt2Bl30yLsNnrp9qxjR30n<br>
3nykZjyRad4JSavdTP6Evd3qaqwGXNUWsdObXNI+WPKlrw6hczlhFDKQ7RC1FPQU<br>
Rbgb21pavtqLUTwbBZGUisAAc94e2Gama1p3ioUFklbVtLTdw+FtxPgV/0ZS75OR<br>
V9pCXIbg9VM6QY4+9gYnP635+qCkqAJ4tBsYGmsT8yA=3D<br>
=3DcF4B<br>
-----END PGP SIGNATURE-----<br>
<br>
</blockquote></div><br></div>

--001a11c2f316987324052082c960--