summaryrefslogtreecommitdiff
path: root/3b/35c8317b4dc58250f36da07b7568c863bf7d64
blob: 512ad4cf1d168e3710d8934375acf0d27649ae7e (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
Return-Path: <rusty@ozlabs.org>
Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])
 by lists.linuxfoundation.org (Postfix) with ESMTP id 70BFBC0052
 for <bitcoin-dev@lists.linuxfoundation.org>;
 Thu, 22 Oct 2020 03:10:54 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
 by fraxinus.osuosl.org (Postfix) with ESMTP id 68C9F86277
 for <bitcoin-dev@lists.linuxfoundation.org>;
 Thu, 22 Oct 2020 03:10:54 +0000 (UTC)
X-Virus-Scanned: amavisd-new at osuosl.org
Received: from fraxinus.osuosl.org ([127.0.0.1])
 by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id FCm5PF8Ch_Tg
 for <bitcoin-dev@lists.linuxfoundation.org>;
 Thu, 22 Oct 2020 03:10:53 +0000 (UTC)
X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6
Received: from ozlabs.org (ozlabs.org [203.11.71.1])
 by fraxinus.osuosl.org (Postfix) with ESMTPS id 8AFE686226
 for <bitcoin-dev@lists.linuxfoundation.org>;
 Thu, 22 Oct 2020 03:10:52 +0000 (UTC)
Received: by ozlabs.org (Postfix, from userid 1011)
 id 4CGsnM5wVPz9sSn; Thu, 22 Oct 2020 14:10:47 +1100 (AEDT)
From: Rusty Russell <rusty@rustcorp.com.au>
To: ZmnSCPxj <ZmnSCPxj@protonmail.com>,
 Bitcoin Protocol Discussion <bitcoin-dev@lists.linuxfoundation.org>
In-Reply-To: <wl99_YiLrtFFZuJNlFM19WDz5nkxlTGduefyc1_kCnTNVtkvMcY8xbASSRgoHBylhd9Kne3Uoh6UYfdkswBnel3kTbPeWlkIzY7gKb6vwvc=@protonmail.com>
References: <87imblmutl.fsf@rustcorp.com.au>
 <20201008145938.vrmm33f6sugdc7qm@ganymede> <87r1q0e06p.fsf@rustcorp.com.au>
 <sYf9B0e3UaSdMfdBfChon1Vr7BRFdH_6mgzuXIt_xbtlKtdqns9JJp90dRlNfvwBoRq57YEVrKbKX-dHDWz7TE0gobU4u8dGGJTcFFz2n60=@wuille.net>
 <877drn2g6q.fsf@rustcorp.com.au>
 <wl99_YiLrtFFZuJNlFM19WDz5nkxlTGduefyc1_kCnTNVtkvMcY8xbASSRgoHBylhd9Kne3Uoh6UYfdkswBnel3kTbPeWlkIzY7gKb6vwvc=@protonmail.com>
Date: Wed, 21 Oct 2020 15:09:32 +1030
Message-ID: <87zh4gxke3.fsf@rustcorp.com.au>
MIME-Version: 1.0
Content-Type: text/plain
Cc: John Barboza <johnbarboza@gmail.com>
Subject: Re: [bitcoin-dev] Progress on bech32 for future Segwit Versions
	(BIP-173)
X-BeenThere: bitcoin-dev@lists.linuxfoundation.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Bitcoin Protocol Discussion <bitcoin-dev.lists.linuxfoundation.org>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/bitcoin-dev>, 
 <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/>
List-Post: <mailto:bitcoin-dev@lists.linuxfoundation.org>
List-Help: <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev>, 
 <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Oct 2020 03:10:54 -0000

ZmnSCPxj <ZmnSCPxj@protonmail.com> writes:
> I believe this is actually my code, which was later refactored by John Barboza when we were standardizing the `param` system.

Ah, sorry!

> This was intended only as a simple precaution against creating non-standard transaction, and not an assumption that future versions should be invalid.
> The intent is that further `else if` branches would be added for newer witness versions and whatever length restrictions they may have, as the `/* Insert other witness versions here.  */` comment implies.

Yes, I mentioned it here because I've found this to be a common
misconception; the *idea* was that application's segwit code would not
have to be reworked for future upgrades, but that information propagated
poorly.

(Just as well, because of overly strict standardness rules, the overflow
bug, and now the proposed validation changes, turns out this lack of
forward compat is a feature!)

Thanks!
Rusty.