summaryrefslogtreecommitdiff
path: root/19/9c7ce9c08c1f840f36e115081756d712445f26
blob: 85d95b56e0ecf2bbb84bd80e398ae0a9e0962290 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
Return-Path: <dev@jonasschnelli.ch>
Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org
	[172.17.192.35])
	by mail.linuxfoundation.org (Postfix) with ESMTPS id 28DAB9CD
	for <bitcoin-dev@lists.linuxfoundation.org>;
	Fri, 13 Apr 2018 19:19:22 +0000 (UTC)
X-Greylist: delayed 00:06:21 by SQLgrey-1.7.6
Received: from bitcoin.jonasschnelli.ch (bitcoinsrv.jonasschnelli.ch
	[138.201.55.219])
	by smtp1.linuxfoundation.org (Postfix) with ESMTP id 98D21477
	for <bitcoin-dev@lists.linuxfoundation.org>;
	Fri, 13 Apr 2018 19:19:21 +0000 (UTC)
Received: by bitcoin.jonasschnelli.ch (Postfix, from userid 1002)
	id CF7F815E3CAE; Fri, 13 Apr 2018 21:12:54 +0200 (CEST)
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
	smtp1.linux-foundation.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham
	version=3.3.1
Received: from [192.168.43.149] (unknown [213.55.211.80])
	by bitcoin.jonasschnelli.ch (Postfix) with ESMTPSA id D1DD315E157B;
	Fri, 13 Apr 2018 21:12:53 +0200 (CEST)
From: Jonas Schnelli <dev@jonasschnelli.ch>
Content-Type: multipart/signed;
	boundary="Apple-Mail=_2ACFB499-5B54-408B-A600-DE81CD77AC11";
	protocol="application/pgp-signature"; micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 11.3 \(3445.6.18\))
Date: Fri, 13 Apr 2018 21:12:47 +0200
References: <paqids$e14$1@blaine.gmane.org>
To: Andreas Schildbach <andreas@schildbach.de>,
	Bitcoin Protocol Discussion <bitcoin-dev@lists.linuxfoundation.org>
In-Reply-To: <paqids$e14$1@blaine.gmane.org>
Message-Id: <4A0CD31A-8745-4425-99FC-5DF12FA3B917@jonasschnelli.ch>
X-Mailer: Apple Mail (2.3445.6.18)
X-Virus-Scanned: clamav-milter 0.99.2 at bitcoinsrv.jonasschnelli.ch
X-Virus-Status: Clean
Subject: Re: [bitcoin-dev] BloomFilter issue with segwit addresses
X-BeenThere: bitcoin-dev@lists.linuxfoundation.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Bitcoin Protocol Discussion <bitcoin-dev.lists.linuxfoundation.org>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/bitcoin-dev>,
	<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/>
List-Post: <mailto:bitcoin-dev@lists.linuxfoundation.org>
List-Help: <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev>,
	<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Apr 2018 19:19:22 -0000


--Apple-Mail=_2ACFB499-5B54-408B-A600-DE81CD77AC11
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

Hi Andreas

Thanks for bringing this up and this seems indeed to be suboptimal.

> I wonder if Bitcoin Core would be willing to extend the BIP37 matching
> rules such that data elements in the witness are also matched against?

Bitcoin Core is not an identity that can be =E2=80=9Ewilling to =
extend=E2=80=9C (or reject) a feature.
Someone needs to come up with a proposal (pull request).

Maybe an extension for BIP37 would make sense (*meh*).
Just inserting the witness data into the bloom filter seems to be an =
easy solution (CBloomFilter::IsRelevantAndUpdate())

/jonas

--Apple-Mail=_2ACFB499-5B54-408B-A600-DE81CD77AC11
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEyhopCNzi8TB0xizeHrd2uwPHki0FAlrRAS8ACgkQHrd2uwPH
ki2xuQ//eTnBYrvcVPMbPWQluNXb8jZFuBBSvnRdQ6inHPNtSY9jlllv4lP6caRz
TFkoz7VuqTIFWQ3t6qmBhJJD2RFucg5kkuQG930MUjN6PbAdiSUpcZ3W7Cp0U1pE
DESTa3rumyieMQeNH7ICXJpa4Ta3KRdpzRrrR5/JHWlXNEvRShy8Mf4/8lF7dCbt
a6wumlcLC70Yd9NWzecibYzxt9iJat/f5qsTeJNhPHIOjqgM2lWSWnmZuN39vjdn
7XoKJmNtUyxElEmTH/WwDtJObXS1nENMQ8BVuOBBzxTlTkOY86oHLIrCD+kuGd6N
agBIQ1TLIoNZni9cWdZ2l2aIfKXGpuFtz0IDR/8bWyVFP5NjajiMVqil1h8N9YPe
gHdc6ERWENtlnEz9lCWk/ZY2Bd/Mu3PTZDgjLabQB+DrMROoydFdiTwaXRJzIhXW
X63vAgLkVyyqYXc0xdWLRT6uzWiGNNy7fYmdk2iRkCa03/OIO3xbjvcibZe57Yfq
glHYNMMg0eYZB2S7cLk/Fif8BGR2TyESY+/usu6CWrNVaMpy0deEZPhJ+BrVwKEq
Bm753GLB2f+d1NHIwYiwAIP+igO676bEOxci52Py/D1VvRw0c8q4reMGrrHN5UbW
26rlm4tC3zwFrR2/PGmHlLXiymUGrfvlpU6ebctF9Bawes5f86g=
=3I+I
-----END PGP SIGNATURE-----

--Apple-Mail=_2ACFB499-5B54-408B-A600-DE81CD77AC11--