1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
|
Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194]
helo=mx.sourceforge.net)
by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
(envelope-from <bitcoin-list@bluematt.me>) id 1Qfut7-0006qg-CK
for bitcoin-development@lists.sourceforge.net;
Sun, 10 Jul 2011 14:21:37 +0000
Received-SPF: pass (sog-mx-4.v43.ch3.sourceforge.com: domain of bluematt.me
designates 208.79.240.5 as permitted sender)
client-ip=208.79.240.5; envelope-from=bitcoin-list@bluematt.me;
helo=smtpauth.rollernet.us;
Received: from smtpauth.rollernet.us ([208.79.240.5])
by sog-mx-4.v43.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256)
(Exim 4.76) id 1Qfut4-0003Gu-31
for bitcoin-development@lists.sourceforge.net;
Sun, 10 Jul 2011 14:21:37 +0000
Received: from smtpauth.rollernet.us (localhost [127.0.0.1])
by smtpauth.rollernet.us (Postfix) with ESMTP id 42257594004
for <bitcoin-development@lists.sourceforge.net>;
Sun, 10 Jul 2011 07:21:12 -0700 (PDT)
Received: from mail.bluematt.me (unknown
[IPv6:2001:470:9ff2:2:20c:29ff:fe16:f239])
(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
(No client certificate requested)
(Authenticated sender: @bluematt.me)
by smtpauth.rollernet.us (Postfix) with ESMTPSA
for <bitcoin-development@lists.sourceforge.net>;
Sun, 10 Jul 2011 07:21:10 -0700 (PDT)
Received: from [IPv6:2001:470:9ff2:1:2c0:caff:fe33:858b] (unknown
[IPv6:2001:470:9ff2:1:2c0:caff:fe33:858b])
by mail.bluematt.me (Postfix) with ESMTPSA id 1B48DB3BC
for <bitcoin-development@lists.sourceforge.net>;
Sun, 10 Jul 2011 16:21:19 +0200 (CEST)
From: Matt Corallo <bitcoin-list@bluematt.me>
To: bitcoin-development <bitcoin-development@lists.sourceforge.net>
In-Reply-To: <CA+8xBpd06DJ_0+OHRDsbzkecfG1+-ubXb2eiVRiSn6GT53ZDSQ@mail.gmail.com>
References: <1309801974.3423.80.camel@Desktop666>
<CABsx9T31ZuQHKwcNnb9-NpaCA6c43PXVZ+Tc+GZ=2Wkz08enHw@mail.gmail.com>
<1309811972.29355.19.camel@Desktop666>
<1309828239.29355.28.camel@Desktop666>
<CABsx9T2-htzpQPxrNqq1Efow2tuUdm5AQGOh0MS0MXvH5pD_5g@mail.gmail.com>
<CA+8xBpd06DJ_0+OHRDsbzkecfG1+-ubXb2eiVRiSn6GT53ZDSQ@mail.gmail.com>
Content-Type: multipart/signed; micalg="pgp-sha1";
protocol="application/pgp-signature";
boundary="=-yP30NamqL+a65rXCGxKR"
Date: Sun, 10 Jul 2011 16:21:17 +0200
Message-ID: <1310307677.2230.5.camel@Desktop666>
Mime-Version: 1.0
X-Mailer: Evolution 2.32.2
X-Rollernet-Abuse: Processed by Roller Network Mail Services. Contact
abuse@rollernet.us to report violations. Abuse policy:
http://rollernet.us/abuse.php
X-Rollernet-Submit: Submit ID 138e.4e19b556.4b1d0.0
X-Spam-Score: -1.5 (-)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
See http://spamassassin.org/tag/ for more details.
-1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for
sender-domain
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
-0.0 SPF_PASS SPF: sender matches SPF record
X-Headers-End: 1Qfut4-0003Gu-31
Subject: Re: [Bitcoin-development] Encrypted Wallet Backward Compatibility
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Sun, 10 Jul 2011 14:21:37 -0000
--=-yP30NamqL+a65rXCGxKR
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
At Luke's suggestion, I did a bit more digging and was able to find a
data structure in wallet settings that should cause all versions (well
all versions since Bitcoin was in github, and probably before then) to
crash on load instead of making a new wallet or opening in some bizarre
half-state. I just put an empty object in addrIncoming (nfc what it was
used for, but it will get the desire effect and it isnt used anywhere in
the code aside from its definition).
You can see the commit at
https://github.com/TheBlueMatt/bitcoin/commit/2e8383469d7e12a495b3a1dbd41a8=
d211ff34fe8
Does anyone disagree and think a different solution would work better?
This resolves all known issues and suggestions that I know of on newenc
except for the invalid mlock calculations, which I will go fix right
now. So...aside from that bug does anyone have any remaining
suggestions/blockers on newenc and, if not, can we get final ACKs on it?
Matt
--=-yP30NamqL+a65rXCGxKR
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iQIcBAABAgAGBQJOGbVTAAoJEBrh01BD4I5UPfEP/jVKIDoruTYt/mbDu9bCtHmY
syyiq+BRWO67OrhD0WkxMv3uyI7uD9voCD7Hp4M2IFr7P2uxhTwEZjcEnrKeuBGR
P1fvw8eQFQGO/ToVe0pPMGiwcUhqrbUNON4li/HBPTNgVj68wC+7nGEvatGb474b
Q6YCo72bn/j88qpPYEhDmND0dTO8X0CENeeZ2alFzjrkph7pnIqeRdi26US2dpY2
Fz8CswJGSN5CJPt9M23H8TaiSiSxNEknXDGbmmmKgnh1MaBWkZzL/jh2Trq3gyRv
6p69IsC0M307vu9cjgte9bFWJMPfBqsoJNCorkF7Awytv6MqacYYXRO9hiNFDSOR
W487DX6ozZg7jgGry+FFl0TwI87wXxzVF5KHBHc5X7Tcm+tf6XYHvnMQZXR3eX55
t5vHeGOinzf9uEXeXdJXn22YaICil/xMF+t/tJ0xulsBaWeDSU6dG9xDMXigieIK
U1SlD6/3+Xx6QxxWYrm5dH4tINJtMyfop5eFyXvmQyF4ry2HAm2KT7Z0GRQ5JolX
38uF+LPYzM9NBEojRUTj04hCTkBLVSoSmOuiG+abbPZUuZqBxuhBWLtvs0foMLPh
xW9AaU4jdu/pjKfCjtGEFjkwPVjOkOu+PlPWWHAL4ZkOf2y6RXDQ+Pu1hXb01SbG
PnOJAEI50NAaVOePEN5g
=vbSR
-----END PGP SIGNATURE-----
--=-yP30NamqL+a65rXCGxKR--
|
