summaryrefslogtreecommitdiff
path: root/28
diff options
context:
space:
mode:
authorWladimir <laanwj@gmail.com>2012-02-06 18:27:20 +0100
committerbitcoindev <bitcoindev@gnusha.org>2012-02-06 17:27:30 +0000
commitb2f98dd33402b986b9c4dbd61131b5f2b507749c (patch)
tree3ae7366f71029d791f110ee534261e6d56d80713 /28
parent6ab7f08c3da9fd64f6b9bf4b6a9d6fb38a2107d9 (diff)
downloadpi-bitcoindev-b2f98dd33402b986b9c4dbd61131b5f2b507749c.tar.gz
pi-bitcoindev-b2f98dd33402b986b9c4dbd61131b5f2b507749c.zip
Re: [Bitcoin-development] Multisignature transaction support in the GUI
Diffstat (limited to '28')
-rw-r--r--28/4263208f0a74f54f53061fe1ddd0de07487a01128
1 files changed, 128 insertions, 0 deletions
diff --git a/28/4263208f0a74f54f53061fe1ddd0de07487a01 b/28/4263208f0a74f54f53061fe1ddd0de07487a01
new file mode 100644
index 000000000..9eb188502
--- /dev/null
+++ b/28/4263208f0a74f54f53061fe1ddd0de07487a01
@@ -0,0 +1,128 @@
+Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193]
+ helo=mx.sourceforge.net)
+ by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
+ (envelope-from <laanwj@gmail.com>) id 1RuSLi-00013a-CJ
+ for bitcoin-development@lists.sourceforge.net;
+ Mon, 06 Feb 2012 17:27:30 +0000
+Received-SPF: pass (sog-mx-3.v43.ch3.sourceforge.com: domain of gmail.com
+ designates 209.85.210.47 as permitted sender)
+ client-ip=209.85.210.47; envelope-from=laanwj@gmail.com;
+ helo=mail-pz0-f47.google.com;
+Received: from mail-pz0-f47.google.com ([209.85.210.47])
+ by sog-mx-3.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128)
+ (Exim 4.76) id 1RuSLe-0007JT-IA
+ for bitcoin-development@lists.sourceforge.net;
+ Mon, 06 Feb 2012 17:27:30 +0000
+Received: by daln34 with SMTP id n34so2712761dal.34
+ for <bitcoin-development@lists.sourceforge.net>;
+ Mon, 06 Feb 2012 09:27:20 -0800 (PST)
+MIME-Version: 1.0
+Received: by 10.68.132.66 with SMTP id os2mr49041240pbb.50.1328549240712; Mon,
+ 06 Feb 2012 09:27:20 -0800 (PST)
+Received: by 10.142.43.2 with HTTP; Mon, 6 Feb 2012 09:27:20 -0800 (PST)
+In-Reply-To: <CABsx9T09h4EQ=3BFyu-7k9D_t1ryWoC5go4yu4xwsaob9ciK6Q@mail.gmail.com>
+References: <CABsx9T09h4EQ=3BFyu-7k9D_t1ryWoC5go4yu4xwsaob9ciK6Q@mail.gmail.com>
+Date: Mon, 6 Feb 2012 18:27:20 +0100
+Message-ID: <CA+s+GJC7N3k8n335mHa7hU-Lq4uO6mu1QBLX30G+68cBtDSg3w@mail.gmail.com>
+From: Wladimir <laanwj@gmail.com>
+To: Gavin Andresen <gavinandresen@gmail.com>
+Content-Type: multipart/alternative; boundary=047d7b10d1cd8f2f1d04b84ef971
+X-Spam-Score: -0.6 (/)
+X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
+ See http://spamassassin.org/tag/ for more details.
+ -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for
+ sender-domain
+ 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider
+ (laanwj[at]gmail.com)
+ -0.0 SPF_PASS SPF: sender matches SPF record
+ 1.0 HTML_MESSAGE BODY: HTML included in message
+ -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from
+ author's domain
+ 0.1 DKIM_SIGNED Message has a DKIM or DK signature,
+ not necessarily valid
+ -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
+X-Headers-End: 1RuSLe-0007JT-IA
+Cc: Bitcoin Dev <bitcoin-development@lists.sourceforge.net>
+Subject: Re: [Bitcoin-development] Multisignature transaction support in the
+ GUI
+X-BeenThere: bitcoin-development@lists.sourceforge.net
+X-Mailman-Version: 2.1.9
+Precedence: list
+List-Id: <bitcoin-development.lists.sourceforge.net>
+List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
+ <mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
+List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
+List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
+List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
+List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
+ <mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
+X-List-Received-Date: Mon, 06 Feb 2012 17:27:30 -0000
+
+--047d7b10d1cd8f2f1d04b84ef971
+Content-Type: text/plain; charset=UTF-8
+
+On Mon, Feb 6, 2012 at 5:07 PM, Gavin Andresen <gavinandresen@gmail.com>wrote:
+
+>
+> Advantage of (2) is it should mean more testing of multisig, and fewer
+> bug reports of "I added a multisig address via RPC but I can't send to
+> it using the GUI"
+>
+> My opinion: I think it is worth allowing send-to-multisig-address via
+> the GUI (should be a very simple change to the address validation
+> logic). But creating multisig addresses via the GUI should wait until
+> the next release.
+>
+
+I think we should go with (2), changing the maximum address length and
+validation is very easy. We'd need to
+
+ - Change BitcoinAddressValidator::MaxAddressLength to 35
+ - The addresses are validated with walletmodel->validateAddress which in
+ turn calls CBitcoinAddress addressParsed(addr) and then isValid(). Does
+ this work for the new addresses?
+
+The set of allowed characters is still the same, so BitcoinAddressValidator
+doesn't have to be changed.
+
+Advanced dialogs for constructing the addresses / adding them to the
+address book could wait for 0.7.0.
+
+Wladimir
+
+--047d7b10d1cd8f2f1d04b84ef971
+Content-Type: text/html; charset=UTF-8
+Content-Transfer-Encoding: quoted-printable
+
+<div class=3D"gmail_quote">On Mon, Feb 6, 2012 at 5:07 PM, Gavin Andresen <=
+span dir=3D"ltr">&lt;<a href=3D"mailto:gavinandresen@gmail.com">gavinandres=
+en@gmail.com</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" sty=
+le=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+<br>
+Advantage of (2) is it should mean more testing of multisig, and fewer<br>
+bug reports of &quot;I added a multisig address via RPC but I can&#39;t sen=
+d to<br>
+it using the GUI&quot;<br>
+<br>
+My opinion: I think it is worth allowing send-to-multisig-address via<br>
+the GUI (should be a very simple change to the address validation<br>
+logic). =C2=A0But creating multisig addresses via the GUI should wait until=
+<br>
+the next release.<br></blockquote><div><br></div>I think we should go with =
+(2),=C2=A0changing the maximum address length and validation is very easy. =
+We&#39;d need to</div><div class=3D"gmail_quote"><ul><li>Change BitcoinAddr=
+essValidator::MaxAddressLength to 35</li>
+<li>The addresses are validated with walletmodel-&gt;validateAddress which =
+in turn calls=C2=A0CBitcoinAddress addressParsed(addr) and then isValid(). =
+Does this work for the new addresses?</li></ul></div><div class=3D"gmail_qu=
+ote">
+The set of allowed characters is still the same, so BitcoinAddressValidator=
+ doesn&#39;t have to be changed.</div><div class=3D"gmail_quote"><br></div>=
+<div class=3D"gmail_quote">Advanced dialogs for constructing the addresses =
+/ adding them to the address book could wait for 0.7.0.</div>
+<div class=3D"gmail_quote"><br></div><div class=3D"gmail_quote">Wladimir</d=
+iv><div class=3D"gmail_quote"><br></div>
+
+--047d7b10d1cd8f2f1d04b84ef971--
+
+