1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
|
Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192]
helo=mx.sourceforge.net)
by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
(envelope-from <jan@uos.de>) id 1YPz7l-0005Ij-D2
for bitcoin-development@lists.sourceforge.net;
Mon, 23 Feb 2015 19:57:01 +0000
X-ACL-Warn:
Received: from vm135.rz.uni-osnabrueck.de ([131.173.16.10]
helo=smtp-auth.serv.Uni-Osnabrueck.DE)
by sog-mx-2.v43.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256)
(Exim 4.76) id 1YPz7j-0007be-Gr
for bitcoin-development@lists.sourceforge.net;
Mon, 23 Feb 2015 19:57:01 +0000
Received: from msmtp-using-host (ip4d17d118.dynamic.kabel-deutschland.de
[77.23.209.24]) (authenticated bits=0)
by smtp-auth.serv.Uni-Osnabrueck.DE (8.13.8/8.13.8) with ESMTP id
t1NJuoW3005188
(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);
Mon, 23 Feb 2015 20:56:51 +0100
Date: Mon, 23 Feb 2015 20:56:50 +0100
From: Jan Vornberger <jan@uos.de>
To: Mike Hearn <mike@plan99.net>
Message-ID: <20150223195650.GA13924@odo.localdomain>
References: <20150222190839.GA18527@odo.localdomain>
<54EA5A1C.2020701@AndySchroder.com>
<20150223150937.GA7987@odo.localdomain>
<CANEZrP0qHMFpDUbmkqxHhXVee32+wAcYWV4O6=u5qCtRsAem0A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CANEZrP0qHMFpDUbmkqxHhXVee32+wAcYWV4O6=u5qCtRsAem0A@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409,
Antispam-Data: 2015.2.23.194519 (Univ. Osnabrueck)
X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=
HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0,
BODY_SIZE_1000_LESS 0, BODY_SIZE_2000_LESS 0,
BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0,
BODY_SIZE_700_799 0, REFERENCES 0, __ANY_URI 0,
__BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CD 0,
__CT 0, __CT_TEXT_PLAIN 0, __FORWARDED_MSG 0, __HAS_FROM 0,
__HAS_MSGID 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0,
__MIME_VERSION 0, __REFERENCES 0, __SANE_MSGID 0,
__SUBJ_ALPHA_END 0, __SUBJ_ALPHA_NEGATE 0, __TO_MALFORMED_2 0,
__URI_NO_MAILTO 0, __URI_NO_PATH 0, __URI_NO_WWW 0, __USER_AGENT 0
X-PMX-Spam-Level: IIIIIIII
X-Spam-Score: 0.0 (/)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
See http://spamassassin.org/tag/ for more details.
X-Headers-End: 1YPz7j-0007be-Gr
Cc: Bitcoin Dev <bitcoin-development@lists.sourceforge.net>
Subject: Re: [Bitcoin-development] Bitcoin at POS using BIP70,
NFC and offline payments - implementer feedback
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Mon, 23 Feb 2015 19:57:01 -0000
On Mon, Feb 23, 2015 at 05:59:34PM +0100, Mike Hearn wrote:
> >
> > At the moment I'm also modifying BitPay's memo field to contain 'ack', as
> > Andreas' wallet otherwise reports a failure if I transmit the original via
> > Bluetooth. :-)
> >
>
> Huh?
For HTTP it checks whether 'nack' is _not_ presented:
https://github.com/schildbach/bitcoin-wallet/blob/master/wallet/src/de/schildbach/wallet/offline/DirectPaymentTask.java#L133
But via Bluetooth it checks for 'ack' directly:
https://github.com/schildbach/bitcoin-wallet/blob/master/wallet/src/de/schildbach/wallet/offline/DirectPaymentTask.java#L238
The latter should probably be at least changed to the reverse check as
for HTTP, but in general some non-memo way of doing that would be nice
of course.
Jan
|
