1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
|
Return-Path: <dave@dtrt.org>
Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org
[172.17.192.35])
by mail.linuxfoundation.org (Postfix) with ESMTPS id 6DFDEC6C
for <bitcoin-dev@lists.linuxfoundation.org>;
Fri, 18 Oct 2019 22:46:33 +0000 (UTC)
X-Greylist: from auto-whitelisted by SQLgrey-1.7.6
Received: from newmail.dtrt.org (li1228-87.members.linode.com [45.79.129.87])
by smtp1.linuxfoundation.org (Postfix) with ESMTPS id DDD1670D
for <bitcoin-dev@lists.linuxfoundation.org>;
Fri, 18 Oct 2019 22:46:32 +0000 (UTC)
Received: from harding by newmail.dtrt.org with local (Exim 4.92)
(envelope-from <dave@dtrt.org>)
id 1iLb0x-0002QR-Pi; Fri, 18 Oct 2019 18:46:31 -0400
Date: Fri, 18 Oct 2019 12:45:35 -1000
From: "David A. Harding" <dave@dtrt.org>
To: Eric Voskuil <eric@voskuil.org>,
Bitcoin Protocol Discussion <bitcoin-dev@lists.linuxfoundation.org>
Message-ID: <20191018224535.wy6f55grpfk2sncq@ganymede>
References: <qoag0d$65ad$1@blaine.gmane.org>
<5C03EE5A-B29E-44BC-903F-7094E504580D@voskuil.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5C03EE5A-B29E-44BC-903F-7094E504580D@voskuil.org>
User-Agent: NeoMutt/20180716
X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,KHOP_HELO_FCRDNS
autolearn=no version=3.3.1
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
smtp1.linux-foundation.org
Subject: Re: [bitcoin-dev] Removal of reject network messages from Bitcoin
Core (BIP61)
X-BeenThere: bitcoin-dev@lists.linuxfoundation.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Bitcoin Protocol Discussion <bitcoin-dev.lists.linuxfoundation.org>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/bitcoin-dev>,
<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/>
List-Post: <mailto:bitcoin-dev@lists.linuxfoundation.org>
List-Help: <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev>,
<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Oct 2019 22:46:33 -0000
On Thu, Oct 17, 2019 at 01:16:47PM -0700, Eric Voskuil via bitcoin-dev wrote:
> As this is a P2P protocol change it should be exposed as a version
> increment (and a BIP) [...]
>
> BIP61 is explicit:
>
> “All implementations of the P2P protocol version 70,002 and later
> should support the reject message.“
I don't think a new BIP or a version number increment is necessary.
1. "Should support" isn't the same as "must support". See
https://tools.ietf.org/html/rfc2119 ; by that reading,
implementations with protocol versions above 70,002 are not required
to support the reject message.
2. If you don't implement a BIP, as Bitcoin Core explicitly doesn't any
more for BIP61[1], you're not bound by its conditions.
-Dave
[1] https://github.com/bitcoin/bitcoin/blob/master/doc/bips.md "BIP61
[...] Support was removed in v0.20.0"
|
