1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
|
Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192]
helo=mx.sourceforge.net)
by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
(envelope-from <mh.in.england@gmail.com>) id 1W7XC6-0002GQ-3a
for bitcoin-development@lists.sourceforge.net;
Sun, 26 Jan 2014 21:24:42 +0000
Received-SPF: pass (sog-mx-2.v43.ch3.sourceforge.com: domain of gmail.com
designates 209.85.219.41 as permitted sender)
client-ip=209.85.219.41; envelope-from=mh.in.england@gmail.com;
helo=mail-oa0-f41.google.com;
Received: from mail-oa0-f41.google.com ([209.85.219.41])
by sog-mx-2.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128)
(Exim 4.76) id 1W7XC4-0007XS-QZ
for bitcoin-development@lists.sourceforge.net;
Sun, 26 Jan 2014 21:24:42 +0000
Received: by mail-oa0-f41.google.com with SMTP id j17so5989323oag.0
for <bitcoin-development@lists.sourceforge.net>;
Sun, 26 Jan 2014 13:24:35 -0800 (PST)
MIME-Version: 1.0
X-Received: by 10.182.233.228 with SMTP id tz4mr241545obc.56.1390771475417;
Sun, 26 Jan 2014 13:24:35 -0800 (PST)
Sender: mh.in.england@gmail.com
Received: by 10.76.99.112 with HTTP; Sun, 26 Jan 2014 13:24:35 -0800 (PST)
In-Reply-To: <lc3tm6$9ko$1@ger.gmane.org>
References: <lc3tm6$9ko$1@ger.gmane.org>
Date: Sun, 26 Jan 2014 22:24:35 +0100
X-Google-Sender-Auth: 9ebIKPS5Gl-4WzRdo_mwoRCFnWI
Message-ID: <CANEZrP2F-1aqzBfUB82riWOwTABf1arbx70FdQ-XndQ91m_QqA@mail.gmail.com>
From: Mike Hearn <mike@plan99.net>
To: Andreas Schildbach <andreas@schildbach.de>
Content-Type: multipart/alternative; boundary=001a11c30600c1925904f0e6374b
X-Spam-Score: -0.5 (/)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
See http://spamassassin.org/tag/ for more details.
-1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for
sender-domain
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider
(mh.in.england[at]gmail.com)
-0.0 SPF_PASS SPF: sender matches SPF record
1.0 HTML_MESSAGE BODY: HTML included in message
0.1 DKIM_SIGNED Message has a DKIM or DK signature,
not necessarily valid
-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
X-Headers-End: 1W7XC4-0007XS-QZ
Cc: Bitcoin Dev <bitcoin-development@lists.sourceforge.net>
Subject: Re: [Bitcoin-development] BIP70/71 issue, RFD
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Sun, 26 Jan 2014 21:24:42 -0000
--001a11c30600c1925904f0e6374b
Content-Type: text/plain; charset=UTF-8
Which medium is this an issue for? As you note, for files and HTTP
responses it's not a problem in practice. i'd guess nor for NFC tags nor QR
codes.
On Sun, Jan 26, 2014 at 10:11 PM, Andreas Schildbach
<andreas@schildbach.de>wrote:
> I'm experimenting with BIP70/71 (payment protocol) usage in face to face
> payments (more on that soon).
>
> I've excountered an issue with the protobuf format. Protobufs are not
> self-delimiting. That means if you're reading from an undelimited
> stream, you will read endlessly because you don't know how much to read.
>
> The current BIP70 implementations probably work because they're reading
> either from a file or from an HTTP resource which sets the
> Content-Length header. Trouble is the Content-Length header is optional,
> and also there are many kinds of streams that don't have this built-in
> delimiting mechanism.
>
> The Java protobuf API solves this by offering delimited I/O, like
>
> payment.writeDelimitedTo(os);
>
> This writes the size of the message as a varint before writing the data.
> I don't know about protobuf implementations for other languages but I'd
> expect them to offer something compatible.
>
> However, this leading varint is an incompatible change and would need to
> be added to the spec.
>
> I specifically encountered this with PaymentMessage and PaymentACK, but
> it might be a good idea to apply this to all messages if any. Open for
> discussion.
>
>
>
> ------------------------------------------------------------------------------
> CenturyLink Cloud: The Leader in Enterprise Cloud Services.
> Learn Why More Businesses Are Choosing CenturyLink Cloud For
> Critical Workloads, Development Environments & Everything In Between.
> Get a Quote or Start a Free Trial Today.
>
> http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
> _______________________________________________
> Bitcoin-development mailing list
> Bitcoin-development@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/bitcoin-development
>
--001a11c30600c1925904f0e6374b
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr">Which medium is this an issue for? As you note, for files =
and HTTP responses it's not a problem in practice. i'd guess nor fo=
r NFC tags nor QR codes.</div><div class=3D"gmail_extra"><br><br><div class=
=3D"gmail_quote">
On Sun, Jan 26, 2014 at 10:11 PM, Andreas Schildbach <span dir=3D"ltr"><=
<a href=3D"mailto:andreas@schildbach.de" target=3D"_blank">andreas@schildba=
ch.de</a>></span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"m=
argin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I'm experimenting with BIP70/71 (payment protocol) usage in face to fac=
e<br>
payments (more on that soon).<br>
<br>
I've excountered an issue with the protobuf format. Protobufs are not<b=
r>
self-delimiting. That means if you're reading from an undelimited<br>
stream, you will read endlessly because you don't know how much to read=
.<br>
<br>
The current BIP70 implementations probably work because they're reading=
<br>
either from a file or from an HTTP resource which sets the<br>
Content-Length header. Trouble is the Content-Length header is optional,<br=
>
and also there are many kinds of streams that don't have this built-in<=
br>
delimiting mechanism.<br>
<br>
The Java protobuf API solves this by offering delimited I/O, like<br>
<br>
payment.writeDelimitedTo(os);<br>
<br>
This writes the size of the message as a varint before writing the data.<br=
>
I don't know about protobuf implementations for other languages but I&#=
39;d<br>
expect them to offer something compatible.<br>
<br>
However, this leading varint is an incompatible change and would need to<br=
>
be added to the spec.<br>
<br>
I specifically encountered this with PaymentMessage and PaymentACK, but<br>
it might be a good idea to apply this to all messages if any. Open for<br>
discussion.<br>
<br>
<br>
---------------------------------------------------------------------------=
---<br>
CenturyLink Cloud: The Leader in Enterprise Cloud Services.<br>
Learn Why More Businesses Are Choosing CenturyLink Cloud For<br>
Critical Workloads, Development Environments & Everything In Between.<b=
r>
Get a Quote or Start a Free Trial Today.<br>
<a href=3D"http://pubads.g.doubleclick.net/gampad/clk?id=3D119420431&iu=
=3D/4140/ostg.clktrk" target=3D"_blank">http://pubads.g.doubleclick.net/gam=
pad/clk?id=3D119420431&iu=3D/4140/ostg.clktrk</a><br>
_______________________________________________<br>
Bitcoin-development mailing list<br>
<a href=3D"mailto:Bitcoin-development@lists.sourceforge.net">Bitcoin-develo=
pment@lists.sourceforge.net</a><br>
<a href=3D"https://lists.sourceforge.net/lists/listinfo/bitcoin-development=
" target=3D"_blank">https://lists.sourceforge.net/lists/listinfo/bitcoin-de=
velopment</a><br>
</blockquote></div><br></div>
--001a11c30600c1925904f0e6374b--
|
