1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
|
Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193]
helo=mx.sourceforge.net)
by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
(envelope-from <witchspace81@gmail.com>) id 1Qlios-0006Qp-BW
for bitcoin-development@lists.sourceforge.net;
Tue, 26 Jul 2011 14:41:14 +0000
Received-SPF: pass (sog-mx-3.v43.ch3.sourceforge.com: domain of gmail.com
designates 74.125.83.47 as permitted sender)
client-ip=74.125.83.47; envelope-from=witchspace81@gmail.com;
helo=mail-gw0-f47.google.com;
Received: from mail-gw0-f47.google.com ([74.125.83.47])
by sog-mx-3.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128)
(Exim 4.76) id 1Qlior-0001TU-Eg
for bitcoin-development@lists.sourceforge.net;
Tue, 26 Jul 2011 14:41:14 +0000
Received: by gwb11 with SMTP id 11so352541gwb.34
for <bitcoin-development@lists.sourceforge.net>;
Tue, 26 Jul 2011 07:41:08 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.150.251.41 with SMTP id y41mr1836424ybh.36.1311691267938; Tue,
26 Jul 2011 07:41:07 -0700 (PDT)
Received: by 10.150.147.15 with HTTP; Tue, 26 Jul 2011 07:41:07 -0700 (PDT)
Date: Tue, 26 Jul 2011 14:41:07 +0000
Message-ID: <CAJNQ0steQtptz1SP+u7nK5GqmEF1GJTYGuys0n0V5sAhh9zobg@mail.gmail.com>
From: John Smith <witchspace81@gmail.com>
To: Bitcoin Dev <bitcoin-development@lists.sourceforge.net>
Content-Type: multipart/alternative; boundary=000e0cd6d0201499ea04a8f9ecc1
X-Spam-Score: -0.5 (/)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
See http://spamassassin.org/tag/ for more details.
-1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for
sender-domain
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider
(witchspace81[at]gmail.com)
-0.0 SPF_PASS SPF: sender matches SPF record
0.1 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in
digit (witchspace81[at]gmail.com)
1.0 HTML_MESSAGE BODY: HTML included in message
-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from
author's domain
0.1 DKIM_SIGNED Message has a DKIM or DK signature,
not necessarily valid
-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
X-Headers-End: 1Qlior-0001TU-Eg
Subject: [Bitcoin-development] "To:" addresses missing
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Tue, 26 Jul 2011 14:41:14 -0000
--000e0cd6d0201499ea04a8f9ecc1
Content-Type: text/plain; charset=ISO-8859-1
I first thought it was a problem in my UI, after syncing to the latest git
version. But the following screenshot says enough:
http://img24.imageshack.us/img24/7363/screencpf.png
The address are also missing in the detailed transaction view. It appears
that the problem is in script.cpp:
BOOST_FOREACH(PAIRTYPE(opcodetype, valtype)& item, vSolution)
{
uint160 hash160;
if (item.first == OP_PUBKEY)
addressRet.SetPubKey(item.second);
else if (item.first == OP_PUBKEYHASH)
addressRet.SetHash160((uint160)item.second);
if (keystore == NULL || keystore->HaveKey(addressRet))
return true;
}
It will only return "true" on keys that are in the keystore (your own
private keys...). After commenting out the "if (keystore == NULL ..." line,
the display is fixed.
But that simple solution might have impact somewhere else.
JS
--000e0cd6d0201499ea04a8f9ecc1
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
<br>I first thought it was a problem in my UI, after syncing to the latest =
git version. But the following screenshot says enough:<br><br><a href=3D"ht=
tp://img24.imageshack.us/img24/7363/screencpf.png">http://img24.imageshack.=
us/img24/7363/screencpf.png</a><br>
<br>The address are also missing in the detailed transaction view. It appea=
rs that the problem is in script.cpp:<br><br>=A0=A0=A0=A0=A0=A0=A0 BOOST_FO=
REACH(PAIRTYPE(opcodetype, valtype)& item, vSolution)<br>=A0=A0=A0=A0=
=A0=A0=A0 {<br>=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 uint160 hash160;<br>
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 if (item.first =3D=3D OP_PUBKEY)<br>=A0=
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 addressRet.SetPubKey(item.second=
);<br>=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 else if (item.first =3D=3D OP_PUBKE=
YHASH)<br>=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 addressRet.SetHash1=
60((uint160)item.second);<br>=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 if (keystore=
=3D=3D NULL || keystore->HaveKey(addressRet))<br>
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 return true;<br>=A0=A0=A0=A0=
=A0=A0=A0 }<br><br>It will only return "true" on keys that are in=
the keystore (your own private keys...). After commenting out the "if=
(keystore =3D=3D NULL ..." line, the display is fixed. <br>
<br>But that simple solution might have impact somewhere else.<br><br>JS<br=
>
--000e0cd6d0201499ea04a8f9ecc1--
|
