1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
|
Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193]
helo=mx.sourceforge.net)
by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
(envelope-from <jgarzik@exmulti.com>) id 1QrLHC-0005Cn-JV
for bitcoin-development@lists.sourceforge.net;
Thu, 11 Aug 2011 02:45:42 +0000
X-ACL-Warn:
Received: from mail-iy0-f171.google.com ([209.85.210.171])
by sog-mx-3.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128)
(Exim 4.76) id 1QrLHB-0007Xy-Ly
for bitcoin-development@lists.sourceforge.net;
Thu, 11 Aug 2011 02:45:42 +0000
Received: by iyf13 with SMTP id 13so396785iyf.30
for <bitcoin-development@lists.sourceforge.net>;
Wed, 10 Aug 2011 19:45:36 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.42.244.3 with SMTP id lo3mr8300494icb.335.1313030736199; Wed,
10 Aug 2011 19:45:36 -0700 (PDT)
Received: by 10.42.226.4 with HTTP; Wed, 10 Aug 2011 19:45:36 -0700 (PDT)
X-Originating-IP: [99.173.148.118]
In-Reply-To: <4e3f530c.6374340a.2490.7a81@mx.google.com>
References: <4e3f530c.6374340a.2490.7a81@mx.google.com>
Date: Wed, 10 Aug 2011 22:45:36 -0400
Message-ID: <CA+8xBpcwu0+KsT5sCYiOGS+_201rNTOc=Y6VToDW4wDwrVjcYA@mail.gmail.com>
From: Jeff Garzik <jgarzik@exmulti.com>
To: Venkatesh Srinivas <me@endeavour.zapto.org>
Content-Type: text/plain; charset=ISO-8859-1
X-Spam-Score: 0.0 (/)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
See http://spamassassin.org/tag/ for more details.
X-Headers-End: 1QrLHB-0007Xy-Ly
Cc: bitcoin-development@lists.sourceforge.net
Subject: Re: [Bitcoin-development] DragonFly BSD bitcoind patches
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Thu, 11 Aug 2011 02:45:42 -0000
On Sun, Aug 7, 2011 at 11:07 PM, Venkatesh Srinivas
<me@endeavour.zapto.org> wrote:
> Hi,
>
> Related to https://bitcointalk.org/index.php?topic=28022.0 ;
>
> Here are three patches that allow bitcoind to build and run on DragonFly
> BSD.
>
> 0001) bitcoind assumes a definition of BSD implies SO_NOSIGPIPE is
> available.
> This is not true on NetBSD, OpenBSD, and DragonFly.
applied
> 0002) main.cpp has: "char pchMessageStart[4] = { 0xf9, 0xbe, 0xb4, 0xd9 };"
> Per discussion on the thread linked, leaving the signedness of
> pchMessageStart
> is unsafe for values > 0x80. This patch specifies 'unsigned char' in
> main.cpp
> and net.h.
>
> 0003) db.cpp has a number of uses of make_tuple and has 'using namespace
> std'
> and 'using namespace boost'. Without qualifying make_tuple, std::make_tuple
> is
> preferred, which is incorrect. This patch qualifies make_tuple.
Looks good at first glance. Creating pull requests @ github for these two.
--
Jeff Garzik
exMULTI, Inc.
jgarzik@exmulti.com
|
