1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
|
Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193]
helo=mx.sourceforge.net)
by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
(envelope-from <jgarzik@exmulti.com>) id 1R65T4-0001ZU-Ef
for bitcoin-development@lists.sourceforge.net;
Tue, 20 Sep 2011 18:54:54 +0000
X-ACL-Warn:
Received: from mail-yw0-f47.google.com ([209.85.213.47])
by sog-mx-3.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-MD5:128)
(Exim 4.76) id 1R65T3-0005mj-1Y
for bitcoin-development@lists.sourceforge.net;
Tue, 20 Sep 2011 18:54:54 +0000
Received: by ywf7 with SMTP id 7so755266ywf.34
for <bitcoin-development@lists.sourceforge.net>;
Tue, 20 Sep 2011 11:54:47 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.236.72.169 with SMTP id t29mr7200694yhd.110.1316544886950;
Tue, 20 Sep 2011 11:54:46 -0700 (PDT)
Received: by 10.236.25.3 with HTTP; Tue, 20 Sep 2011 11:54:46 -0700 (PDT)
X-Originating-IP: [99.43.178.25]
In-Reply-To: <CAL0fb63-zObvzirU1T6-xQnKc4=Ly2go5BBF9Q0XjqAc3o8V7A@mail.gmail.com>
References: <CAL0fb63-zObvzirU1T6-xQnKc4=Ly2go5BBF9Q0XjqAc3o8V7A@mail.gmail.com>
Date: Tue, 20 Sep 2011 14:54:46 -0400
Message-ID: <CA+8xBpdF88tTHOT40=-9enrb4hsekexELSrctdHDK8QqWxGVXw@mail.gmail.com>
From: Jeff Garzik <jgarzik@exmulti.com>
To: Alex Waters <ampedal@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
X-Spam-Score: 0.0 (/)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
See http://spamassassin.org/tag/ for more details.
X-Headers-End: 1R65T3-0005mj-1Y
Cc: bitcoin-development@lists.sourceforge.net
Subject: Re: [Bitcoin-development] Issue / Pulls timers
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Tue, 20 Sep 2011 18:54:54 -0000
On Mon, Sep 19, 2011 at 8:20 PM, Alex Waters <ampedal@gmail.com> wrote:
> I would like to propose adding timers to the pulls / issues:
>
> https://github.com/bitcoin/bitcoin/pull/523
>
> "From time to time a pull request will become outdated. If this occurs, and
> the pull is no longer automatically mergeable; it will be closed after 15
> days. This can be avoided by rebasing the commit. Pull requests closed in this
> manner will have their corresponding issue labeled stagnant.
>
> Non-bug issues with no commits will be closed after 15 days from their
> last activity.
> Issues closed in this manner will be labeled stale.
>
> Requests to reopen closed pull requests and/or issues can be submitted to
> QA@BitcoinTesting.org. "
We need to avoid a user/contributor experience of: "my pull request
was abruptly closed with no warning"
Contributors might not track the state of the tree on a day-to-day
basis. Thus, following the example of bugzilla.redhat.com and many
other "tracker" applications, outdated issues first initiate an
automated warning email -- usually by adding a comment to the bug
report -- that describes the policy, why the policy (closing outdated
reports) exists, and how to avoid automated report closure.
In our case, this means a "we will close pull req, unless you update
this commit in 15 days" comment should be added to the pull req. The
comment should describe in broad terms, with links, how to rebase a
commit, what standard expectations are, etc.
Closing with no warning should be avoided.
--
Jeff Garzik
exMULTI, Inc.
jgarzik@exmulti.com
|
