1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
|
Return-Path: <achow101-lists@achow101.com>
Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org
[172.17.192.35])
by mail.linuxfoundation.org (Postfix) with ESMTPS id 37B02F31
for <bitcoin-dev@lists.linuxfoundation.org>;
Thu, 15 Mar 2018 15:44:47 +0000 (UTC)
X-Greylist: whitelisted by SQLgrey-1.7.6
Received: from mail-qt0-f173.google.com (mail-qt0-f173.google.com
[209.85.216.173])
by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 78F645D4
for <bitcoin-dev@lists.linuxfoundation.org>;
Thu, 15 Mar 2018 15:44:46 +0000 (UTC)
Received: by mail-qt0-f173.google.com with SMTP id v90so7644616qte.12
for <bitcoin-dev@lists.linuxfoundation.org>;
Thu, 15 Mar 2018 08:44:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=achow101-com.20150623.gappssmtp.com; s=20150623;
h=subject:to:references:from:message-id:date:user-agent:mime-version
:in-reply-to:content-language;
bh=ThHjTzSP0rQTBo7fSteTKzMhLW+QKbRi+/MO2xGuGMI=;
b=yxf41wwb+C7aEjnVLH3TZqVRnwOHnGMOo2D7w2Q+5TjXSEiHVUzWRQg0RvPoKTwD/Y
ogu2+mkx1RL25mJpZXPgi146jtnS8GILbQMN+kPADXnyJid/VXBc+JHf7YMRgDqIR+hP
iEsr0IrBR3QUUb6QZk1nD0v1UP/6jaPolcZCPaXwhFaWTTYU66cBt5VGS4KAVCaFYcWn
9uzCJCto6qtSUaIsyD1zXPFdhmNoRVzEwUFV0cLwRuZ6Ew97NolXFuvz/spBkqLZ1Vvx
QgvZ1YNfo9nbiHvjYNjXB3e7IiiBeLIewhN14ybiVX+IvyF/s5e6Yvfv3JGsW4LNzdZJ
bPzQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:subject:to:references:from:message-id:date
:user-agent:mime-version:in-reply-to:content-language;
bh=ThHjTzSP0rQTBo7fSteTKzMhLW+QKbRi+/MO2xGuGMI=;
b=rIlT2p1/AfJ4PAOFWsXGRtftVa/0oiW7kz3G519yc4Mf59QniEQ4h8ebhadL/fVA2R
+I9EKcccjowXGJwDmE3WR+lNRxqcICK3eKYl3L4mUAShUtRnDV2wN+TJJK1XzdIqtLVo
yGJrH/HacHKqO8BcfbgLGHdDRBPneLz8iTMgO7YjoCCmj78zbh6KQmkfbwgCdH1E0nhC
k5AbjghjA2yNjk6zO8aPUNzDdIyELtHVSdlHuaKvExh6sTRWumbpkrjjWBxvWN/uCTTR
fg3uSq6RN3XxyK9JoklAw0YAxRdtrDvbnJIs7fpDc54Oso0lVJr0k4yyRh0lCkUOKGas
o42A==
X-Gm-Message-State: AElRT7HEvC3ZjH2mKkNfmlKVPLJtDuZn1lAFI5MnllpfzfOA2feJCDbs
FDezGKTOZyQ4LQcNID+GA1V4TwelMUc=
X-Google-Smtp-Source: AG47ELsNEAuLpmyKubUTFdiCVGGnJ1htsfvhq1llTW7rPJsqvaZvtEzuVqYu/rexNg4dPcVN3hzi3w==
X-Received: by 10.200.4.9 with SMTP id v9mr13333242qtg.69.1521128685282;
Thu, 15 Mar 2018 08:44:45 -0700 (PDT)
Received: from [192.168.1.247] (c-73-191-37-221.hsd1.md.comcast.net.
[73.191.37.221]) by smtp.gmail.com with ESMTPSA id
b125sm3430207qkd.29.2018.03.15.08.44.44
(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Thu, 15 Mar 2018 08:44:44 -0700 (PDT)
To: Eric Voskuil <eric@voskuil.org>,
Bitcoin Protocol Discussion <bitcoin-dev@lists.linuxfoundation.org>
References: <e2fd3226-91ff-d0ca-67c7-2c4a98c6628f@voskuil.org>
<620d4b5e-61c4-4501-9787-c73109908418@achow101.com>
<8C660724-A76D-44C1-9140-AD3215768CE1@voskuil.org>
From: Andrew Chow <achow101-lists@achow101.com>
Message-ID: <1659f63f-5003-40d5-85a9-11e7a8f34edb@achow101.com>
Date: Thu, 15 Mar 2018 11:44:43 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <8C660724-A76D-44C1-9140-AD3215768CE1@voskuil.org>
Content-Type: multipart/alternative;
boundary="------------F6B1D6987E61B7A6B2D82F36"
Content-Language: en-US
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID, HTML_MESSAGE, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
smtp1.linux-foundation.org
Subject: Re: [bitcoin-dev] version.relay behavior change
X-BeenThere: bitcoin-dev@lists.linuxfoundation.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Bitcoin Protocol Discussion <bitcoin-dev.lists.linuxfoundation.org>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/bitcoin-dev>,
<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/>
List-Post: <mailto:bitcoin-dev@lists.linuxfoundation.org>
List-Help: <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev>,
<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Mar 2018 15:44:47 -0000
This is a multi-part message in MIME format.
--------------F6B1D6987E61B7A6B2D82F36
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
I don't think the nodes that you are connecting to that have this
behavior are actually forked from Bitcoin Core. It seems more like fake
nodes - nodes that don't actually do any verification or follow the
protocol. Such fake nodes can set whatever user agent they want, common
ones being Bitcoin Core's user agents.
IMO your best solution would be to drop peers for protocol noncompliance.
Andrew
On 03/15/2018 05:17 AM, Eric Voskuil wrote:
> Thanks for the reply Andrew. I’ve reviewed the relevant Core sources
> and I do not see any problem. We have also synced against a Core node
> locally and not seen the problem.
>
> The reason I suspected it was Core is that it is very common and all
> of the User Agents are consistent (with an occasional exception for
> forked nodes). So there’s no easy way to determine what sort of nodes
> we are seeing.
>
> We tend to cycle through many more connections during sync than a Core
> node, so may just be seeing it more frequently, but I assume Core
> would log this behavior as well. Even so, seeing that wouldn’t help
> much. I’m as certain as I can be at this point that we are setting the
> flag and version correctly (and that we do not set bip37 filters).
>
> This behavior started infrequently with 0.14.0 peers and has become
> more common over time. Just wondering at this point what fork would
> report as Core and be that common? We used to drop peers that did this
> (for protocol noncompliance), and I’m considering reinstating that
> behavior.
>
> e
>
> On Mar 9, 2018, at 16:33, Andrew Chow via bitcoin-dev
> <bitcoin-dev@lists.linuxfoundation.org
> <mailto:bitcoin-dev@lists.linuxfoundation.org>> wrote:
>
>> Looking through the code, I don't think that this behavior has
>> changed. Are you sure that you are actually connected to
>> Satoshi:0.15.0 nodes and not a node that has simply set their
>> user-agent to that (i.e. not a real Satoshi:0.15.0 node)?
>>
>> If what you are seeing is true, it is likely a bug and not an
>> intentional change. In that case, can you provide specific details on
>> how to reproduce?
>>
>> Andrew
>>
>>
>> On 03/09/2018 02:50 AM, Eric Voskuil via bitcoin-dev wrote:
>>> /Satoshi:0.15.0/ and later nodes appear to be no longer honoring the
>>> version.relay=false flag (BIP37). Could someone familiar with the change
>>> please explain the rational?
>>>
>>> Thanks,
>>>
>>> e
>>>
>>>
>>>
>>> _______________________________________________
>>> bitcoin-dev mailing list
>>> bitcoin-dev@lists.linuxfoundation.org
>>> https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev
>>
>> _______________________________________________
>> bitcoin-dev mailing list
>> bitcoin-dev@lists.linuxfoundation.org
>> <mailto:bitcoin-dev@lists.linuxfoundation.org>
>> https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev
--------------F6B1D6987E61B7A6B2D82F36
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: 8bit
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>I don't think the nodes that you are connecting to that have this
behavior are actually forked from Bitcoin Core. It seems more like
fake nodes - nodes that don't actually do any verification or
follow the protocol. Such fake nodes can set whatever user agent
they want, common ones being Bitcoin Core's user agents.</p>
<p>IMO your best solution would be to drop peers for protocol
noncompliance.</p>
<p>Andrew<br>
</p>
<br>
<div class="moz-cite-prefix">On 03/15/2018 05:17 AM, Eric Voskuil
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:8C660724-A76D-44C1-9140-AD3215768CE1@voskuil.org">
<meta http-equiv="content-type" content="text/html; charset=utf-8">
<div>Thanks for the reply Andrew. I’ve reviewed the relevant Core
sources and I do not see any problem. We have also synced
against a Core node locally and not seen the problem.</div>
<div><br>
</div>
<div>The reason I suspected it was Core is that it is very common
and all of the User Agents are consistent (with an occasional
exception for forked nodes). So there’s no easy way to determine
what sort of nodes we are seeing. </div>
<div><br>
</div>
<div>We tend to cycle through many more connections during sync
than a Core node, so may just be seeing it more frequently, but
I assume Core would log this behavior as well. Even so, seeing
that wouldn’t help much. I’m as certain as I can be at this
point that we are setting the flag and version correctly (and
that we do not set bip37 filters).</div>
<div><br>
</div>
<div>This behavior started infrequently with 0.14.0 peers and has
become more common over time. Just wondering at this point what
fork would report as Core and be that common? We used to drop
peers that did this (for protocol noncompliance), and I’m
considering reinstating that behavior.</div>
<div><br>
</div>
<div>e</div>
<div><br>
On Mar 9, 2018, at 16:33, Andrew Chow via bitcoin-dev <<a
href="mailto:bitcoin-dev@lists.linuxfoundation.org"
moz-do-not-send="true">bitcoin-dev@lists.linuxfoundation.org</a>>
wrote:<br>
<br>
</div>
<blockquote type="cite">
<div>
<meta http-equiv="Content-Type" content="text/html;
charset=utf-8">
<p>Looking through the code, I don't think that this behavior
has changed. Are you sure that you are actually connected to
Satoshi:0.15.0 nodes and not a node that has simply set
their user-agent to that (i.e. not a real Satoshi:0.15.0
node)?</p>
<p>If what you are seeing is true, it is likely a bug and not
an intentional change. In that case, can you provide
specific details on how to reproduce?</p>
<p>Andrew<br>
</p>
<br>
<div class="moz-cite-prefix">On 03/09/2018 02:50 AM, Eric
Voskuil via bitcoin-dev wrote:<br>
</div>
<blockquote type="cite"
cite="mid:e2fd3226-91ff-d0ca-67c7-2c4a98c6628f@voskuil.org">
<pre wrap="">/Satoshi:0.15.0/ and later nodes appear to be no longer honoring the
version.relay=false flag (BIP37). Could someone familiar with the change
please explain the rational?
Thanks,
e
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
bitcoin-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:bitcoin-dev@lists.linuxfoundation.org" moz-do-not-send="true">bitcoin-dev@lists.linuxfoundation.org</a>
<a class="moz-txt-link-freetext" href="https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev" moz-do-not-send="true">https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev</a>
</pre>
</blockquote>
<br>
</div>
</blockquote>
<blockquote type="cite">
<div><span>_______________________________________________</span><br>
<span>bitcoin-dev mailing list</span><br>
<span><a href="mailto:bitcoin-dev@lists.linuxfoundation.org"
moz-do-not-send="true">bitcoin-dev@lists.linuxfoundation.org</a></span><br>
<span><a
href="https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev"
moz-do-not-send="true">https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev</a></span><br>
</div>
</blockquote>
</blockquote>
<br>
</body>
</html>
--------------F6B1D6987E61B7A6B2D82F36--
|
