summaryrefslogtreecommitdiff
path: root/a5/325476b3afde061cd13d55a25bf5101a55e558
blob: 7ce94432347ebf4d6263cd1f9e80a4f1dd713a5d (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
Return-Path: <craigraw@gmail.com>
Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])
 by lists.linuxfoundation.org (Postfix) with ESMTP id DE846C013A
 for <bitcoin-dev@lists.linuxfoundation.org>;
 Mon, 15 Feb 2021 13:53:19 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
 by hemlock.osuosl.org (Postfix) with ESMTP id CCF9E87095
 for <bitcoin-dev@lists.linuxfoundation.org>;
 Mon, 15 Feb 2021 13:53:19 +0000 (UTC)
X-Virus-Scanned: amavisd-new at osuosl.org
Received: from hemlock.osuosl.org ([127.0.0.1])
 by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id ZqMB6g3I-e56
 for <bitcoin-dev@lists.linuxfoundation.org>;
 Mon, 15 Feb 2021 13:53:17 +0000 (UTC)
X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6
Received: from mail-io1-f50.google.com (mail-io1-f50.google.com
 [209.85.166.50])
 by hemlock.osuosl.org (Postfix) with ESMTPS id 7048887058
 for <bitcoin-dev@lists.linuxfoundation.org>;
 Mon, 15 Feb 2021 13:53:17 +0000 (UTC)
Received: by mail-io1-f50.google.com with SMTP id a22so4944133iot.1
 for <bitcoin-dev@lists.linuxfoundation.org>;
 Mon, 15 Feb 2021 05:53:17 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to;
 bh=SzbzaaEMyxPdPMtOI0RsQIyvrUJxet84JXiS1RfYcko=;
 b=aspMJwgIakFd+n+4ELrIl2HDiPZTLnUZjOT5K9k0NJl+p7ne3ucDc2aRED4peSGhpl
 JqvWRQighOdJbGpWKUBinbU/7ydZR3BLfReD03Zr+BzJuRIfDT7l7otKsVwvjo21OEI1
 NPjRWy8/r7gzbdkHB9OUa8ttloRxbbef1Pa4cc41yG4bomFT112bOpRNtA03uCgppUzs
 weShKDiAkkYzDNgzx2ekYO7IBgScvABfPb45dFwEOgWFbm+KEkSnB7jHBqPZy7eZafU8
 rIo5J6gEGrpDVGog+fmmsLGH2vIy4afPFAJNVf71pNGVRBnXzqTFy/LGY17o6h4LpckM
 Dn4A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to;
 bh=SzbzaaEMyxPdPMtOI0RsQIyvrUJxet84JXiS1RfYcko=;
 b=XJhCFj7Z3AQjCQYjvJNRcHEajkZyxsIZPiqF8X1S1kNumDQbOq6r/xcCbnsc0JILMe
 tDEfY9GlHw9+/pQyrZXEAS2ZWxjTLr4ggXKOR+OTXYcWrJsgaK+9ysbdFm6HKS3drra2
 G1wcJQQaAjc443fQ7tRfHlEj/IQN8Uo4V74+CfHd5wpQ3tXA6KuQ7Re7TXKw8X8lo4vy
 Hh0+ik7S5eUIWFPaAB/E+wvwfL8dNfKMGa7yb47klD3CpdzqpgzS18isPxnaK2q/vYdC
 QXAavj7ccRUSvCcjRKehxFAor/yiUzi50395GtsYGntXlBmmjIaD/505OKrnhLTG1/bf
 JpJQ==
X-Gm-Message-State: AOAM530/KOCStMTbJ7sCFrAJEYBG4yoLVX7NWfISUF4fZc6Yy+UZWbl6
 YzyCvsP9nOhnAbLyFNlE4w5TT9v8xrRpN0fi09Y=
X-Google-Smtp-Source: ABdhPJxRQ0PxUQz55KgbpQtb7fbCMNanDAVf1qFqjmyOweXWdYKig51R2wqwojjvYZdazN6dWd+g9TayFBOunKpqoiY=
X-Received: by 2002:a05:6602:106:: with SMTP id
 s6mr12665769iot.17.1613397196679; 
 Mon, 15 Feb 2021 05:53:16 -0800 (PST)
MIME-Version: 1.0
References: <CAPKmR9uyY70MhmVCh=C9DeyF2Tyxibux1E_bLPo00aW_h+OjLw@mail.gmail.com>
 <CAPKmR9urumKTTdBFtu-xY+RdSptOGomnJGK+sbEVnmDH=ZkBKw@mail.gmail.com>
In-Reply-To: <CAPKmR9urumKTTdBFtu-xY+RdSptOGomnJGK+sbEVnmDH=ZkBKw@mail.gmail.com>
From: Craig Raw <craigraw@gmail.com>
Date: Mon, 15 Feb 2021 15:53:05 +0200
Message-ID: <CAPR5oBPtap5Q7DUbNsjy9JxLOp82nEOnj5WA=amas1OqVot-Ew@mail.gmail.com>
To: Hugo Nguyen <hugo@nunchuk.io>, 
 Bitcoin Protocol Discussion <bitcoin-dev@lists.linuxfoundation.org>
Content-Type: multipart/alternative; boundary="000000000000ca302805bb604e0a"
X-Mailman-Approved-At: Mon, 15 Feb 2021 15:39:15 +0000
Subject: Re: [bitcoin-dev] Proposal: Bitcoin Secure Multisig Setup
X-BeenThere: bitcoin-dev@lists.linuxfoundation.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Bitcoin Protocol Discussion <bitcoin-dev.lists.linuxfoundation.org>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/bitcoin-dev>, 
 <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/>
List-Post: <mailto:bitcoin-dev@lists.linuxfoundation.org>
List-Help: <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev>, 
 <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Feb 2021 13:53:20 -0000

--000000000000ca302805bb604e0a
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi all,

Hugo and I have discussed off-list, and I have two concerns with this
proposal:

1. I believe adding the TOKEN and encryption to the exchange adds
complexity to already notoriously complex multisig, without adding much in
the way of security. This is because the shared secret (TOKEN) must still
be shared securely, and if you have established an (off-protocol) secure
channel to do this, why not just share the actual multisig configuration
data directly in that channel? If you are able to do so, you retain the
advantage of being able to inspect the data directly.

2. Asking the user to enter the derivation into the Signer also adds (IMO
unnecessary) complexity to the multisig setup process. A different way of
doing it, which is specified in the UR crypto-account format linked to
previously, has the Signer provide as many common derivations (along with
their xpubs) as it can support for a given BIP44 account number. This has
the dual advantage of making things simpler for the user (they only have to
provide an optional account number) and increasing the standardisation on
common derivation paths. On receiving these derivation/xpub pairs, the
Coordinator can simply pick the appropriate one.

These concerns noted, I agree it's a good idea to have Signers save the
multisig configuration as proposed, and it would be great to have
standardisation in hww import and export formats (not just for multisig).
On that note, I'd love to see greater adoption of the efficient UR2.0
standard and associated formats for airgapped data transmission using QR
codes.

Craig


On Mon, Feb 15, 2021 at 11:13 AM Hugo Nguyen via bitcoin-dev <
bitcoin-dev@lists.linuxfoundation.org> wrote:

> Hi all,
> I have updated the proposal based on further feedback. The new spec is
> included at the bottom.
>
> I have also created a public Github PR to make it easier to comment on th=
e
> text of the spec itself: https://github.com/nunchuk-io/bips/pull/1 .
>
> Could someone please let me know what else needs to be done before a BIP
> number can be assigned?
>
>
> =3D=3D=3D Quick summary of changes from last update =3D=3D=3D
>
> 1. Define encryption modes
>
> # NO_ENCRYPTION: Encryption is disabled.
> # STANDARD : the TOKEN is a 64-bit nonce.
> # EXTENDED : the TOKEN is a 128-bit nonce.
>
> 2. Define signature algorithm
>
> Follow BIP-0322, legacy format allowed.
>
> 3. Multiple TOKENs (optional)
>
> Also add an option where the Coordinator can choose to use one common
> TOKEN for all Signers, or use one per Signer.
>
> =3D=3D=3D End of summary =3D=3D=3D
>
>
> Cheers,
> Hugo
>
>
> <pre>
>   BIP: To be determined
>   Layer: Applications
>   Title: Bitcoin Secure Multisig Setup (BSMS)
>   Author: Hugo Nguyen <hugo at nunchuk.io>, Peter Gray <peter at
> coinkite.com>, Marko Bencun <marko at shiftcrypto.ch>, Pavol Rusnak <
> stick@satoshilabs.com>, Aaron Chen <aarondongchen at gmail.com>, Rodolfo
> Novak <rodolfo at coinkite.com>
>   Comments-Summary: No comments yet.
>   Comments-URI:
>   Status: Proposed
>   Type: Standards Track
>   Created: 2020-11-10
>   License: BSD-2-Clause
> </pre>
>
> =3D=3DIntroduction=3D=3D
>
> =3D=3D=3DAbstract=3D=3D=3D
>
> This document proposes a mechanism to set up multisig wallets securely.
>
> =3D=3D=3DCopyright=3D=3D=3D
>
> This BIP is licensed under the 2-clause BSD license.
>
> =3D=3D=3DMotivation=3D=3D=3D
>
> The Bitcoin multisig experience has been greatly streamlined under [
> https://github.com/bitcoin/bips/blob/master/bip-0174.mediawiki BIP-0174
> (Partially Signed Bitcoin Transaction)]. However, what is still missing i=
s
> a standardized process for setting up multisig wallets securely across
> different vendors.
>
> There are a number of concerns when it comes to setting up a multisig
> wallet:
>
> # Whether the multisig configuration, such as Signer membership, script
> type, derivation paths and number of signatures required, is correct and
> not tampered with.
> # Whether Signer persists the multisig configuration in their respective
> storage, and under what format.
> # Whether Signer's storage is tamper-proof.
> # Whether Signer subsequently uses the multisig configuration to generate
> and verify receive and change addresses.
>
> An attacker who can modify the multisig configuration can steal or hold
> funds to ransom by duping the user into sending funds to the wrong addres=
s.
>
> This proposal seeks to address concerns #1 and #2: to mitigate the risk o=
f
> tampering during the initial setup phase, and to define an interoperable
> multisig configuration format.
>
> Concerns #3 and #4 should be handled by Signers and is out of scope of
> this proposal.
>
> =3D=3DSpecification=3D=3D
>
> =3D=3D=3DPrerequisites=3D=3D=3D
> This proposal assumes the parties in the multisig support [
> https://github.com/bitcoin/bips/blob/master/bip-0032.mediawiki BIP-0032],
> [https://github.com/bitcoin/bitcoin/blob/master/doc/descriptors.md the
> descriptor language] and encryption.
>
> =3D=3D=3DRoles=3D=3D=3D
> =3D=3D=3D=3DCoordinator=3D=3D=3D=3D
>
> The Coordinator initiates the multisig setup. The Coordinator determines
> what type of multisig is used and the exact policy script. If encryption =
is
> enabled, the Coordinator also distributes a shared secret or shared secre=
ts
> to the parties involved for secure communication. The Coordinator gathers
> information from the Signers to generate a descriptor record. The
> Coordinator distributes the descriptor record back to the Signers.
>
> =3D=3D=3D=3DSigner=3D=3D=3D=3D
>
> The Signer is a participating member in the multisig. Its responsibilitie=
s
> include providing its key record -- which contains an Extended Public Key
> (XPUB) -- to the Coordinator, verifying that its XPUB is included in the
> descriptor record and persisting the descriptor record in its storage.
>
> =3D=3D=3DSetup Process=3D=3D=3D
>
> =3D=3D=3D=3DRound 1=3D=3D=3D=3D
>
> =3D=3D=3D=3D=3DCoordinator=3D=3D=3D=3D=3D
>
> * The Coordinator creates a multisig wallet creation session. The
> Coordinator constructs the multisig script and its policy parameters, suc=
h
> as the total number of signers and the required number of signatures
> (<tt>M</tt> and <tt>N</tt>).
> * The session should expire after some time period determined by the
> Coordinator, e.g., 24 hours.
> * If encryption is enabled, the Coordinator distributes a secret
> <tt>TOKEN</tt> to each Signer over a secure channel. The Signer can use t=
he
> <tt>TOKEN</tt> to derive an <tt>ENCRYPTION_KEY</tt>. Refer to the
> Encryption section below for details on the <tt>TOKEN</tt>, the key
> derivation function and the encryption scheme. Depending on the use case,
> the Coordinator can decide whether to share one common <tt>TOKEN</tt> for
> all Signers, or to have one per Signer.
> * If encryption is disabled, <tt>TOKEN</tt> is set to <tt>0</tt>, and all
> the encryption/decryption steps below can be skipped.
>
> =3D=3D=3D=3D=3DSigner=3D=3D=3D=3D=3D
>
> * The Signer initiates a new secure multisig setup session by setting the
> <tt>TOKEN</tt>. The Signer derives an <tt>ENCRYPTION_KEY</tt> from the
> <tt>TOKEN</tt>. The Signer can keep the session open until a different
> value for the <tt>TOKEN</tt> is set.
> * The Signer generates a key record by prompting the user for a multisig
> derivation path and retrieves the XPUB at that derivation path. Optionall=
y,
> the Signer can choose a path on behalf of the user. If the Signer chooses
> the path, it should try to avoid reusing XPUBs for different wallets.
> * The first line in the record must be the <tt>TOKEN</tt>. The second lin=
e
> must be the <tt>KEY</tt>. The <tt>KEY</tt> is an XPUB plus its key origin
> information, written in the descriptor-defined format, i.e.: <tt>[{master
> key fingerprint}/{derivation path}]{XPUB}</tt>. The third line must be a
> <tt>SIG</tt>, whereas <tt>SIG</tt> is the signature generated by using th=
e
> private key associated with the XPUB to sign the first two lines.  The
> signature should follow [
> https://github.com/bitcoin/bips/blob/master/bip-0322.mediawiki BIP-0322],
> legacy format accepted. Finally, the Signer encrypts the entire record wi=
th
> <tt>ENCRYPTION_KEY</tt>.
>
> =3D=3D=3D=3DRound 2=3D=3D=3D=3D
>
> =3D=3D=3D=3D=3DCoordinator=3D=3D=3D=3D=3D
>
> * The Coordinator gathers key records from all participating Signers.
> Abort the setup if the wallet setup session has expired.
> * For each key record, the Coordinator decrypts it using
> <tt>ENCRYPTION_KEY</tt>. The Coordinator verifies that the included
> <tt>SIG</tt> is valid given the <tt>KEY</tt>.
> * If all key records look good, the Coordinator fills in all necessary
> information to generate a descriptor record, which is simply the descript=
or
> string plus a <tt>CHECKSUM</tt>, all in one line. The <tt>CHECKSUM</tt> h=
as
> [
> https://github.com/bitcoin/bitcoin/blob/master/doc/descriptors.md#checksu=
ms
> BECH32 encoding].
> * The Coordinator encrypts this descriptor record with
> <tt>ENCRYPTION_KEY</tt>.
> * The Coordinator sends the encrypted descriptor record to all
> participating Signers.
>
> =3D=3D=3D=3D=3DSigner=3D=3D=3D=3D=3D
>
> * The Signer imports the descriptor record, decrypts it using the
> <tt>ENCRYPTION_KEY</tt> derived from the open session.
> * The Signer calculates and verifies the descriptor=E2=80=99s <tt>CHECKSU=
M</tt>.
> Abort the setup if the <tt>CHECKSUM</tt> is incorrect.
> * The Signer checks whether one of the <tt>KEY</tt>s in the descriptor
> belongs to it, using path and fingerprint information included in the
> descriptor. The check must perform an exact match on the <tt>KEY</tt>s, a=
nd
> not using shortcuts such as matching fingerprints (which is trivial to
> spoof). Abort the setup if it doesn=E2=80=99t detect its own <tt>KEY</tt>=
.
> * For confirmation, the Signer must display to the user the
> <tt>CHECKSUM</tt>, plus other configurations, such as <tt>M</tt> and
> <tt>N</tt>. The total number of Signers, <tt>N</tt>, is important to
> prevent a <tt>KEY</tt> insertion attack. All participating Signers should
> be able to display the same confirmation.
> * If all checks pass, the Signer persists the descriptor record in its
> storage.
> * The Signer can choose to further restrict post-XPUB derivation paths,
> such as to those defined in [
> https://github.com/bitcoin/bips/blob/master/bip-0044.mediawiki BIP-0044].
> * The Signer should subsequently use the descriptor to generate and verif=
y
> receive and change addresses.
>
> This completes the setup.
>
> =3D=3D=3DEncryption=3D=3D=3D
>
> =3D=3D=3D=3DThe Token=3D=3D=3D=3D
> We define three modes of encryption.
>
> # <tt>NO_ENCRYPTION</tt> : the <tt>TOKEN</tt> is set to <tt>0</tt>.
> Encryption is disabled.
> # <tt>STANDARD</tt> : the <tt>TOKEN</tt> is a 64-bit nonce.
> # <tt>EXTENDED</tt> : the <tt>TOKEN</tt> is a 128-bit nonce.
>
> The <tt>TOKEN</tt> can be converted to one of these formats:
> * A mnemonic phrase using [
> https://github.com/bitcoin/bips/blob/master/bip-0039.mediawiki BIP-0039]
> word list (6 words in <tt>STANDARD</tt> mode, 12 words in <tt>EXTENDED</t=
t>
> mode)
> * A decimal number (20 digits in <tt>STANDARD</tt> mode, 40 digits in
> <tt>EXTENDED</tt> mode)
> * A QR code
> * Other formats
>
> The flexibility in the data format allows each Signer to customize the
> User Experience based on its respective capabilities.
>
> =3D=3D=3D=3DKey Derivation=3D=3D=3D=3D
> The key derivation function is [https://tools.ietf.org/html/rfc2898
> PBKDF2], with PRF =3D SHA512. Specifically:
>
> <tt>DK =3D PBKDF2(PRF, Password, Salt, c, dkLen)</tt>
>
> Whereas:
>
> * PRF =3D <tt>SHA512</tt>
> * Password =3D <tt>"No SPOF"</tt>
> * Salt =3D <tt>TOKEN</tt>
> * c =3D <tt>2048</tt>
> * dkLen =3D <tt>256</tt>
> * DK =3D Derived <tt>ENCRYPTION_KEY</tt>
>
> =3D=3D=3D=3DEncryption Scheme=3D=3D=3D=3D
> The encryption scheme is [https://tools.ietf.org/html/rfc3686 AES, CTR
> mode].
>
> =3D=3DQR Codes=3D=3D
> For signers that use QR codes to transmit data, key and descriptor record=
s
> can be converted to QR codes, following [
> https://github.com/BlockchainCommons/Research/blob/master/papers/bcr-2020=
-005-ur.md
> the BCR standard].
>
> Also refer to [
> https://github.com/BlockchainCommons/Research/blob/master/papers/bcr-2020=
-015-account.md
> UR Type Definition for BIP44 Accounts] and [
> https://github.com/BlockchainCommons/Research/blob/master/papers/bcr-2020=
-010-output-desc.md
> UR Type Definition for Bitcoin Output Descriptors] for more details.
>
> =3D=3DSecurity=3D=3D
>
> This proposal introduces two layers of protection. The first one is a
> temporary, secret token, used to encrypt the two rounds of communication
> between the Signer and the Coordinator. The second one is through the
> descriptor checksum and visual inspection of the descriptor itself.
>
> The token is only needed during the setup phase, and can be safely thrown
> away afterwards. The token does not guarantee that the Signer membership
> set is not modified, since that depends on the overall security of all
> parties in the setup, but it can make it significantly harder for an
> attacker to do so.
>
> There are three ways an attacker can modify the membership set: by
> changing an existing member, by removing an existing member, or by adding=
 a
> new member.
>
> For the first two methods, one of the Signers will be able to detect that
> its membership has been changed or removed, and reject the final
> descriptor. Thus, it is vital that all participating Signers check that
> their membership is intact in the descriptor. Even one Signer failing to
> check for its membership means that the setup could be compromised.
>
> For the third type of attack, the descriptor checksum and visual
> inspection of the descriptor itself are the only way to guard against
> malicious members from being inserted into the set.
>
> =3D=3DAcknowledgement=3D=3D
>
> Special thanks to Dmitry Petukhov, Christopher Allen, Craig Raw and other=
s
> for their feedback on the specification.
>
> =3D=3DReferences=3D=3D
>
> Original mailing list thread:
> https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2021-February/018=
385.html
>
>
> _______________________________________________
> bitcoin-dev mailing list
> bitcoin-dev@lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev
>

--000000000000ca302805bb604e0a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi all,</div><div><br></div>Hugo and I have discussed=
 off-list, and I have two concerns with this proposal:<div><br></div><div>1=
. I believe adding the TOKEN and encryption to the exchange adds complexity=
 to already notoriously complex multisig, without adding much in the way of=
 security. This is because the shared secret (TOKEN) must still be shared s=
ecurely, and if you have established an (off-protocol) secure channel to do=
 this, why not just share the actual multisig configuration data directly i=
n that channel? If you are able to do so, you retain the advantage of being=
 able to inspect the data directly.</div><div><br></div><div>2. Asking the =
user to enter the derivation into the Signer also adds (IMO unnecessary) co=
mplexity to the multisig setup process. A different way of doing it, which =
is specified in the UR crypto-account format linked to previously, has the =
Signer provide as many common derivations (along with their xpubs) as it ca=
n support for a given BIP44 account number. This has the dual advantage of =
making things simpler for the user (they only have to provide an optional a=
ccount number) and increasing the standardisation on common derivation path=
s. On receiving these derivation/xpub pairs, the Coordinator can simply pic=
k the appropriate one.</div><div><br></div><div>These concerns noted, I agr=
ee it&#39;s a good idea to have Signers save the multisig configuration as =
proposed, and it would be great to have standardisation in hww import and e=
xport formats (not just for multisig). On that note, I&#39;d love to see gr=
eater adoption of the efficient UR2.0 standard and associated formats for a=
irgapped data transmission using QR codes.</div><div><br></div><div>Craig</=
div><div><br></div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" cl=
ass=3D"gmail_attr">On Mon, Feb 15, 2021 at 11:13 AM Hugo Nguyen via bitcoin=
-dev &lt;<a href=3D"mailto:bitcoin-dev@lists.linuxfoundation.org">bitcoin-d=
ev@lists.linuxfoundation.org</a>&gt; wrote:<br></div><blockquote class=3D"g=
mail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204=
,204,204);padding-left:1ex"><div dir=3D"ltr"><div>Hi all,<br>I have updated=
 the proposal based on further feedback. The new spec is included at the bo=
ttom.</div><div><br></div><div>I have also created a public Github PR to ma=
ke it easier to comment on the text of the spec itself:=C2=A0<a href=3D"htt=
ps://github.com/nunchuk-io/bips/pull/1" target=3D"_blank">https://github.co=
m/nunchuk-io/bips/pull/1</a> .<br><br>Could someone please let me know what=
 else needs to be done before a BIP number can be assigned?<br><br><br>=3D=
=3D=3D Quick summary of changes from last update =3D=3D=3D<br><br>1. Define=
 encryption modes<br><br># NO_ENCRYPTION: Encryption is disabled.<br># STAN=
DARD : the TOKEN is a 64-bit nonce.<br># EXTENDED : the TOKEN is a 128-bit =
nonce.<br><br>2. Define signature algorithm<br><br>Follow BIP-0322, legacy =
format allowed.<br><br>3. Multiple TOKENs (optional)<br><br>Also add an opt=
ion where the Coordinator can choose to use one common TOKEN for all Signer=
s, or use one per Signer.<br><br>=3D=3D=3D End of summary =3D=3D=3D</div><d=
iv><br></div><div><br>Cheers,<br>Hugo</div><div class=3D"gmail_quote"><div>=
<br><br>&lt;pre&gt;<br>=C2=A0 BIP: To be determined<br>=C2=A0 Layer: Applic=
ations<br>=C2=A0 Title: Bitcoin Secure Multisig Setup (BSMS)<br>=C2=A0 Auth=
or: Hugo Nguyen &lt;hugo at <a href=3D"http://nunchuk.io" target=3D"_blank"=
>nunchuk.io</a>&gt;, Peter Gray &lt;peter at <a href=3D"http://coinkite.com=
" target=3D"_blank">coinkite.com</a>&gt;, Marko Bencun &lt;marko at <a href=
=3D"http://shiftcrypto.ch" target=3D"_blank">shiftcrypto.ch</a>&gt;, Pavol =
Rusnak &lt;<a href=3D"mailto:stick@satoshilabs.com" target=3D"_blank">stick=
@satoshilabs.com</a>&gt;, Aaron Chen &lt;aarondongchen at <a href=3D"http:/=
/gmail.com" target=3D"_blank">gmail.com</a>&gt;, Rodolfo Novak &lt;rodolfo =
at <a href=3D"http://coinkite.com" target=3D"_blank">coinkite.com</a>&gt;<b=
r>=C2=A0 Comments-Summary: No comments yet.<br>=C2=A0 Comments-URI:<br>=C2=
=A0 Status: Proposed<br>=C2=A0 Type: Standards Track<br>=C2=A0 Created: 202=
0-11-10<br>=C2=A0 License: BSD-2-Clause<br>&lt;/pre&gt;<br><br>=3D=3DIntrod=
uction=3D=3D<br><br>=3D=3D=3DAbstract=3D=3D=3D<br><br>This document propose=
s a mechanism to set up multisig wallets securely.<br><br>=3D=3D=3DCopyrigh=
t=3D=3D=3D<br><br>This BIP is licensed under the 2-clause BSD license.<br><=
br>=3D=3D=3DMotivation=3D=3D=3D<br><br>The Bitcoin multisig experience has =
been greatly streamlined under [<a href=3D"https://github.com/bitcoin/bips/=
blob/master/bip-0174.mediawiki" target=3D"_blank">https://github.com/bitcoi=
n/bips/blob/master/bip-0174.mediawiki</a> BIP-0174<br>(Partially Signed Bit=
coin Transaction)]. However, what is still missing is a standardized proces=
s for setting up multisig wallets securely across different vendors.<br><br=
>There are a number of concerns when it comes to setting up a multisig wall=
et:<br><br># Whether the multisig configuration, such as Signer membership,=
 script type, derivation paths and number of signatures required, is correc=
t and not tampered with.<br># Whether Signer persists the multisig configur=
ation in their respective storage, and under what format.<br># Whether Sign=
er&#39;s storage is tamper-proof.<br># Whether Signer subsequently uses the=
 multisig configuration to generate and verify receive and change addresses=
.<br><br>An attacker who can modify the multisig configuration can steal or=
 hold funds to ransom by duping the user into sending funds to the wrong ad=
dress.<br><br>This proposal seeks to address concerns #1 and #2: to mitigat=
e the risk of tampering during the initial setup phase, and to define an in=
teroperable multisig configuration format.<br><br>Concerns #3 and #4 should=
 be handled by Signers and is out of scope of this proposal.<br><br>=3D=3DS=
pecification=3D=3D<br><br>=3D=3D=3DPrerequisites=3D=3D=3D<br>This proposal =
assumes the parties in the multisig support [<a href=3D"https://github.com/=
bitcoin/bips/blob/master/bip-0032.mediawiki" target=3D"_blank">https://gith=
ub.com/bitcoin/bips/blob/master/bip-0032.mediawiki</a> BIP-0032], [<a href=
=3D"https://github.com/bitcoin/bitcoin/blob/master/doc/descriptors.md" targ=
et=3D"_blank">https://github.com/bitcoin/bitcoin/blob/master/doc/descriptor=
s.md</a> the descriptor language] and encryption.<br><br>=3D=3D=3DRoles=3D=
=3D=3D<br>=3D=3D=3D=3DCoordinator=3D=3D=3D=3D<br><br>The Coordinator initia=
tes the multisig setup. The Coordinator determines what type of multisig is=
 used and the exact policy script. If encryption is enabled, the Coordinato=
r also distributes a shared secret or shared secrets to the parties involve=
d for secure communication. The Coordinator gathers information from the Si=
gners to generate a descriptor record. The Coordinator distributes the desc=
riptor record back to the Signers.<br><br>=3D=3D=3D=3DSigner=3D=3D=3D=3D<br=
><br>The Signer is a participating member in the multisig. Its responsibili=
ties include providing its key record -- which contains an Extended Public =
Key (XPUB) -- to the Coordinator, verifying that its XPUB is included in th=
e descriptor record and persisting the descriptor record in its storage.<br=
><br>=3D=3D=3DSetup Process=3D=3D=3D<br><br>=3D=3D=3D=3DRound 1=3D=3D=3D=3D=
<br><br>=3D=3D=3D=3D=3DCoordinator=3D=3D=3D=3D=3D<br><br>* The Coordinator =
creates a multisig wallet creation session. The Coordinator constructs the =
multisig script and its policy parameters, such as the total number of sign=
ers and the required number of signatures (&lt;tt&gt;M&lt;/tt&gt; and &lt;t=
t&gt;N&lt;/tt&gt;).<br>* The session should expire after some time period d=
etermined by the Coordinator, e.g., 24 hours.<br>* If encryption is enabled=
, the Coordinator distributes a secret &lt;tt&gt;TOKEN&lt;/tt&gt; to each S=
igner over a secure channel. The Signer can use the &lt;tt&gt;TOKEN&lt;/tt&=
gt; to derive an &lt;tt&gt;ENCRYPTION_KEY&lt;/tt&gt;. Refer to the Encrypti=
on section below for details on the &lt;tt&gt;TOKEN&lt;/tt&gt;, the key der=
ivation function and the encryption scheme. Depending on the use case, the =
Coordinator can decide whether to share one common &lt;tt&gt;TOKEN&lt;/tt&g=
t; for all Signers, or to have one per Signer.<br>* If encryption is disabl=
ed, &lt;tt&gt;TOKEN&lt;/tt&gt; is set to &lt;tt&gt;0&lt;/tt&gt;, and all th=
e encryption/decryption steps below can be skipped.<br><br>=3D=3D=3D=3D=3DS=
igner=3D=3D=3D=3D=3D<br><br>* The Signer initiates a new secure multisig se=
tup session by setting the &lt;tt&gt;TOKEN&lt;/tt&gt;. The Signer derives a=
n &lt;tt&gt;ENCRYPTION_KEY&lt;/tt&gt; from the &lt;tt&gt;TOKEN&lt;/tt&gt;. =
The Signer can keep the session open until a different value for the &lt;tt=
&gt;TOKEN&lt;/tt&gt; is set.<br>* The Signer generates a key record by prom=
pting the user for a multisig derivation path and retrieves the XPUB at tha=
t derivation path. Optionally, the Signer can choose a path on behalf of th=
e user. If the Signer chooses the path, it should try to avoid reusing XPUB=
s for different wallets.<br>* The first line in the record must be the &lt;=
tt&gt;TOKEN&lt;/tt&gt;. The second line must be the &lt;tt&gt;KEY&lt;/tt&gt=
;. The &lt;tt&gt;KEY&lt;/tt&gt; is an XPUB plus its key origin information,=
 written in the descriptor-defined format, i.e.: &lt;tt&gt;[{master key fin=
gerprint}/{derivation path}]{XPUB}&lt;/tt&gt;. The third line must be a &lt=
;tt&gt;SIG&lt;/tt&gt;, whereas &lt;tt&gt;SIG&lt;/tt&gt; is the signature ge=
nerated by using the private key associated with the XPUB to sign the first=
 two lines.=C2=A0 The signature should follow [<a href=3D"https://github.co=
m/bitcoin/bips/blob/master/bip-0322.mediawiki" target=3D"_blank">https://gi=
thub.com/bitcoin/bips/blob/master/bip-0322.mediawiki</a> BIP-0322], legacy =
format accepted. Finally, the Signer encrypts the entire record with &lt;tt=
&gt;ENCRYPTION_KEY&lt;/tt&gt;.<br><br>=3D=3D=3D=3DRound 2=3D=3D=3D=3D<br><b=
r>=3D=3D=3D=3D=3DCoordinator=3D=3D=3D=3D=3D<br><br>* The Coordinator gather=
s key records from all participating Signers. Abort the setup if the wallet=
 setup session has expired.<br>* For each key record, the Coordinator decry=
pts it using &lt;tt&gt;ENCRYPTION_KEY&lt;/tt&gt;. The Coordinator verifies =
that the included &lt;tt&gt;SIG&lt;/tt&gt; is valid given the &lt;tt&gt;KEY=
&lt;/tt&gt;.<br>* If all key records look good, the Coordinator fills in al=
l necessary information to generate a descriptor record, which is simply th=
e descriptor string plus a &lt;tt&gt;CHECKSUM&lt;/tt&gt;, all in one line. =
The &lt;tt&gt;CHECKSUM&lt;/tt&gt; has [<a href=3D"https://github.com/bitcoi=
n/bitcoin/blob/master/doc/descriptors.md#checksums" target=3D"_blank">https=
://github.com/bitcoin/bitcoin/blob/master/doc/descriptors.md#checksums</a> =
BECH32 encoding].<br>* The Coordinator encrypts this descriptor record with=
 &lt;tt&gt;ENCRYPTION_KEY&lt;/tt&gt;.<br>* The Coordinator sends the encryp=
ted descriptor record to all participating Signers.<br><br>=3D=3D=3D=3D=3DS=
igner=3D=3D=3D=3D=3D<br><br>* The Signer imports the descriptor record, dec=
rypts it using the &lt;tt&gt;ENCRYPTION_KEY&lt;/tt&gt; derived from the ope=
n session.<br>* The Signer calculates and verifies the descriptor=E2=80=99s=
 &lt;tt&gt;CHECKSUM&lt;/tt&gt;. Abort the setup if the &lt;tt&gt;CHECKSUM&l=
t;/tt&gt; is incorrect.<br>* The Signer checks whether one of the &lt;tt&gt=
;KEY&lt;/tt&gt;s in the descriptor belongs to it, using path and fingerprin=
t information included in the descriptor. The check must perform an exact m=
atch on the &lt;tt&gt;KEY&lt;/tt&gt;s, and not using shortcuts such as matc=
hing fingerprints (which is trivial to spoof). Abort the setup if it doesn=
=E2=80=99t detect its own &lt;tt&gt;KEY&lt;/tt&gt;.<br>* For confirmation, =
the Signer must display to the user the &lt;tt&gt;CHECKSUM&lt;/tt&gt;, plus=
 other configurations, such as &lt;tt&gt;M&lt;/tt&gt; and &lt;tt&gt;N&lt;/t=
t&gt;. The total number of Signers, &lt;tt&gt;N&lt;/tt&gt;, is important to=
 prevent a &lt;tt&gt;KEY&lt;/tt&gt; insertion attack. All participating Sig=
ners should be able to display the same confirmation.<br>* If all checks pa=
ss, the Signer persists the descriptor record in its storage.<br>* The Sign=
er can choose to further restrict post-XPUB derivation paths, such as to th=
ose defined in [<a href=3D"https://github.com/bitcoin/bips/blob/master/bip-=
0044.mediawiki" target=3D"_blank">https://github.com/bitcoin/bips/blob/mast=
er/bip-0044.mediawiki</a> BIP-0044].<br>* The Signer should subsequently us=
e the descriptor to generate and verify receive and change addresses.<br><b=
r>This completes the setup.<br><br>=3D=3D=3DEncryption=3D=3D=3D<br><br>=3D=
=3D=3D=3DThe Token=3D=3D=3D=3D<br>We define three modes of encryption.<br><=
br># &lt;tt&gt;NO_ENCRYPTION&lt;/tt&gt; : the &lt;tt&gt;TOKEN&lt;/tt&gt; is=
 set to &lt;tt&gt;0&lt;/tt&gt;. Encryption is disabled.<br># &lt;tt&gt;STAN=
DARD&lt;/tt&gt; : the &lt;tt&gt;TOKEN&lt;/tt&gt; is a 64-bit nonce.<br># &l=
t;tt&gt;EXTENDED&lt;/tt&gt; : the &lt;tt&gt;TOKEN&lt;/tt&gt; is a 128-bit n=
once.<br><br>The &lt;tt&gt;TOKEN&lt;/tt&gt; can be converted to one of thes=
e formats:<br>* A mnemonic phrase using [<a href=3D"https://github.com/bitc=
oin/bips/blob/master/bip-0039.mediawiki" target=3D"_blank">https://github.c=
om/bitcoin/bips/blob/master/bip-0039.mediawiki</a> BIP-0039] word list (6 w=
ords in &lt;tt&gt;STANDARD&lt;/tt&gt; mode, 12 words in &lt;tt&gt;EXTENDED&=
lt;/tt&gt; mode)<br>* A decimal number (20 digits in &lt;tt&gt;STANDARD&lt;=
/tt&gt; mode, 40 digits in &lt;tt&gt;EXTENDED&lt;/tt&gt; mode)<br>* A QR co=
de<br>* Other formats<br><br>The flexibility in the data format allows each=
 Signer to customize the User Experience based on its respective capabiliti=
es.<br><br>=3D=3D=3D=3DKey Derivation=3D=3D=3D=3D<br>The key derivation fun=
ction is [<a href=3D"https://tools.ietf.org/html/rfc2898" target=3D"_blank"=
>https://tools.ietf.org/html/rfc2898</a> PBKDF2], with PRF =3D SHA512. Spec=
ifically:<br><br>&lt;tt&gt;DK =3D PBKDF2(PRF, Password, Salt, c, dkLen)&lt;=
/tt&gt;<br><br>Whereas:<br><br>* PRF =3D &lt;tt&gt;SHA512&lt;/tt&gt;<br>* P=
assword =3D &lt;tt&gt;&quot;No SPOF&quot;&lt;/tt&gt;<br>* Salt =3D &lt;tt&g=
t;TOKEN&lt;/tt&gt;<br>* c =3D &lt;tt&gt;2048&lt;/tt&gt;<br>* dkLen =3D &lt;=
tt&gt;256&lt;/tt&gt;<br>* DK =3D Derived &lt;tt&gt;ENCRYPTION_KEY&lt;/tt&gt=
;<br><br>=3D=3D=3D=3DEncryption Scheme=3D=3D=3D=3D<br>The encryption scheme=
 is [<a href=3D"https://tools.ietf.org/html/rfc3686" target=3D"_blank">http=
s://tools.ietf.org/html/rfc3686</a> AES, CTR mode].<br><br>=3D=3DQR Codes=
=3D=3D<br>For signers that use QR codes to transmit data, key and descripto=
r records can be converted to QR codes, following [<a href=3D"https://githu=
b.com/BlockchainCommons/Research/blob/master/papers/bcr-2020-005-ur.md" tar=
get=3D"_blank">https://github.com/BlockchainCommons/Research/blob/master/pa=
pers/bcr-2020-005-ur.md</a> the BCR standard].<br><br>Also refer to [<a hre=
f=3D"https://github.com/BlockchainCommons/Research/blob/master/papers/bcr-2=
020-015-account.md" target=3D"_blank">https://github.com/BlockchainCommons/=
Research/blob/master/papers/bcr-2020-015-account.md</a> UR Type Definition =
for BIP44 Accounts] and [<a href=3D"https://github.com/BlockchainCommons/Re=
search/blob/master/papers/bcr-2020-010-output-desc.md" target=3D"_blank">ht=
tps://github.com/BlockchainCommons/Research/blob/master/papers/bcr-2020-010=
-output-desc.md</a> UR Type Definition for Bitcoin Output Descriptors] for =
more details.<br><br>=3D=3DSecurity=3D=3D<br><br>This proposal introduces t=
wo layers of protection. The first one is a temporary, secret token, used t=
o encrypt the two rounds of communication between the Signer and the Coordi=
nator. The second one is through the descriptor checksum and visual inspect=
ion of the descriptor itself.<br><br>The token is only needed during the se=
tup phase, and can be safely thrown away afterwards. The token does not gua=
rantee that the Signer membership set is not modified, since that depends o=
n the overall security of all parties in the setup, but it can make it sign=
ificantly harder for an attacker to do so.<br><br>There are three ways an a=
ttacker can modify the membership set: by changing an existing member, by r=
emoving an existing member, or by adding a new member.<br><br>For the first=
 two methods, one of the Signers will be able to detect that its membership=
 has been changed or removed, and reject the final descriptor. Thus, it is =
vital that all participating Signers check that their membership is intact =
in the descriptor. Even one Signer failing to check for its membership mean=
s that the setup could be compromised.<br><br>For the third type of attack,=
 the descriptor checksum and visual inspection of the descriptor itself are=
 the only way to guard against malicious members from being inserted into t=
he set.<br><br>=3D=3DAcknowledgement=3D=3D<br><br>Special thanks to Dmitry =
Petukhov, Christopher Allen, Craig Raw and others for their feedback on the=
 specification.<br><br>=3D=3DReferences=3D=3D<br><br>Original mailing list =
thread: <a href=3D"https://lists.linuxfoundation.org/pipermail/bitcoin-dev/=
2021-February/018385.html" target=3D"_blank">https://lists.linuxfoundation.=
org/pipermail/bitcoin-dev/2021-February/018385.html</a><br><br>=C2=A0</div>=
</div></div>
_______________________________________________<br>
bitcoin-dev mailing list<br>
<a href=3D"mailto:bitcoin-dev@lists.linuxfoundation.org" target=3D"_blank">=
bitcoin-dev@lists.linuxfoundation.org</a><br>
<a href=3D"https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev" =
rel=3D"noreferrer" target=3D"_blank">https://lists.linuxfoundation.org/mail=
man/listinfo/bitcoin-dev</a><br>
</blockquote></div>

--000000000000ca302805bb604e0a--