summaryrefslogtreecommitdiff
path: root/a2/1e535b9b3f9dd5b5337bab7a05ea6a6be5ce50
blob: 406eb9ff2024975c737596fbfec71ee1a3b43d3e (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
Return-Path: <tier.nolan@gmail.com>
Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org
	[172.17.192.35])
	by mail.linuxfoundation.org (Postfix) with ESMTPS id 94F80273
	for <bitcoin-dev@lists.linuxfoundation.org>;
	Mon, 22 Jun 2015 19:28:50 +0000 (UTC)
X-Greylist: whitelisted by SQLgrey-1.7.6
Received: from mail-qc0-f170.google.com (mail-qc0-f170.google.com
	[209.85.216.170])
	by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 13F8A17D
	for <bitcoin-dev@lists.linuxfoundation.org>;
	Mon, 22 Jun 2015 19:28:50 +0000 (UTC)
Received: by qcji3 with SMTP id i3so10358216qcj.1
	for <bitcoin-dev@lists.linuxfoundation.org>;
	Mon, 22 Jun 2015 12:28:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:cc
	:content-type; bh=R8B+wuTvvAS8/TxX87gxK+Mick5O6JtXES4FnhszHDk=;
	b=MbB0Bhp1Zi4ma76TcmSD/hkjt8Q8dOP58CTCtYgTACeT6j1ohmj4cMz8mQOh8Ia+Fj
	FyBiQpUVbCEduWgn7WXHmEwMdpf1LWvrMwis5blnl8daGi1iybhCrN3cM/7RPyyJVO+H
	uk4QVgMMNVt/uQmmpNuacbXcLL0+mrUqIrHwWlaVfSSabtVEIXWK/+5P3WAVdpDsb/2a
	PVEv8vCGuEt6CFK2YzZKZun8tYZQlFOTFmr2vwWGvlKdtmfxt19B1GbIN9ZzNRBEEj4F
	9nircmP3bFhRYdKhW+gjbEb0kJm/l7YdntiMWbrA8XJwnMhi8PBJFo/uNlInAlj8SnGq
	PmJA==
MIME-Version: 1.0
X-Received: by 10.140.216.208 with SMTP id m199mr41735962qhb.69.1435001329336; 
	Mon, 22 Jun 2015 12:28:49 -0700 (PDT)
Received: by 10.140.85.241 with HTTP; Mon, 22 Jun 2015 12:28:49 -0700 (PDT)
In-Reply-To: <55885DB0.9040709@gmail.com>
References: <CABsx9T2HegqOBqd1jijk1bZBE6N+NH8x6nfwbaoLBACVf8-WBQ@mail.gmail.com>
	<55885DB0.9040709@gmail.com>
Date: Mon, 22 Jun 2015 20:28:49 +0100
Message-ID: <CAE-z3OWqiGPPNVxBVU0mx+TKFuysKrhXpwg6gOFcwGBQx26VtQ@mail.gmail.com>
From: Tier Nolan <tier.nolan@gmail.com>
Cc: bitcoin-dev@lists.linuxfoundation.org
Content-Type: multipart/alternative; boundary=001a1135d7967cc98b051920480b
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,HTML_MESSAGE,MISSING_HEADERS,
	RCVD_IN_DNSWL_LOW autolearn=no version=3.3.1
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
	smtp1.linux-foundation.org
Subject: Re: [bitcoin-dev] Draft BIP : fixed-schedule block size increase
X-BeenThere: bitcoin-dev@lists.linuxfoundation.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Bitcoin Development Discussion <bitcoin-dev.lists.linuxfoundation.org>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/bitcoin-dev>,
	<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/>
List-Post: <mailto:bitcoin-dev@lists.linuxfoundation.org>
List-Help: <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev>,
	<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Jun 2015 19:28:50 -0000

--001a1135d7967cc98b051920480b
Content-Type: text/plain; charset=UTF-8

On Mon, Jun 22, 2015 at 8:10 PM, Martin Schwarz <martin.schwarz@gmail.com>
wrote:

> Gavin,
>
> in 2022 your proposal (BIP as well as code) crosses the 32MB maximum
> message size limit. In order to avoid deployment of code that
> deterministically
> fails fatally in 2022, I'd propose to stop the doublings at 32MB for now
> and fix
> the message size limit in the mean time.


There is an exception in the code for "block" messages.

https://github.com/gavinandresen/bitcoinxt/commit/c81898ec46e4962daf975e352931b848026fdc34#diff-7ec3c68a81efff79b6ca22ac1f1eabbaR3548

This means 2MB limit for all other messages.  "block" messages are limited
to the max block size for 2 hours into the future.

I think setting it to a week into the future might be better, since it is
only a DOS protection.  This would guarantee that message sizes are
reasonable.  The size check would still be done anyway.

--001a1135d7967cc98b051920480b
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_extra"><div class=3D"gmail_quote">On M=
on, Jun 22, 2015 at 8:10 PM, Martin Schwarz <span dir=3D"ltr">&lt;<a href=
=3D"mailto:martin.schwarz@gmail.com" target=3D"_blank">martin.schwarz@gmail=
.com</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"ma=
rgin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:=
1ex">Gavin,<br>
<br>
in 2022 your proposal (BIP as well as code) crosses the 32MB maximum<br>
message size limit. In order to avoid deployment of code that deterministic=
ally<br>
fails fatally in 2022, I&#39;d propose to stop the doublings at 32MB for no=
w and fix<br>
the message size limit in the mean time.</blockquote><div><br></div><div>Th=
ere is an exception in the code for &quot;block&quot; messages.=C2=A0 <br><=
/div><div><br><a href=3D"https://github.com/gavinandresen/bitcoinxt/commit/=
c81898ec46e4962daf975e352931b848026fdc34#diff-7ec3c68a81efff79b6ca22ac1f1ea=
bbaR3548">https://github.com/gavinandresen/bitcoinxt/commit/c81898ec46e4962=
daf975e352931b848026fdc34#diff-7ec3c68a81efff79b6ca22ac1f1eabbaR3548</a><br=
><br></div><div>This means 2MB limit for all other messages.=C2=A0 &quot;bl=
ock&quot; messages are limited to the max block size for 2 hours into the f=
uture.<br><br></div><div>I think setting it to a week into the future might=
 be better, since it is only a DOS protection.=C2=A0 This would guarantee t=
hat message sizes are reasonable.=C2=A0 The size check would still be done =
anyway.<br></div></div></div></div>

--001a1135d7967cc98b051920480b--