summaryrefslogtreecommitdiff
path: root/9e/d77dd87edb76801d24d935e61ad2ed555cb363
blob: d41281985b6bc827b9d12408d17cc69889f03bbc (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
Return-Path: <ferdinando@ametrano.net>
Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])
 by lists.linuxfoundation.org (Postfix) with ESMTP id B1043C07FF
 for <bitcoin-dev@lists.linuxfoundation.org>;
 Mon, 16 Nov 2020 23:38:58 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
 by silver.osuosl.org (Postfix) with ESMTP id 970A720656
 for <bitcoin-dev@lists.linuxfoundation.org>;
 Mon, 16 Nov 2020 23:38:58 +0000 (UTC)
X-Virus-Scanned: amavisd-new at osuosl.org
Received: from silver.osuosl.org ([127.0.0.1])
 by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 1Hi2GFfpketf
 for <bitcoin-dev@lists.linuxfoundation.org>;
 Mon, 16 Nov 2020 23:38:57 +0000 (UTC)
X-Greylist: delayed 00:36:45 by SQLgrey-1.7.6
Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com
 [209.85.218.47])
 by silver.osuosl.org (Postfix) with ESMTPS id 0EA1F2011A
 for <bitcoin-dev@lists.linuxfoundation.org>;
 Mon, 16 Nov 2020 23:38:57 +0000 (UTC)
Received: by mail-ej1-f47.google.com with SMTP id za3so26877429ejb.5
 for <bitcoin-dev@lists.linuxfoundation.org>;
 Mon, 16 Nov 2020 15:38:56 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=ametrano-net.20150623.gappssmtp.com; s=20150623;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to;
 bh=aSCBNtTqNMMIttEyfQOOAfJpcozS+Q6xEkSDiGXtALo=;
 b=TTilodTku5qsbYQvhS3k48d+l5FgOj/eSxt+V/V7e7rDLCszYu/WB6b15J/CDM8QI+
 ZmqDRAuIw3CmWpf8HfyUPg+ZBRDELfgTWeWUEDeg+C6QbX3UnD2C0IUF+l0VtoOijT6A
 d3MpbDJ+t2P9vTZYRYG3PGg5/o0XsXkIkdgoC+O1emZjJROG9dRAO67Q+RX7msCT3vmT
 uBQbfYzOfeRo1f1DtgmusipDtHKes1/GRQw3FxzOK65aS6qgdhlShv7K4gIgmitgDqfD
 l5lE35cwnt5IP3dC7JymjdYCKWJjD39EaFJGOHGmTR+BQ1FD1VI3NJOKoptsbgEllkN8
 wmlg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to;
 bh=aSCBNtTqNMMIttEyfQOOAfJpcozS+Q6xEkSDiGXtALo=;
 b=MF6Q6grgH0Q0P1g2JJ/x5jXvJOKI7/eU9ZoJFvjnOJ0L7rUlXseRLrAq5uKY/7R3nN
 rcoFMYNUbt24SY/gJ1g5oV8iU1aq8kltVkuz2s+XwvrPbC/CaBVFu/EwIJyJ6cC8sqwd
 kA2FjCuSEabRjQOwhOtEjfNiAaJBxlzpuacyiyHxHJ2mWUf07JJ6jNhJQ6EvVj3ztN4L
 9qWq0xFX3dUgmSb9aDK17DfQHjh1C3ICU6OWkZ25UcWJ6yzRXqT30Stvc+5UGWMoJcZq
 evtMHVRnx2sqWMCPDZUC5zWSarikjv4UVIbIY7C3bMKS1vgRlZTjDHS2w/ZMmv9jr1Dt
 yI2A==
X-Gm-Message-State: AOAM530ZuddZBkwoE4ucD9vuiBGh/c65giAaeVW8KjKTSYojKAj59nWQ
 vUleBu+BiByG4xC38JCEHmjoAgrqRbqLRJUio6SyIPtmy89t1zB6LLU=
X-Google-Smtp-Source: ABdhPJx/S3N85GdQBkKkSKYlEJ+YoGlDIkqt7p/49GHJ+oG6Q7Zqut1ii3hC/PSdhU+tNJ2gM9TLbLy6Js+V5IdGaeM=
X-Received: by 2002:a17:906:892:: with SMTP id
 n18mr16359775eje.1.1605569935022; 
 Mon, 16 Nov 2020 15:38:55 -0800 (PST)
MIME-Version: 1.0
References: <CADfmNEk3nr33MMym1D_n8_DWgj39AWoOuTpFbBO0U6MZis_=vA@mail.gmail.com>
In-Reply-To: <CADfmNEk3nr33MMym1D_n8_DWgj39AWoOuTpFbBO0U6MZis_=vA@mail.gmail.com>
From: "Ferdinando M. Ametrano" <ferdinando@ametrano.net>
Date: Tue, 17 Nov 2020 00:38:19 +0100
Message-ID: <CADfmNEkJfvefTaAg42PU5DWu1PLJhXxptVY69yVJNRCdx4fuBQ@mail.gmail.com>
To: bitcoin-dev@lists.linuxfoundation.org
Content-Type: multipart/alternative; boundary="000000000000a3b40f05b441e19f"
X-Mailman-Approved-At: Mon, 16 Nov 2020 23:41:33 +0000
Subject: Re: [bitcoin-dev] Against proprietary and PoR fields in PSBT BIP174
X-BeenThere: bitcoin-dev@lists.linuxfoundation.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Bitcoin Protocol Discussion <bitcoin-dev.lists.linuxfoundation.org>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/bitcoin-dev>, 
 <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/>
List-Post: <mailto:bitcoin-dev@lists.linuxfoundation.org>
List-Help: <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev>, 
 <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Nov 2020 23:38:58 -0000

--000000000000a3b40f05b441e19f
Content-Type: text/plain; charset="UTF-8"

After having checked that the BIP174 test vectors do not cover the
*proprietary* and *proof-of-reserves* types, I went ahead and submitted a
PR to the bips repo for the removal of those fields from the PSBT
specifications

https://github.com/bitcoin/bips/pull/1038

--
*Ferdinando M. Ametrano*
www.ametrano.net/about


On Tue, Nov 17, 2020 at 12:01 AM Ferdinando M. Ametrano <
ferdinando@ametrano.net> wrote:

> Hi all,
>
> While implementing PSBT support in the *btclib* library (
> https://github.com/btclib-org/btclib), I have failed to understand the
> rationale for the *proprietary* and *proof-of-reserves* types.
>
> First off, at face value they have nothing to do with the operations
> intrinsically required to finalize a valid transaction from PSBT
> manipulation.
>
> Moreover, whatever information content they can provide for non-standard
> PSBT manipulation, that content could stay in the *unknown* field without
> any loss of generality. How to structure and deal with unknown data would
> be the responsibility of proprietary software or users wanting to provide
> proof-of-reserve. As long as BIP174 clearly prescribes that unknown data
> must be kept during PSBT manipulation, that should be enough.
>
> Let me stress the above point: I have a project where we include
> proprietary information in the PSBT. Any PSBT software supporting unknown
> data gently keeps our proprietary information and our proprietary software
> retrieves that data from serialized PSBT with no problem. There is no need
> for a PSBT implementation to provide explicit support for *proprietary*
> and *proof-of-reserves* types.
>
> My last conclusion is reinforced by the evidence of all PSBT
> implementations I know of, including bitcoin core and HWI, not implementing
> proprietary and proof-of-reserve types. There is a high probability that
> part of BIP174 would be just ignored.
>
> Am I missing something?
>
> Thanks
> --
> *Ferdinando M. Ametrano*
> www.ametrano.net/about
>

--000000000000a3b40f05b441e19f
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_default" style=3D""><font face=3D"verd=
ana, sans-serif">After having=C2=A0checked that the BIP174 test vectors do =
not cover the=C2=A0<i style=3D"">proprietary</i>=C2=A0and=C2=A0<i style=3D"=
">proof-of-reserves</i>=C2=A0types, I went ahead and=C2=A0submitted a PR to=
 the bips repo=C2=A0for the removal of those fields from the PSBT specifica=
tions</font></div><div class=3D"gmail_default" style=3D""><font face=3D"ver=
dana, sans-serif"><br></font></div><div class=3D"gmail_default" style=3D"">=
<a href=3D"https://github.com/bitcoin/bips/pull/1038" target=3D"_blank" sty=
le=3D""><font face=3D"verdana, sans-serif">https://github.com/bitcoin/bips/=
pull/1038</font></a><br></div><div><div dir=3D"ltr" data-smartmail=3D"gmail=
_signature"><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div dir=3D"ltr"><d=
iv dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><font face=3D"verdana, san=
s-serif"><br></font></div><div><font face=3D"verdana, sans-serif">--<br></f=
ont></div><div dir=3D"ltr"><div><font size=3D"1" face=3D"verdana, sans-seri=
f"><span style=3D"margin:0px;padding:0px;line-height:12px;color:rgb(33,33,3=
3);display:block"><span style=3D"margin:0px;padding:0px;line-height:12px;di=
splay:block"><b>Ferdinando M. Ametrano</b></span></span></font></div><div><=
span style=3D"margin:0px;padding:0px;font-size:10px;line-height:12px;color:=
rgb(33,33,33);display:block"><div style=3D"color:rgb(34,34,34);font-size:sm=
all"><font face=3D"verdana, sans-serif" style=3D"font-size:10px;color:rgb(1=
7,85,204)"><a href=3D"https://www.ametrano.net/about" style=3D"font-size:10=
px;color:rgb(17,85,204)" target=3D"_blank">www.ametrano.net/about</a></font=
></div></span></div></div></div></div></div></div></div></div></div></div><=
/div><br></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gma=
il_attr">On Tue, Nov 17, 2020 at 12:01 AM Ferdinando M. Ametrano &lt;<a hre=
f=3D"mailto:ferdinando@ametrano.net" target=3D"_blank">ferdinando@ametrano.=
net</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"marg=
in:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1e=
x"><div dir=3D"ltr"><div class=3D"gmail_default"><font face=3D"verdana, san=
s-serif">Hi all,</font></div><div class=3D"gmail_default"><font face=3D"ver=
dana, sans-serif"><br></font></div><div class=3D"gmail_default"><font face=
=3D"verdana, sans-serif">While implementing PSBT support in the <i>btclib</=
i> library (<a href=3D"https://github.com/btclib-org/btclib" target=3D"_bla=
nk">https://github.com/btclib-org/btclib</a>), I have failed to understand =
the rationale for the <i>proprietary</i> and <i>proof-of-reserves</i> types=
.</font></div><div class=3D"gmail_default"><font face=3D"verdana, sans-seri=
f"><br></font></div><div class=3D"gmail_default"><font face=3D"verdana, san=
s-serif">First off, at face value they have nothing to do with=C2=A0the ope=
rations intrinsically required to  finalize a valid transaction from PSBT m=
anipulation.</font></div><div class=3D"gmail_default"><font face=3D"verdana=
, sans-serif"><br></font></div><div class=3D"gmail_default"><font face=3D"v=
erdana, sans-serif">Moreover, whatever information content they can provide=
 for non-standard PSBT manipulation, that content could stay in the <i>unkn=
own</i> field without any loss of generality. How to structure and deal wit=
h unknown data would be the responsibility=C2=A0of proprietary=C2=A0softwar=
e or users wanting to provide proof-of-reserve. As long as BIP174 clearly p=
rescribes that unknown=C2=A0data must be kept during PSBT manipulation, tha=
t should be enough.</font></div><div class=3D"gmail_default"><font face=3D"=
verdana, sans-serif"><br></font></div><div class=3D"gmail_default"><font fa=
ce=3D"verdana, sans-serif">Let me stress the above point: I have a project =
where we include proprietary information in the PSBT. Any PSBT software sup=
porting unknown data gently keeps our proprietary information and our propr=
ietary software retrieves that data from serialized PSBT with no problem. T=
here is no need for a PSBT implementation to provide explicit support for=
=C2=A0<i>proprietary</i> and <i>proof-of-reserves</i> types.</font></div><d=
iv class=3D"gmail_default"><font face=3D"verdana, sans-serif"><br></font></=
div><div class=3D"gmail_default"></div><div class=3D"gmail_default"><font f=
ace=3D"verdana, sans-serif">My last conclusion is reinforced by the evidenc=
e of all PSBT implementations I know of, including bitcoin core and HWI, no=
t implementing proprietary and proof-of-reserve types. There is a high prob=
ability that part of BIP174 would be just ignored.</font></div><div class=
=3D"gmail_default"><font face=3D"verdana, sans-serif"><br></font></div><div=
 class=3D"gmail_default"><font face=3D"verdana, sans-serif">Am I missing so=
mething?</font></div><div class=3D"gmail_default"><font face=3D"verdana, sa=
ns-serif"><br></font></div><div class=3D"gmail_default"><font face=3D"verda=
na, sans-serif">Thanks</font></div><div><div dir=3D"ltr"><div dir=3D"ltr"><=
div><div dir=3D"ltr"><div><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr=
"><div dir=3D"ltr"><font face=3D"verdana, sans-serif">--<br></font></div><d=
iv dir=3D"ltr"><div><font size=3D"1" face=3D"verdana, sans-serif"><span sty=
le=3D"margin:0px;padding:0px;line-height:12px;color:rgb(33,33,33);display:b=
lock"><span style=3D"margin:0px;padding:0px;line-height:12px;display:block"=
><b>Ferdinando M. Ametrano</b></span></span></font></div><div><span style=
=3D"margin:0px;padding:0px;font-size:10px;line-height:12px;color:rgb(33,33,=
33);display:block"><div style=3D"color:rgb(34,34,34);font-size:small"><font=
 face=3D"verdana, sans-serif" style=3D"font-size:10px;color:rgb(17,85,204)"=
><a href=3D"https://www.ametrano.net/about" style=3D"font-size:10px;color:r=
gb(17,85,204)" target=3D"_blank">www.ametrano.net/about</a></font></div></s=
pan></div></div></div></div></div></div></div></div></div></div></div></div=
>
</blockquote></div>

--000000000000a3b40f05b441e19f--