1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
|
Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191]
helo=mx.sourceforge.net)
by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
(envelope-from <chris.double@gmail.com>) id 1Qzr1d-0003lq-Fu
for bitcoin-development@lists.sourceforge.net;
Sat, 03 Sep 2011 14:16:49 +0000
Received-SPF: pass (sog-mx-1.v43.ch3.sourceforge.com: domain of gmail.com
designates 209.85.161.47 as permitted sender)
client-ip=209.85.161.47; envelope-from=chris.double@gmail.com;
helo=mail-fx0-f47.google.com;
Received: from mail-fx0-f47.google.com ([209.85.161.47])
by sog-mx-1.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128)
(Exim 4.76) id 1Qzr1b-0004VF-Ro
for bitcoin-development@lists.sourceforge.net;
Sat, 03 Sep 2011 14:16:49 +0000
Received: by fxg11 with SMTP id 11so3549208fxg.34
for <bitcoin-development@lists.sourceforge.net>;
Sat, 03 Sep 2011 07:16:41 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.223.74.83 with SMTP id t19mr143550faj.114.1315059401033; Sat,
03 Sep 2011 07:16:41 -0700 (PDT)
Sender: chris.double@gmail.com
Received: by 10.223.107.10 with HTTP; Sat, 3 Sep 2011 07:16:40 -0700 (PDT)
In-Reply-To: <CALn1vHHynfb-u8fSwsStA=e5vR6x-e3yA44Z9Mt9A+AgO1+ezQ@mail.gmail.com>
References: <CALn1vHHynfb-u8fSwsStA=e5vR6x-e3yA44Z9Mt9A+AgO1+ezQ@mail.gmail.com>
Date: Sun, 4 Sep 2011 02:16:40 +1200
X-Google-Sender-Auth: 44bR9w6ef9I-PFfs-A3gQyG1_88
Message-ID: <CALn1vHHZAfE+phvcaSQNaaAgWPjVGfhOXKyp+hofrYgwAKBR9w@mail.gmail.com>
From: Chris Double <chris.double@double.co.nz>
To: bitcoin-development@lists.sourceforge.net
Content-Type: text/plain; charset=ISO-8859-1
X-Spam-Score: -0.9 (/)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
See http://spamassassin.org/tag/ for more details.
-1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for
sender-domain
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider
(chris.double[at]gmail.com)
-0.0 SPF_PASS SPF: sender matches SPF record
1.1 FRT_ADOBE2 BODY: ReplaceTags: Adobe
0.1 DKIM_SIGNED Message has a DKIM or DK signature,
not necessarily valid
-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
0.0 T_TO_NO_BRKTS_FREEMAIL To: misformatted and free email service
-0.6 AWL AWL: From: address is in the auto white-list
X-Headers-End: 1Qzr1b-0004VF-Ro
Subject: Re: [Bitcoin-development] Transaction limit size in
CWallet::CreateTransaction
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Sat, 03 Sep 2011 14:16:49 -0000
On Sun, Sep 4, 2011 at 1:52 AM, Chris Double <chris.double@double.co.nz> wrote:
> So was the intent to use the CWalletTxn size, and the casting is
> superfluous, or was it supposed to be the CTransaction* portion and
> the cast is an incorrect way of doing that? Or am I suffering from
> late night programmer syndrome and reading it wrong?
After a discussion on #bitcoin-dev it is indeed the latter. I was
under the mistaken believe that the GetSerializeSize method in
CTransaction and CWalletTxn were virtual, which would result in the
behavior I was thinking of. But they're not so it works. Please
disregard!
Chris.
--
http://www.bluishcoder.co.nz
|
