1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
|
Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192]
helo=mx.sourceforge.net)
by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
(envelope-from <jgarzik@bitpay.com>) id 1Wrshv-0000I5-Ou
for bitcoin-development@lists.sourceforge.net;
Tue, 03 Jun 2014 17:41:07 +0000
Received-SPF: pass (sog-mx-2.v43.ch3.sourceforge.com: domain of bitpay.com
designates 209.85.212.173 as permitted sender)
client-ip=209.85.212.173; envelope-from=jgarzik@bitpay.com;
helo=mail-wi0-f173.google.com;
Received: from mail-wi0-f173.google.com ([209.85.212.173])
by sog-mx-2.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128)
(Exim 4.76) id 1Wrshu-0005jA-La
for bitcoin-development@lists.sourceforge.net;
Tue, 03 Jun 2014 17:41:07 +0000
Received: by mail-wi0-f173.google.com with SMTP id bs8so6961647wib.0
for <bitcoin-development@lists.sourceforge.net>;
Tue, 03 Jun 2014 10:41:00 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:mime-version:in-reply-to:references:from:date
:message-id:subject:to:cc:content-type;
bh=fCdrH6L79XrNF+7xt1cPzHmQk6zYTQdOGZP94pWTzPs=;
b=AcOvXYJgNpeHHyu6IiVS7lcSJkJaIqhF6bb8u5n1qRAPpGWSydMzqsVsAXyVe+4tMx
nItYOewA+1kAuX8Lm7rzPNk74gyRHR3W/bWz+KooPVVsjELDPP43aiLBniVAoYZeeGMO
xqRnEWJ6RwRHOii91HtiqHyPDjGih21RAOQQF5krnYgn2FwZE57ZvL7BI8megntt1GT3
12NiaQiHTmzmTJ/jKqV8uwzYa7gZSiYLsTlVCXDwrBozNc+gJRt6XM2wLcyv2s6qrtK3
iMqcT7DWpwHcMlPZnpNAeuaord98IHdz4vonx0haBhAbzhDZo57GtHGjdWZCSOemoMio
Q3WA==
X-Gm-Message-State: ALoCoQlrlTnoURoJigO7Xnj/7gkOA7wF+Y3BpMsbpAT9IRyw2olt58PHcFuJGt/NqCODbxKVjb9E
X-Received: by 10.180.72.136 with SMTP id d8mr34341740wiv.36.1401817259605;
Tue, 03 Jun 2014 10:40:59 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.194.240.166 with HTTP; Tue, 3 Jun 2014 10:40:38 -0700 (PDT)
In-Reply-To: <CANFXpYOFcYtt_PS4RNmiXdcNbLbY5S29aO14sP8fK+GN3ivNYg@mail.gmail.com>
References: <CANFXpYOdmweoxXRM_LcnB-jFNHt8kj_B0jTFZ00Jffi7UHvwPA@mail.gmail.com>
<CAJHLa0OiFCX_CT-OLBaFHB5SGL0ADsXm7gQrsRs7inu=qM1E6g@mail.gmail.com>
<CANFXpYOFcYtt_PS4RNmiXdcNbLbY5S29aO14sP8fK+GN3ivNYg@mail.gmail.com>
From: Jeff Garzik <jgarzik@bitpay.com>
Date: Tue, 3 Jun 2014 13:40:38 -0400
Message-ID: <CAJHLa0NX44cxQLdm7oSewu33uZs--hpHjOouOpBy6G9f+nghNw@mail.gmail.com>
To: Toshi Morita <toshi@peernova.com>
Content-Type: text/plain; charset=UTF-8
X-Spam-Score: -1.6 (-)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
See http://spamassassin.org/tag/ for more details.
-1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for
sender-domain
-0.0 SPF_PASS SPF: sender matches SPF record
-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from
author's domain
0.1 DKIM_SIGNED Message has a DKIM or DK signature,
not necessarily valid
-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
X-Headers-End: 1Wrshu-0005jA-La
Cc: bitcoin-development <bitcoin-development@lists.sourceforge.net>
Subject: Re: [Bitcoin-development] Another uninitialized memory problem
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Tue, 03 Jun 2014 17:41:07 -0000
Does this fix it? https://github.com/bitcoin/bitcoin/pull/4282
On Tue, Jun 3, 2014 at 12:47 PM, Toshi Morita <toshi@peernova.com> wrote:
> I looked at this a bit more yesterday, and it looks like both sides of the
> comparison were uninitialized, and I fixed one side, but the other side has
> the same problem.
>
> I'll try to investigate further this afternoon once I get out of
> meetings/meetings prep.
>
> Toshi
>
>
>
> On Tue, Jun 3, 2014 at 9:43 AM, Jeff Garzik <jgarzik@bitpay.com> wrote:
>>
>> I think I see the problem.
>>
>>
>> On Mon, Jun 2, 2014 at 4:01 PM, Toshi Morita <toshi@peernova.com> wrote:
>> > I'm seeing another uninitialized memory problem in bitcoind using
>> > valgrind:
>> >
>> > tm@tm-VirtualBox:~/bitcoind/bitcoin/src$ valgrind ./bitcoind
>> > ==2337== Memcheck, a memory error detector
>> > ==2337== Copyright (C) 2002-2012, and GNU GPL'd, by Julian Seward et al.
>> > ==2337== Using Valgrind-3.8.1 and LibVEX; rerun with -h for copyright
>> > info
>> > ==2337== Command: ./bitcoind
>> > ==2337==
>> > ==2337== Conditional jump or move depends on uninitialised value(s)
>> > ==2337== at 0x319176: CWallet::LoadKeyMetadata(CPubKey const&,
>> > CKeyMetadata const&) (wallet.cpp:110)
>> > ==2337== by 0x33645A: ReadKeyValue(CWallet*, CDataStream&,
>> > CDataStream&,
>> > CWalletScanState&, std::string&, std::string&) (walletdb.cpp:509)
>> > ==2337== by 0x3374F0: CWalletDB::LoadWallet(CWallet*)
>> > (walletdb.cpp:623)
>> > ==2337== by 0x3218FD: CWallet::LoadWallet(bool&) (wallet.cpp:1485)
>> > ==2337== by 0x157F16: AppInit2(boost::thread_group&) (init.cpp:958)
>> > ==2337== by 0x140142: AppInit(int, char**) (bitcoind.cpp:143)
>> > ==2337== by 0x13649E: main (bitcoind.cpp:180)
>> > ==2337==
>> >
>> >
>> >
>> > ------------------------------------------------------------------------------
>> > Learn Graph Databases - Download FREE O'Reilly Book
>> > "Graph Databases" is the definitive new guide to graph databases and
>> > their
>> > applications. Written by three acclaimed leaders in the field,
>> > this first edition is now available. Download your free book today!
>> > http://p.sf.net/sfu/NeoTech
>> > _______________________________________________
>> > Bitcoin-development mailing list
>> > Bitcoin-development@lists.sourceforge.net
>> > https://lists.sourceforge.net/lists/listinfo/bitcoin-development
>> >
>>
>>
>>
>> --
>> Jeff Garzik
>> Bitcoin core developer and open source evangelist
>> BitPay, Inc. https://bitpay.com/
>
>
--
Jeff Garzik
Bitcoin core developer and open source evangelist
BitPay, Inc. https://bitpay.com/
|
