1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
|
Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192]
helo=mx.sourceforge.net)
by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
(envelope-from <mh.in.england@gmail.com>) id 1UpErd-0005Rz-82
for bitcoin-development@lists.sourceforge.net;
Wed, 19 Jun 2013 09:39:41 +0000
Received-SPF: pass (sog-mx-2.v43.ch3.sourceforge.com: domain of gmail.com
designates 209.85.219.48 as permitted sender)
client-ip=209.85.219.48; envelope-from=mh.in.england@gmail.com;
helo=mail-oa0-f48.google.com;
Received: from mail-oa0-f48.google.com ([209.85.219.48])
by sog-mx-2.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128)
(Exim 4.76) id 1UpErc-0002Qq-4G
for bitcoin-development@lists.sourceforge.net;
Wed, 19 Jun 2013 09:39:41 +0000
Received: by mail-oa0-f48.google.com with SMTP id f4so6284515oah.35
for <bitcoin-development@lists.sourceforge.net>;
Wed, 19 Jun 2013 02:39:34 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.60.33.234 with SMTP id u10mr1466282oei.29.1371634774741;
Wed, 19 Jun 2013 02:39:34 -0700 (PDT)
Sender: mh.in.england@gmail.com
Received: by 10.76.23.36 with HTTP; Wed, 19 Jun 2013 02:39:34 -0700 (PDT)
In-Reply-To: <1371594630.18036.YahooMailNeo@web162703.mail.bf1.yahoo.com>
References: <1371577555.61696.YahooMailNeo@web162703.mail.bf1.yahoo.com>
<CANEZrP0ViJSQr_UUxLqM-eFTir=-FGwZ2cSxuPgaVi=KiM8gsA@mail.gmail.com>
<1371594630.18036.YahooMailNeo@web162703.mail.bf1.yahoo.com>
Date: Wed, 19 Jun 2013 11:39:34 +0200
X-Google-Sender-Auth: RTpEM_RZXwfYxc5CeJz6bepKa4c
Message-ID: <CANEZrP3D6TRzzJOZ-mW67nJk_hqApt9quCYyoM8oF=ugDW_F6g@mail.gmail.com>
From: Mike Hearn <mike@plan99.net>
To: Turkey Breast <turkeybreast@yahoo.com>
Content-Type: multipart/alternative; boundary=089e013c7042829e4504df7e9b9e
X-Spam-Score: -0.5 (/)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
See http://spamassassin.org/tag/ for more details.
-1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for
sender-domain
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider
(mh.in.england[at]gmail.com)
-0.0 SPF_PASS SPF: sender matches SPF record
1.0 HTML_MESSAGE BODY: HTML included in message
0.1 DKIM_SIGNED Message has a DKIM or DK signature,
not necessarily valid
-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
X-Headers-End: 1UpErc-0002Qq-4G
Cc: "bitcoin-development@lists.sourceforge.net"
<bitcoin-development@lists.sourceforge.net>
Subject: Re: [Bitcoin-development] Missing fRelayTxes in version message
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Wed, 19 Jun 2013 09:39:41 -0000
--089e013c7042829e4504df7e9b9e
Content-Type: text/plain; charset=UTF-8
It has to be optional because old clients don't send it, obviously.
Why is this even an issue? There's no problem with variable length messages
in any codebase that I'm aware of. Is this solving some actual problem?
On Wed, Jun 19, 2013 at 12:30 AM, Turkey Breast <turkeybreast@yahoo.com>wrote:
> That's me. I never said to make all messages fixed length. I said to make
> a fixed number of fields per protocol. So given a protocol version number,
> you know the number of fields in a message. This is not only easier for
> parsing messages, but just good practice. I don't see why a 1 byte flag
> needs to be optional anyway.
>
> ------------------------------
> *From:* Mike Hearn <mike@plan99.net>
> *To:* Turkey Breast <turkeybreast@yahoo.com>
> *Cc:* Bitcoin Dev <bitcoin-development@lists.sourceforge.net>
> *Sent:* Tuesday, June 18, 2013 9:48 PM
> *Subject:* Re: [Bitcoin-development] Missing fRelayTxes in version message
>
> It's not a bug (although there was recently a change to make bitcoind/qt
> always send this field anyway).
>
> I don't know where Amir is going with BIP 60. Version messages have always
> been variable length. There's nothing inherent in the Bitcoin protocol that
> says all messages are fixed length, indeed, tx messages are allowed to have
> arbitrary data appended after them that gets relayed.
>
>
> On Tue, Jun 18, 2013 at 7:45 PM, Turkey Breast <turkeybreast@yahoo.com>wrote:
>
> See this BIP. I'm not sure if this is a bug or what, but it would be good
> if messages always had a fixed number of fields per protocol version.
>
> https://en.bitcoin.it/wiki/BIP_0060#Code_Updates
>
> This BIP details everything that needs to be done and proposes a protocol
> upgrade.
>
>
> ------------------------------------------------------------------------------
> This SF.net <http://sf.net/> email is sponsored by Windows:
>
> Build for Windows Store.
>
> http://p.sf.net/sfu/windows-dev2dev
> _______________________________________________
> Bitcoin-development mailing list
> Bitcoin-development@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/bitcoin-development
>
>
>
>
>
>
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by Windows:
>
> Build for Windows Store.
>
> http://p.sf.net/sfu/windows-dev2dev
> _______________________________________________
> Bitcoin-development mailing list
> Bitcoin-development@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/bitcoin-development
>
>
--089e013c7042829e4504df7e9b9e
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr">It has to be optional because old clients don't send i=
t, obviously.<div><br></div><div style>Why is this even an issue? There'=
;s no problem with variable length messages in any codebase that I'm aw=
are of. Is this solving some actual problem?</div>
</div><div class=3D"gmail_extra"><br><br><div class=3D"gmail_quote">On Wed,=
Jun 19, 2013 at 12:30 AM, Turkey Breast <span dir=3D"ltr"><<a href=3D"m=
ailto:turkeybreast@yahoo.com" target=3D"_blank">turkeybreast@yahoo.com</a>&=
gt;</span> wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex"><div><div style=3D"font-size:12pt;font-famil=
y:times new roman,new york,times,serif"><div><span>That's me. I never s=
aid to make all messages fixed length. I said to make a fixed number of fie=
lds per protocol. So given a protocol version number, you know the number o=
f fields in a message. This is not only easier for parsing messages, but ju=
st good practice. I don't see why a 1 byte flag needs to be optional an=
yway.<br>
</span></div><div class=3D"hm HOEnZb"><div><br></div> </div><div style=3D"=
font-family:times new roman,new york,times,serif;font-size:12pt"><div class=
=3D"hm HOEnZb"> </div><div style=3D"font-family:times new roman,new york,ti=
mes,serif;font-size:12pt">
<div class=3D"hm HOEnZb"> <div dir=3D"ltr"> <hr size=3D"1"> <font face=3D"=
Arial"> <b><span style=3D"font-weight:bold">From:</span></b> Mike Hearn <=
;<a href=3D"mailto:mike@plan99.net" target=3D"_blank">mike@plan99.net</a>&g=
t;<br> <b><span style=3D"font-weight:bold">To:</span></b> Turkey Breast <=
;<a href=3D"mailto:turkeybreast@yahoo.com" target=3D"_blank">turkeybreast@y=
ahoo.com</a>> <br>
<b><span style=3D"font-weight:bold">Cc:</span></b>
Bitcoin Dev <<a href=3D"mailto:bitcoin-development@lists.sourceforge.ne=
t" target=3D"_blank">bitcoin-development@lists.sourceforge.net</a>> <br>=
<b><span style=3D"font-weight:bold">Sent:</span></b> Tuesday, June 18, 201=
3 9:48 PM<br>
<b><span style=3D"font-weight:bold">Subject:</span></b> Re: [Bitcoin-devel=
opment] Missing fRelayTxes in version message<br> </font> </div></div><div>=
<div class=3D"h5"> <div><br>
<div><div dir=3D"ltr">It's not a bug (although there was recently a cha=
nge to make bitcoind/qt always send this field anyway).=C2=A0<div><br></div=
><div>I don't know where Amir is going with BIP 60. Version messages ha=
ve always been variable length. There's nothing inherent in the Bitcoin=
protocol that says all messages are fixed length, indeed, tx messages are =
allowed to have arbitrary data appended after them that gets relayed.</div>
</div><div><br><br><div>On Tue, Jun 18, 2013 at 7:45 PM, Turkey Breast <spa=
n dir=3D"ltr"><<a rel=3D"nofollow" href=3D"mailto:turkeybreast@yahoo.com=
" target=3D"_blank">turkeybreast@yahoo.com</a>></span> wrote:<br>
<blockquote style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-l=
eft:1ex"><div><div style=3D"font-size:12pt;font-family:times new roman,new =
york,times,serif"><div>See this BIP. I'm not sure if this is a bug or w=
hat, but it would be good if messages always had a fixed number of fields p=
er protocol version.</div>
<div><br></div><div style=3D"font-style:normal;font-size:16px;background-co=
lor:transparent;font-family:times new roman,new york,times,serif"><a rel=3D=
"nofollow" href=3D"https://en.bitcoin.it/wiki/BIP_0060#Code_Updates" target=
=3D"_blank">https://en.bitcoin.it/wiki/BIP_0060#Code_Updates</a></div>
<div style=3D"font-style:normal;font-size:16px;background-color:transparent=
;font-family:times new roman,new york,times,serif"><br></div><div style=3D"=
font-style:normal;font-size:16px;background-color:transparent;font-family:t=
imes new roman,new york,times,serif">
This BIP details everything that needs to be done and proposes a protocol u=
pgrade.<br></div></div></div><br>------------------------------------------=
------------------------------------<br>
This <a href=3D"http://sf.net/" target=3D"_blank">SF.net</a> email is spons=
ored by Windows:<br>
<br>
Build for Windows Store.<br>
<br>
<a href=3D"http://p.sf.net/sfu/windows-dev2dev" target=3D"_blank">http://p.=
sf.net/sfu/windows-dev2dev</a><br>_________________________________________=
______<br>
Bitcoin-development mailing list<br>
<a rel=3D"nofollow" href=3D"mailto:Bitcoin-development@lists.sourceforge.ne=
t" target=3D"_blank">Bitcoin-development@lists.sourceforge.net</a><br>
<a rel=3D"nofollow" href=3D"https://lists.sourceforge.net/lists/listinfo/bi=
tcoin-development" target=3D"_blank">https://lists.sourceforge.net/lists/li=
stinfo/bitcoin-development</a><br>
<br></blockquote></div><br></div>
</div><br><br></div> </div></div></div> </div> </div></div><br>-----------=
-------------------------------------------------------------------<br>
This SF.net email is sponsored by Windows:<br>
<br>
Build for Windows Store.<br>
<br>
<a href=3D"http://p.sf.net/sfu/windows-dev2dev" target=3D"_blank">http://p.=
sf.net/sfu/windows-dev2dev</a><br>_________________________________________=
______<br>
Bitcoin-development mailing list<br>
<a href=3D"mailto:Bitcoin-development@lists.sourceforge.net">Bitcoin-develo=
pment@lists.sourceforge.net</a><br>
<a href=3D"https://lists.sourceforge.net/lists/listinfo/bitcoin-development=
" target=3D"_blank">https://lists.sourceforge.net/lists/listinfo/bitcoin-de=
velopment</a><br>
<br></blockquote></div><br></div>
--089e013c7042829e4504df7e9b9e--
|
