summaryrefslogtreecommitdiff
path: root/6f/650c31b94b9ed3ba37c364dacf88ecda989675
blob: 661963ab98f53ff81ee3a347a596201e81ae0ac2 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
Return-Path: <apoelstra@wpsoftware.net>
Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])
 by lists.linuxfoundation.org (Postfix) with ESMTP id 758E9C013B
 for <bitcoin-dev@lists.linuxfoundation.org>;
 Wed, 16 Dec 2020 17:53:13 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
 by fraxinus.osuosl.org (Postfix) with ESMTP id 6D9B384E7C
 for <bitcoin-dev@lists.linuxfoundation.org>;
 Wed, 16 Dec 2020 17:53:13 +0000 (UTC)
X-Virus-Scanned: amavisd-new at osuosl.org
Received: from fraxinus.osuosl.org ([127.0.0.1])
 by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 4MM6yko-6ycH
 for <bitcoin-dev@lists.linuxfoundation.org>;
 Wed, 16 Dec 2020 17:53:12 +0000 (UTC)
X-Greylist: delayed 00:08:59 by SQLgrey-1.7.6
Received: from mail.wpsoftware.net (wpsoftware.net [96.53.77.134])
 by fraxinus.osuosl.org (Postfix) with ESMTP id E2576848FC
 for <bitcoin-dev@lists.linuxfoundation.org>;
 Wed, 16 Dec 2020 17:53:12 +0000 (UTC)
Received: from boulet (boulot.lan [192.168.0.193])
 by mail.wpsoftware.net (Postfix) with ESMTPSA id B09504000F;
 Wed, 16 Dec 2020 17:44:12 +0000 (UTC)
Date: Wed, 16 Dec 2020 17:44:11 +0000
From: Andrew Poelstra <apoelstra@wpsoftware.net>
To: Andrew Chow <achow101-lists@achow101.com>,
 Bitcoin Protocol Discussion <bitcoin-dev@lists.linuxfoundation.org>
Message-ID: <20201216174411.GR106279@boulet>
References: <1dd8c285-e3f4-4f03-d608-103a5026146d@achow101.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="8bKSIdaynI1BetAx"
Content-Disposition: inline
In-Reply-To: <1dd8c285-e3f4-4f03-d608-103a5026146d@achow101.com>
Subject: Re: [bitcoin-dev] New PSBT version proposal
X-BeenThere: bitcoin-dev@lists.linuxfoundation.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Bitcoin Protocol Discussion <bitcoin-dev.lists.linuxfoundation.org>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/bitcoin-dev>, 
 <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/>
List-Post: <mailto:bitcoin-dev@lists.linuxfoundation.org>
List-Help: <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev>, 
 <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Dec 2020 17:53:13 -0000


--8bKSIdaynI1BetAx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 09, 2020 at 10:25:37PM +0000, Andrew Chow via bitcoin-dev wrote:
> Hi All,
>=20
> I would like to propose a new PSBT version that addresses a few=20
> deficiencies in the current PSBT v0. As this will be backwards=20
> incompatible, a new PSBT version will be used, v1.
>=20
> The primary change is to truly have all input and output data for each=20
> in their respective maps. Instead of having to parse an unsigned=20
> transaction and lookup some data from there, and other data from the=20
> correct map, all of the data for an input will be contained in its map.=
=20
> Doing so also disallows PSBT_GLOBAL_UNSIGNED_TX in this new version.=20
> Thus I propose that the following fields be added:
>=20
> Global:
> * PSBT_GLOBAL_TX_VERSION =3D 0x02
>  ?? * Key: empty
>  ?? * Value: 32-bit little endian unsigned integer for the transaction=20
> version number. Must be provided in PSBT v1 and omitted in v0.

All of these changes sound great. It would definitely make working with
PSBTs easier if all data was accessible in the same format, rather than
being split between the global unsigned tx and the main body.

One minor quibble is the version numbering -- you mention "v1" in this
post but set GLOBAL_TX_VERSION to 2. I think we should consistently use
2 everywhere; probably nobody thinks of the existing PSBT as "version 0".

--=20
Andrew Poelstra
Director of Research, Blockstream
Email: apoelstra at wpsoftware.net
Web:   https://www.wpsoftware.net/andrew

The sun is always shining in space
    -Justin Lewis-Webster


--8bKSIdaynI1BetAx
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEkPnKPD7Je+ki35VexYjWPOQbl8EFAl/aR2sACgkQxYjWPOQb
l8EscQf+I6fdEXQXIB5Y+GEU4t2cQD1t4dB2nR01BY9Bmf8+oKxe6KxI/EF7OWz1
Soquh8e1KJWaBKBwqIhMKSibWAr1kdij4bn01tB0LHnrZjdjkq17JK03BNqLLnBY
fuBt+YiANg3QakadQFEDN4Mx1s3zeIHYtGNktY9lWkk3COXJW0+7fIA3DptLUW2M
VmostzhDkGs52/Po6144wZdoc7QD00f4YDpwV6geiTanC6Opb1pk+L83xGnOMl4z
UCTHnyOwnfc/cFWEQuRsiINq1zSwu/jCDeObvlE9lGBaKYXCtp6KqZo6NuTpu0xj
XTaClum/jz1aaPNLJQsFuCjzzUevMg==
=diet
-----END PGP SIGNATURE-----

--8bKSIdaynI1BetAx--