1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
|
Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192]
helo=mx.sourceforge.net)
by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
(envelope-from <will@phase.net>) id 1UMnJa-0006gG-1R
for bitcoin-development@lists.sourceforge.net;
Mon, 01 Apr 2013 22:34:58 +0000
X-ACL-Warn:
Received: from mail-qc0-f174.google.com ([209.85.216.174])
by sog-mx-2.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128)
(Exim 4.76) id 1UMnJY-0000dy-Mq
for bitcoin-development@lists.sourceforge.net;
Mon, 01 Apr 2013 22:34:58 +0000
Received: by mail-qc0-f174.google.com with SMTP id z24so1273571qcq.5
for <bitcoin-development@lists.sourceforge.net>;
Mon, 01 Apr 2013 15:34:51 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=google.com; s=20120113;
h=x-received:mime-version:in-reply-to:references:from:date:message-id
:subject:to:cc:content-type:x-gm-message-state;
bh=Pk7K09JRMyHT4H715znlsCAAPKRFx7CaCz+6aySxHhA=;
b=hF/aRfpM5Ku6fYs93+SGHDEGCvTe+cthlm739Z8gPgnueUZKEJd0Oh+17iC4bZkRZL
7BYXJPm35ndNFQ7r8EN8s1ElG0swUqpt+BO9S+HtX+tBDg0BrjEoOQEDgvxH+o5Ssfo8
6QAJRwj1+dUgcjlbDiqYqMPz+9SU2utPsOVuSXEVPoyafZyz7pzMHoMMKGlk+ThcWJMl
hgjdRGMnHMjJ4eIWMFNpKv40D+gzccFSlfJuUEeytysaETbhdNPHlNWrYshDuUnm7vuZ
UxN6UveCkwUFgfx15o++GOFRin0nXoH9ZEvBaRuw9WDY8/h8vn59+0fp//vmWp4lnebm
m8og==
X-Received: by 10.49.87.40 with SMTP id u8mr15450968qez.62.1364854246721; Mon,
01 Apr 2013 15:10:46 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.49.14.194 with HTTP; Mon, 1 Apr 2013 15:10:26 -0700 (PDT)
In-Reply-To: <CAKaEYhK4v3mhkGMKDW9g7km+5artBAjpukQdwx17psgdJaqvgA@mail.gmail.com>
References: <CAKaEYhK5ZzP8scbhyzkEU+WdWjwMBDzkgF+SrC-Mdjgo9G9RnA@mail.gmail.com>
<CACezXZ94oDX1O7y7cgh+HvDj4QiDWmy1NVQ4Ahq=gmzhgmUaHQ@mail.gmail.com>
<CAKaEYhK4v3mhkGMKDW9g7km+5artBAjpukQdwx17psgdJaqvgA@mail.gmail.com>
From: Will <will@phase.net>
Date: Tue, 2 Apr 2013 00:10:26 +0200
Message-ID: <CAHQs=o4pKBoVO-14dqoq9EoNxq2BNnKE+zmOjLBw+XqJfAp8yA@mail.gmail.com>
To: Melvin Carvalho <melvincarvalho@gmail.com>
Content-Type: multipart/alternative; boundary=047d7bdc8b0a8be23604d953e4a5
X-Gm-Message-State: ALoCoQnXvciVBEBoYHuFADCJJARmfJr7WjNeVRocgd+FOEn66uEwTdBHzjxkxwbBI2BcrT2JHjQS
X-Spam-Score: 1.0 (+)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
See http://spamassassin.org/tag/ for more details.
1.0 HTML_MESSAGE BODY: HTML included in message
X-Headers-End: 1UMnJY-0000dy-Mq
Cc: Bitcoin Dev <bitcoin-development@lists.sourceforge.net>
Subject: Re: [Bitcoin-development] bitcoin pull requests
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Mon, 01 Apr 2013 22:34:58 -0000
--047d7bdc8b0a8be23604d953e4a5
Content-Type: text/plain; charset=ISO-8859-1
The threat of a SHA1 collision attack to insert a malicious pull request
are tiny compared with the other threats - e.g. github being compromised,
one of the core developers' passwords being compromised, one of the core
developers going rogue, sourceforge (distribution site) being compromised
etc etc... believe me there's a lot more to worry about than a SHA1
attack...
Not meaning to scare, just to put things in perspective - this is why we
all need to peer review each others commits and keep an eye out for
suspicious commits, leverage the benefits of this project being open source
and easily peer reviewed.
Will
On 1 April 2013 23:52, Melvin Carvalho <melvincarvalho@gmail.com> wrote:
>
>
>
> On 1 April 2013 20:28, Petr Praus <petr@praus.net> wrote:
>
>> An attacker would have to find a collision between two specific pieces of
>> code - his malicious code and a useful innoculous code that would be
>> accepted as pull request. This is the second, much harder case in the
>> birthday problem. When people talk about SHA-1 being broken they actually
>> mean the first case in the birthday problem - find any two arbitrary values
>> that hash to the same value. So, no I don't think it's a feasible attack
>> vector any time soon.
>>
>> Besides, with that kind of hashing power, it might be more feasible to
>> cause problems in the chain by e.g. constantly splitting it.
>>
>
> OK, maybe im being *way* too paranoid here ... but what if someone had
> access to github, could they replace one file with one they had prepared at
> some point?
>
>
>>
>>
>> On 1 April 2013 03:26, Melvin Carvalho <melvincarvalho@gmail.com> wrote:
>>
>>> I was just looking at:
>>>
>>> https://bitcointalk.org/index.php?topic=4571.0
>>>
>>> I'm just curious if there is a possible attack vector here based on the
>>> fact that git uses the relatively week SHA1
>>>
>>> Could a seemingly innocuous pull request generate another file with a
>>> backdoor/nonce combination that slips under the radar?
>>>
>>> Apologies if this has come up before ...
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Own the Future-Intel® Level Up Game Demo Contest 2013
>>> Rise to greatness in Intel's independent game demo contest.
>>> Compete for recognition, cash, and the chance to get your game
>>> on Steam. $5K grand prize plus 10 genre and skill prizes.
>>> Submit your demo by 6/6/13. http://p.sf.net/sfu/intel_levelupd2d
>>> _______________________________________________
>>> Bitcoin-development mailing list
>>> Bitcoin-development@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/bitcoin-development
>>>
>>>
>>
>
>
> ------------------------------------------------------------------------------
> Own the Future-Intel® Level Up Game Demo Contest 2013
> Rise to greatness in Intel's independent game demo contest.
> Compete for recognition, cash, and the chance to get your game
> on Steam. $5K grand prize plus 10 genre and skill prizes.
> Submit your demo by 6/6/13. http://p.sf.net/sfu/intel_levelupd2d
> _______________________________________________
> Bitcoin-development mailing list
> Bitcoin-development@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/bitcoin-development
>
>
--047d7bdc8b0a8be23604d953e4a5
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr">The threat of a SHA1 collision attack to insert a maliciou=
s pull request are tiny compared with the other threats - e.g. github being=
compromised, one of the core developers' passwords being compromised, =
one of the core developers going rogue, sourceforge (distribution site) bei=
ng compromised etc etc... believe me there's a lot more to worry about =
than a SHA1 attack...<div>
<br></div><div style>Not meaning to scare, just to put things in perspectiv=
e - this is why we all need to peer review each others commits and keep an =
eye out for suspicious commits, leverage the benefits of this project being=
open source and easily peer reviewed.</div>
<div style><br></div><div>Will</div></div><div class=3D"gmail_extra"><br><b=
r><div class=3D"gmail_quote">On 1 April 2013 23:52, Melvin Carvalho <span d=
ir=3D"ltr"><<a href=3D"mailto:melvincarvalho@gmail.com" target=3D"_blank=
">melvincarvalho@gmail.com</a>></span> wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex"><div dir=3D"ltr"><br><div class=3D"gmail_ext=
ra"><br><br><div class=3D"gmail_quote"><div class=3D"im">On 1 April 2013 20=
:28, Petr Praus <span dir=3D"ltr"><<a href=3D"mailto:petr@praus.net" tar=
get=3D"_blank">petr@praus.net</a>></span> wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">
<div dir=3D"ltr">An attacker would have to find a collision between two spe=
cific pieces of code - his malicious code and a useful innoculous code that=
would be accepted as pull request. This is the second, much harder case in=
the birthday problem. When people talk about SHA-1 being broken they actua=
lly mean the first case in the birthday problem - find any two arbitrary va=
lues that hash to the same value. So, no I don't think it's a feasi=
ble attack vector any time soon.<div>
<br></div><div>Besides, with that kind of hashing power, it might be more f=
easible to cause problems in the chain by e.g. constantly splitting it.</di=
v></div></blockquote><div><br></div></div><div>OK, maybe im being *way* too=
paranoid here ... but what if someone had access to github, could they rep=
lace one file with one they had prepared at some point?<br>
</div><div class=3D"im"><div>=A0</div><blockquote class=3D"gmail_quote" sty=
le=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div c=
lass=3D"gmail_extra"><br><br><div class=3D"gmail_quote"><div><div>
On 1 April 2013 03:26, Melvin Carvalho <span dir=3D"ltr"><<a href=3D"mai=
lto:melvincarvalho@gmail.com" target=3D"_blank">melvincarvalho@gmail.com</a=
>></span> wrote:<br></div></div><blockquote class=3D"gmail_quote" style=
=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div>
<div dir=3D"ltr"><div><div><div>I was just looking at:<br><br><a href=3D"ht=
tps://bitcointalk.org/index.php?topic=3D4571.0" target=3D"_blank">https://b=
itcointalk.org/index.php?topic=3D4571.0</a><br><br></div>I'm just curio=
us if there is a possible attack vector here based on the fact that git use=
s the relatively week SHA1<br>
<br></div>Could a seemingly innocuous pull request generate another file wi=
th a backdoor/nonce combination that slips under the radar?<br><br></div>Ap=
ologies if this has come up before ...<br></div>
<br></div></div>-----------------------------------------------------------=
-------------------<br>
Own the Future-Intel&reg; Level Up Game Demo Contest 2013<br>
Rise to greatness in Intel's independent game demo contest.<br>
Compete for recognition, cash, and the chance to get your game<br>
on Steam. $5K grand prize plus 10 genre and skill prizes.<br>
Submit your demo by 6/6/13. <a href=3D"http://p.sf.net/sfu/intel_levelupd2d=
" target=3D"_blank">http://p.sf.net/sfu/intel_levelupd2d</a><br>___________=
____________________________________<br>
Bitcoin-development mailing list<br>
<a href=3D"mailto:Bitcoin-development@lists.sourceforge.net" target=3D"_bla=
nk">Bitcoin-development@lists.sourceforge.net</a><br>
<a href=3D"https://lists.sourceforge.net/lists/listinfo/bitcoin-development=
" target=3D"_blank">https://lists.sourceforge.net/lists/listinfo/bitcoin-de=
velopment</a><br>
<br></blockquote></div><br></div>
</blockquote></div></div><br></div></div>
<br>-----------------------------------------------------------------------=
-------<br>
Own the Future-Intel&reg; Level Up Game Demo Contest 2013<br>
Rise to greatness in Intel's independent game demo contest.<br>
Compete for recognition, cash, and the chance to get your game<br>
on Steam. $5K grand prize plus 10 genre and skill prizes.<br>
Submit your demo by 6/6/13. <a href=3D"http://p.sf.net/sfu/intel_levelupd2d=
" target=3D"_blank">http://p.sf.net/sfu/intel_levelupd2d</a><br>___________=
____________________________________<br>
Bitcoin-development mailing list<br>
<a href=3D"mailto:Bitcoin-development@lists.sourceforge.net">Bitcoin-develo=
pment@lists.sourceforge.net</a><br>
<a href=3D"https://lists.sourceforge.net/lists/listinfo/bitcoin-development=
" target=3D"_blank">https://lists.sourceforge.net/lists/listinfo/bitcoin-de=
velopment</a><br>
<br></blockquote></div><br></div>
--047d7bdc8b0a8be23604d953e4a5--
|
