summaryrefslogtreecommitdiff
path: root/68/e8be4cd24b8e66bd249395f60745731e0a3421
blob: 1a442365eccf5f22bfe4405bd2ffe61c66c4f935 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193]
	helo=mx.sourceforge.net)
	by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
	(envelope-from <gavinandresen@gmail.com>) id 1Vb1zS-0006bY-W3
	for bitcoin-development@lists.sourceforge.net;
	Tue, 29 Oct 2013 05:37:19 +0000
Received-SPF: pass (sog-mx-3.v43.ch3.sourceforge.com: domain of gmail.com
	designates 209.85.212.176 as permitted sender)
	client-ip=209.85.212.176; envelope-from=gavinandresen@gmail.com;
	helo=mail-wi0-f176.google.com; 
Received: from mail-wi0-f176.google.com ([209.85.212.176])
	by sog-mx-3.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128)
	(Exim 4.76) id 1Vb1zS-0001dw-5B
	for bitcoin-development@lists.sourceforge.net;
	Tue, 29 Oct 2013 05:37:18 +0000
Received: by mail-wi0-f176.google.com with SMTP id ex4so2262456wid.9
	for <bitcoin-development@lists.sourceforge.net>;
	Mon, 28 Oct 2013 22:37:12 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.180.101.134 with SMTP id fg6mr11955340wib.9.1383025031947;
	Mon, 28 Oct 2013 22:37:11 -0700 (PDT)
Received: by 10.194.156.163 with HTTP; Mon, 28 Oct 2013 22:37:11 -0700 (PDT)
In-Reply-To: <CAAS2fgSuL4f9Sdg2CyK-EuCKK04gD98zHDoKFyTg_Fp_cNiz=A@mail.gmail.com>
References: <274a1888-276c-4aa6-a818-68f548fbe0fa@me.com>
	<9DCDB8F6-E3B2-426B-A41E-087E66B3821A@gmail.com>
	<526B45DB.2030200@jerviss.org>
	<CABsx9T2OMA_u=S9yUh2j78QDuCDUorYctktuixjwAjqc6neW=Q@mail.gmail.com>
	<526DD18A.7060201@jerviss.org> <l4lajm$3ga$1@ger.gmane.org>
	<CAAS2fgSuL4f9Sdg2CyK-EuCKK04gD98zHDoKFyTg_Fp_cNiz=A@mail.gmail.com>
Date: Tue, 29 Oct 2013 15:37:11 +1000
Message-ID: <CABsx9T3p6KFc8FiOgBwLtQsmkETE_iUbMhO47pS7J3hi3a9_4w@mail.gmail.com>
From: Gavin Andresen <gavinandresen@gmail.com>
To: Gregory Maxwell <gmaxwell@gmail.com>
Content-Type: multipart/alternative; boundary=f46d04462e56beaf4404e9da9b0b
X-Spam-Score: -0.6 (/)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
	See http://spamassassin.org/tag/ for more details.
	0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked.
	See
	http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
	for more information. [URIs: github.com]
	-1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for
	sender-domain
	0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider
	(gavinandresen[at]gmail.com)
	-0.0 SPF_PASS               SPF: sender matches SPF record
	1.0 HTML_MESSAGE           BODY: HTML included in message
	-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from
	author's domain
	0.1 DKIM_SIGNED            Message has a DKIM or DK signature,
	not necessarily valid
	-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
X-Headers-End: 1Vb1zS-0001dw-5B
Cc: Bitcoin Development <bitcoin-development@lists.sourceforge.net>,
	Andreas Schildbach <andreas@schildbach.de>
Subject: Re: [Bitcoin-development] Feedback requested: "reject" p2p message
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
	<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
	<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Tue, 29 Oct 2013 05:37:19 -0000

--f46d04462e56beaf4404e9da9b0b
Content-Type: text/plain; charset=ISO-8859-1

Thanks for the feedback, everybody, gist updated:
  https://gist.github.com/gavinandresen/7079034

Categories are:

0x01-0x0fProtocol syntax errors0x10-0x1fProtocol semantic errors0x40-0x4fServer
policy rule
<https://gist.github.com/gavinandresen/7079034#rejection-codes-common-to-all-message-types>

RE: why not a varint:  because we're never ever going to run out of reject
codes.  Eight are defined right now, if we ever defined eight more I'd be
surprised.

RE: why not use HTTP codes directly: because we'd be fitting round pegs
into square holes.

-- 
--
Gavin Andresen

--f46d04462e56beaf4404e9da9b0b
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div><br></div>Thanks for the feedback, everybody, gist up=
dated:<div>=A0=A0<a href=3D"https://gist.github.com/gavinandresen/7079034">=
https://gist.github.com/gavinandresen/7079034</a></div><div><br></div><div>=
Categories are:</div>
<div><br></div><div><table style=3D"border-collapse:collapse;border-spacing=
:0px;font-size:15px;margin:15px 0px;width:724px;overflow:auto;display:block=
;color:rgb(0,0,0);font-family:Helvetica,arial,freesans,clean,sans-serif;lin=
e-height:25px">
<tbody><tr style=3D"border-top-width:1px;border-top-style:solid;border-top-=
color:rgb(204,204,204);background-color:rgb(248,248,248)"><td style=3D"bord=
er:1px solid rgb(221,221,221);padding:6px 13px">0x01-0x0f</td><td style=3D"=
border:1px solid rgb(221,221,221);padding:6px 13px">
Protocol syntax errors</td></tr><tr style=3D"border-top-width:1px;border-to=
p-style:solid;border-top-color:rgb(204,204,204)"><td style=3D"border:1px so=
lid rgb(221,221,221);padding:6px 13px">0x10-0x1f</td><td style=3D"border:1p=
x solid rgb(221,221,221);padding:6px 13px">
Protocol semantic errors</td></tr><tr style=3D"border-top-width:1px;border-=
top-style:solid;border-top-color:rgb(204,204,204);background-color:rgb(248,=
248,248)"><td style=3D"border:1px solid rgb(221,221,221);padding:6px 13px">
0x40-0x4f</td><td style=3D"border:1px solid rgb(221,221,221);padding:6px 13=
px">Server policy rule<br></td></tr></tbody></table><h4 style=3D"margin:1em=
 0px 15px;padding:0px;line-height:1.7;font-size:1.2em;color:rgb(0,0,0);font=
-family:Helvetica,arial,freesans,clean,sans-serif">
<a name=3D"rejection-codes-common-to-all-message-types" class=3D"" href=3D"=
https://gist.github.com/gavinandresen/7079034#rejection-codes-common-to-all=
-message-types" style=3D"color:rgb(65,131,196);text-decoration:none;display=
:block;padding-left:30px"><span class=3D""></span></a></h4>
</div><div class=3D"gmail_extra"><br></div><div class=3D"gmail_extra">RE: w=
hy not a varint: =A0because we&#39;re never ever going to run out of reject=
 codes. =A0Eight are defined right now, if we ever defined eight more I&#39=
;d be surprised.</div>
<div class=3D"gmail_extra"><br></div><div class=3D"gmail_extra">RE: why not=
 use HTTP codes directly: because we&#39;d be fitting round pegs into squar=
e holes.<br><br>-- <br>--<br>Gavin Andresen<br>
</div></div>

--f46d04462e56beaf4404e9da9b0b--