summaryrefslogtreecommitdiff
path: root/62/7c77633d9df3384c3642a1569973a806107bca
blob: e8c1436ec0eae51781520c9b56798c37167689ec (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
Return-Path: <lf-lists@mattcorallo.com>
Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])
 by lists.linuxfoundation.org (Postfix) with ESMTP id 9C0B9C013A
 for <bitcoin-dev@lists.linuxfoundation.org>;
 Thu, 14 Jan 2021 05:39:20 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
 by silver.osuosl.org (Postfix) with ESMTP id 814A82047B
 for <bitcoin-dev@lists.linuxfoundation.org>;
 Thu, 14 Jan 2021 05:39:20 +0000 (UTC)
X-Virus-Scanned: amavisd-new at osuosl.org
Received: from silver.osuosl.org ([127.0.0.1])
 by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id zrCeY9HWz0vu
 for <bitcoin-dev@lists.linuxfoundation.org>;
 Thu, 14 Jan 2021 05:39:19 +0000 (UTC)
X-Greylist: from auto-whitelisted by SQLgrey-1.7.6
Received: from mail.as397444.net (mail.as397444.net [69.59.18.99])
 by silver.osuosl.org (Postfix) with ESMTPS id 878AC2046C
 for <bitcoin-dev@lists.linuxfoundation.org>;
 Thu, 14 Jan 2021 05:39:19 +0000 (UTC)
Received: by mail.as397444.net (Postfix) with ESMTPSA id 88594445751;
 Thu, 14 Jan 2021 05:39:17 +0000 (UTC)
X-DKIM-Note: Keys used to sign are likely public at https://as397444.net/dkim/
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mattcorallo.com;
 s=1610600463; t=1610602757;
 bh=UAoYIfsv3553/E1Kd0pk232blcVU6b/ssPmj0VpzxVg=;
 h=From:Subject:Date:References:Cc:In-Reply-To:To:From;
 b=Zi6pfaAhkKU6ne1zDani8S3DfswngjZM4yOXdA97VSKehuJz2X8IQveOYgVwvyMb5
 cwGLaWp9Bt5tFWVyw9/C6ztV4AcrNGb4cdRfxScW1hWkljoqxgQ2DAtmGlmYlXxTB9
 P0tDyzNoOa0bcpwG+TFCH7vaqesnLZ0bocFPbBDL9sV2w8HvxG3pSAZA7v04+Pcbl2
 lJWDxErRMm5HjcFAIY7lEq0I97mQOALrpUYYRCI5FN30WBY8mT968jzFcTQtHua49Y
 r5qN3MHn5M0DyieiurKKV1a7sioQ9nxctiGzs+efpGA2ysVZeT22GJeuS3m1Q3Lmgt
 j7t6MP8njRQsw==
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: Matt Corallo <lf-lists@mattcorallo.com>
Mime-Version: 1.0 (1.0)
Date: Thu, 14 Jan 2021 00:39:16 -0500
Message-Id: <DDE19B4D-9272-4645-8016-BDC377902751@mattcorallo.com>
References: <20210114053257.4ctg3qdvo7s44s72@erisian.com.au>
In-Reply-To: <20210114053257.4ctg3qdvo7s44s72@erisian.com.au>
To: Anthony Towns <aj@erisian.com.au>
Cc: Bitcoin Protocol Discussion <bitcoin-dev@lists.linuxfoundation.org>
Subject: Re: [bitcoin-dev] Proposal for new "disabletx" p2p message
X-BeenThere: bitcoin-dev@lists.linuxfoundation.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Bitcoin Protocol Discussion <bitcoin-dev.lists.linuxfoundation.org>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/bitcoin-dev>, 
 <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/>
List-Post: <mailto:bitcoin-dev@lists.linuxfoundation.org>
List-Help: <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev>, 
 <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jan 2021 05:39:20 -0000

So we=E2=80=99d kill two birds with one stone if all bloom support was dropp=
ed. As far as I understand, precomputed filters are now provided via p2p con=
nections as well.

Matt

> On Jan 14, 2021, at 00:33, Anthony Towns <aj@erisian.com.au> wrote:
>=20
> =EF=BB=BFOn Wed, Jan 13, 2021 at 01:40:03AM -0500, Matt Corallo via bitcoi=
n-dev wrote:
>> Out of curiosity, was the interaction between fRelay and bloom disabling e=
ver
>> specified? ie if you aren=E2=80=99t allowed to enable bloom filters on a c=
onnection due
>> to resource constraints/new limits, is it ever possible to =E2=80=9Cset=E2=
=80=9D fRelay later?
>=20
> (Maybe I'm missing something, but...)
>=20
> In the current bitcoin implementation, no -- you either set
> m_tx_relay->fRelayTxes to true via the VERSION message (either explicitly
> or by not setting fRelay), or you enable it later with FILTERLOAD or
> FILTERCLEAR, both of which will cause a disconnect if bloom filters
> aren't supported. Bloom filter support is (optionally?) indicated via
> a service bit (BIP 111), so you could assume you know whether they're
> supported as soon as you receive the VERSION line.
>=20
> fRelay is specified in BIP 37 as:
>=20
>  | 1 byte || fRelay || bool || If false then broadcast transactions will
>  not be announced until a filter{load,add,clear} command is received. If
>  missing or true, no change in protocol behaviour occurs.
>=20
> BIP 60 defines the field as "relay" and references BIP 37. Don't think
> it's referenced in any other bips.
>=20
> Cheers,
> aj
>=20