1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
|
Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192]
helo=mx.sourceforge.net)
by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
(envelope-from <mh.in.england@gmail.com>) id 1UpZQF-0000xO-Ci
for bitcoin-development@lists.sourceforge.net;
Thu, 20 Jun 2013 07:36:47 +0000
Received-SPF: pass (sog-mx-2.v43.ch3.sourceforge.com: domain of gmail.com
designates 209.85.214.171 as permitted sender)
client-ip=209.85.214.171; envelope-from=mh.in.england@gmail.com;
helo=mail-ob0-f171.google.com;
Received: from mail-ob0-f171.google.com ([209.85.214.171])
by sog-mx-2.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128)
(Exim 4.76) id 1UpZQE-0000oT-BC
for bitcoin-development@lists.sourceforge.net;
Thu, 20 Jun 2013 07:36:47 +0000
Received: by mail-ob0-f171.google.com with SMTP id dn14so6891725obc.30
for <bitcoin-development@lists.sourceforge.net>;
Thu, 20 Jun 2013 00:36:41 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.182.215.133 with SMTP id oi5mr978701obc.83.1371713800875;
Thu, 20 Jun 2013 00:36:40 -0700 (PDT)
Sender: mh.in.england@gmail.com
Received: by 10.76.23.36 with HTTP; Thu, 20 Jun 2013 00:36:40 -0700 (PDT)
In-Reply-To: <4DE0E45E-BB48-4DFF-9C86-ACBE312B3049@bitsofproof.com>
References: <4DE0E45E-BB48-4DFF-9C86-ACBE312B3049@bitsofproof.com>
Date: Thu, 20 Jun 2013 09:36:40 +0200
X-Google-Sender-Auth: 1Y-hWUGdWNhuEKvPpMcGlNS1TjE
Message-ID: <CANEZrP1MVKSNU92UrQ36sPCN0LNLKrVRXnfVwEZKhgoBFXatBA@mail.gmail.com>
From: Mike Hearn <mike@plan99.net>
To: Tamas Blummer <tamas@bitsofproof.com>
Content-Type: multipart/alternative; boundary=001a11c25434d5bbee04df9101d8
X-Spam-Score: -0.5 (/)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
See http://spamassassin.org/tag/ for more details.
-1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for
sender-domain
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider
(mh.in.england[at]gmail.com)
-0.0 SPF_PASS SPF: sender matches SPF record
1.0 HTML_MESSAGE BODY: HTML included in message
0.1 DKIM_SIGNED Message has a DKIM or DK signature,
not necessarily valid
-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
X-Headers-End: 1UpZQE-0000oT-BC
Cc: Bitcoin Dev <bitcoin-development@lists.sourceforge.net>
Subject: Re: [Bitcoin-development] Missing fRelayTxes in version
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Thu, 20 Jun 2013 07:36:47 -0000
--001a11c25434d5bbee04df9101d8
Content-Type: text/plain; charset=UTF-8
Sure but why not do that when there's an actual new field to add? Does
anyone have a proposal for a feature that needs a new version field at the
moment? There's no point changing the protocol now unless there's actually
a new field to add.
Anyway I still don't see why anyone cares about this issue. The Bitcoin
protocol does not and never has required that all messages have a fixed
number of fields per version. Any parser written on the assumption it did
was just buggy. Look at how tx messages are relayed for the most obvious
example of that pattern in action - it's actually the raw byte stream
that's stored and relayed to ensure that fields added in new versions
aren't dropped during round-tripping. Old versions are supposed to preserve
fields from the future.
On Thu, Jun 20, 2013 at 9:30 AM, Tamas Blummer <tamas@bitsofproof.com>wrote:
> Hi Mike,
>
> The issue with the current parser is that those fields are conditionally
> optional on that there will be no subsequent fields added.
> If there will be further fields they will become manadory.
>
> Why not bump the version and parse the fields as mandatory from then on?
> This would be backward compatible and cleaner
> going forward.
>
> Tamas Blummer
> http://bitsofproof.com
> <http://bitsofproof.com/>
>
>
>
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by Windows:
>
> Build for Windows Store.
>
> http://p.sf.net/sfu/windows-dev2dev
> _______________________________________________
> Bitcoin-development mailing list
> Bitcoin-development@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/bitcoin-development
>
>
--001a11c25434d5bbee04df9101d8
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr">Sure but why not do that when there's an actual new fi=
eld to add? Does anyone have a proposal for a feature that needs a new vers=
ion field at the moment? There's no point changing the protocol now unl=
ess there's actually a new field to add.<div>
<br></div><div style>Anyway I still don't see why anyone cares about th=
is issue. The Bitcoin protocol does not and never has required that all mes=
sages have a fixed number of fields per version. Any parser written on the =
assumption it did was just buggy. Look at how tx messages are relayed for t=
he most obvious example of that pattern in action - it's actually the r=
aw byte stream that's stored and relayed to ensure that fields added in=
new versions aren't dropped during round-tripping. Old versions are su=
pposed to preserve fields from the future.</div>
<div style><br></div></div><div class=3D"gmail_extra"><br><br><div class=3D=
"gmail_quote">On Thu, Jun 20, 2013 at 9:30 AM, Tamas Blummer <span dir=3D"l=
tr"><<a href=3D"mailto:tamas@bitsofproof.com" target=3D"_blank">tamas@bi=
tsofproof.com</a>></span> wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex"><div style=3D"word-wrap:break-word"><div><di=
v style=3D"text-indent:0px;letter-spacing:normal;font-variant:normal;text-a=
lign:-webkit-auto;font-style:normal;font-weight:normal;line-height:normal;t=
ext-transform:none;font-size:medium;white-space:normal;font-family:Helvetic=
a;word-spacing:0px">
<div style=3D"text-indent:0px;letter-spacing:normal;font-variant:normal;tex=
t-align:left;font-style:normal;font-weight:normal;line-height:normal;text-t=
ransform:none;font-size:medium;white-space:normal;font-family:Helvetica;wor=
d-spacing:0px">
Hi Mike,</div><div style=3D"text-indent:0px;letter-spacing:normal;font-vari=
ant:normal;text-align:left;font-style:normal;font-weight:normal;line-height=
:normal;text-transform:none;font-size:medium;white-space:normal;font-family=
:Helvetica;word-spacing:0px">
<br></div><div style=3D"text-indent:0px;letter-spacing:normal;font-variant:=
normal;text-align:left;font-style:normal;font-weight:normal;line-height:nor=
mal;text-transform:none;font-size:medium;white-space:normal;font-family:Hel=
vetica;word-spacing:0px">
The issue with the current parser is that those fields are conditionally op=
tional on that there will be no subsequent fields added.</div><div style=3D=
"text-indent:0px;letter-spacing:normal;font-variant:normal;text-align:left;=
font-style:normal;font-weight:normal;line-height:normal;text-transform:none=
;font-size:medium;white-space:normal;font-family:Helvetica;word-spacing:0px=
">
If there will be further fields they will become manadory.=C2=A0</div><div =
style=3D"text-indent:0px;letter-spacing:normal;font-variant:normal;text-ali=
gn:left;font-style:normal;font-weight:normal;line-height:normal;text-transf=
orm:none;font-size:medium;white-space:normal;font-family:Helvetica;word-spa=
cing:0px">
=C2=A0</div><div style=3D"text-indent:0px;letter-spacing:normal;font-varian=
t:normal;text-align:left;font-style:normal;font-weight:normal;line-height:n=
ormal;text-transform:none;font-size:medium;white-space:normal;font-family:H=
elvetica;word-spacing:0px">
Why not bump the version and parse the fields as mandatory=C2=A0from then o=
n? This would be backward compatible and cleaner</div><div style=3D"text-in=
dent:0px;letter-spacing:normal;font-variant:normal;text-align:left;font-sty=
le:normal;font-weight:normal;line-height:normal;text-transform:none;font-si=
ze:medium;white-space:normal;font-family:Helvetica;word-spacing:0px">
going forward.</div><span class=3D"HOEnZb"><font color=3D"#888888"><div sty=
le=3D"text-indent:0px;letter-spacing:normal;font-variant:normal;text-align:=
left;font-style:normal;font-weight:normal;line-height:normal;text-transform=
:none;font-size:medium;white-space:normal;font-family:Helvetica;word-spacin=
g:0px">
<br></div><div style=3D"text-indent:0px;letter-spacing:normal;font-variant:=
normal;text-align:-webkit-auto;font-style:normal;font-weight:normal;line-he=
ight:normal;text-transform:none;font-size:medium;white-space:normal;font-fa=
mily:Helvetica;word-spacing:0px">
<span>Tamas Blummer</span></div><div style=3D"text-indent:0px;letter-spacin=
g:normal;font-variant:normal;text-align:-webkit-auto;font-style:normal;font=
-weight:normal;line-height:normal;text-transform:none;font-size:medium;whit=
e-space:normal;font-family:Helvetica;word-spacing:0px">
<span><span style><a href=3D"http://bitsofproof.com/" target=3D"_blank">htt=
p://bitsofproof.com</a></span></span></div></font></span></div><a href=3D"h=
ttp://bitsofproof.com/" style=3D"font-family:Helvetica;font-size:medium;fon=
t-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal=
;line-height:normal;text-align:-webkit-auto;text-indent:0px;text-transform:=
none;white-space:normal;word-spacing:0px" target=3D"_blank">
</a></div><br></div><br>---------------------------------------------------=
---------------------------<br>
This SF.net email is sponsored by Windows:<br>
<br>
Build for Windows Store.<br>
<br>
<a href=3D"http://p.sf.net/sfu/windows-dev2dev" target=3D"_blank">http://p.=
sf.net/sfu/windows-dev2dev</a><br>_________________________________________=
______<br>
Bitcoin-development mailing list<br>
<a href=3D"mailto:Bitcoin-development@lists.sourceforge.net">Bitcoin-develo=
pment@lists.sourceforge.net</a><br>
<a href=3D"https://lists.sourceforge.net/lists/listinfo/bitcoin-development=
" target=3D"_blank">https://lists.sourceforge.net/lists/listinfo/bitcoin-de=
velopment</a><br>
<br></blockquote></div><br></div>
--001a11c25434d5bbee04df9101d8--
|
