summaryrefslogtreecommitdiff
path: root/50/29fa0077eb64b6073d55664b9d5db745bf1f88
blob: 2e1fa73d4aeb9a528fc01446000e89107eb6e7d3 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
Return-Path: <eric@voskuil.org>
Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org
	[172.17.192.35])
	by mail.linuxfoundation.org (Postfix) with ESMTPS id CA960BDC
	for <bitcoin-dev@lists.linuxfoundation.org>;
	Thu, 17 Oct 2019 20:16:50 +0000 (UTC)
X-Greylist: whitelisted by SQLgrey-1.7.6
Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com
	[209.85.214.170])
	by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 682B16C5
	for <bitcoin-dev@lists.linuxfoundation.org>;
	Thu, 17 Oct 2019 20:16:50 +0000 (UTC)
Received: by mail-pl1-f170.google.com with SMTP id u12so1653942pls.12
	for <bitcoin-dev@lists.linuxfoundation.org>;
	Thu, 17 Oct 2019 13:16:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=voskuil-org.20150623.gappssmtp.com; s=20150623;
	h=content-transfer-encoding:from:mime-version:date:subject:message-id
	:references:in-reply-to:to;
	bh=tFDbjabAffOgLhu+MRvOAB/aM2zwePLYEYQVj02PPKQ=;
	b=d6DNifUCrrDc3nmsYtlJK4GUBBeJJ+m3T3hQ67U2f+BQWA0/PfulJ54s8Tr0VizWWP
	Rb1yV6Z3aamPfF4BfM1I0LSdUT9DGNiR0nZlpbSCsJIsTJvsQPi0ppBhQQid8jy1Snw6
	IV6LCQ9Rx+HyJy71pKN6tfizoLTLM1GG8Mm2lFmAB4SWpcjronp8A6xk8iLuf6Iwbqym
	hN43TnA+Ai+FGWIk1tgfoBeo0Y0p5z6mBV9H78cvG9SszNcaLQ1QkcmtRResRDAHlqlP
	8sK7HH2UiBb4yziBF3Ua920nsP652h1hQMJmPW8A88n6PB1ufKZoEFVnGhOmX8p1lGFw
	PjmA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20161025;
	h=x-gm-message-state:content-transfer-encoding:from:mime-version:date
	:subject:message-id:references:in-reply-to:to;
	bh=tFDbjabAffOgLhu+MRvOAB/aM2zwePLYEYQVj02PPKQ=;
	b=LZyYLVn6fk+KtFEZl60HNcvHJ4ICjZhyCcJyyB1Aq0aChUYN4xByXuFq+o6/oPSFDF
	j8Tv09DeIeEud6ISBzPoIke0YoS/rNpL3yHYmJ68FGMRFdeld3/MKC60fQJyk4XstXGP
	0GSFIMHEFsjr6FNn1L8hQWItOJHeo1o9mzBJsC1Q8FBH82S3zX9dLehhYYvSdMgzPKJm
	XyPS4QzcINX+KROUDpgg4EbqNIrBTVDZrnZ+JlvLLyh+cvX45HBfi6fjdbGjpP7arbSh
	W7esbl32odpVcYp/JYxUk6C896R94F+HhPUzxlB/R38FxmGb+IPAZAJxW2at4dLJWNOy
	1dCg==
X-Gm-Message-State: APjAAAVXhRIOcmvfoHTHDkVjn5p6rkbJVDVtxzV6NCeaKajY1WfDZXjY
	c2lHRN6NWT7s9jeYzUI7XL69vXFRNsk=
X-Google-Smtp-Source: APXvYqxjTFCWrOnxVWX11EmaofivE9bYTrNqTHcCHYgtyRlwCAufDbw/I9uE/LbKEOHxM8ZpqDtx1g==
X-Received: by 2002:a17:902:b48c:: with SMTP id
	y12mr6037560plr.38.1571343409811; 
	Thu, 17 Oct 2019 13:16:49 -0700 (PDT)
Received: from ?IPv6:2600:380:8560:bc27:2d74:1b23:773d:eeeb?
	([2600:380:8560:bc27:2d74:1b23:773d:eeeb])
	by smtp.gmail.com with ESMTPSA id
	202sm3729574pfu.161.2019.10.17.13.16.49
	(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
	Thu, 17 Oct 2019 13:16:49 -0700 (PDT)
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: Eric Voskuil <eric@voskuil.org>
Mime-Version: 1.0 (1.0)
Date: Thu, 17 Oct 2019 13:16:47 -0700
Message-Id: <5C03EE5A-B29E-44BC-903F-7094E504580D@voskuil.org>
References: <qoag0d$65ad$1@blaine.gmane.org>
In-Reply-To: <qoag0d$65ad$1@blaine.gmane.org>
To: Andreas Schildbach <andreas@schildbach.de>,
	Bitcoin Protocol Discussion <bitcoin-dev@lists.linuxfoundation.org>
X-Mailer: iPhone Mail (17A860)
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID, MIME_QP_LONG_LINE,
	RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
	smtp1.linux-foundation.org
X-Mailman-Approved-At: Fri, 18 Oct 2019 21:32:45 +0000
Subject: Re: [bitcoin-dev] Removal of reject network messages from Bitcoin
	Core (BIP61)
X-BeenThere: bitcoin-dev@lists.linuxfoundation.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Bitcoin Protocol Discussion <bitcoin-dev.lists.linuxfoundation.org>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/bitcoin-dev>,
	<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/>
List-Post: <mailto:bitcoin-dev@lists.linuxfoundation.org>
List-Help: <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev>,
	<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Oct 2019 20:16:50 -0000

As this is a P2P protocol change it should be exposed as a version increment=
 (and a BIP), not just as a conditional service. If the intent is to retain t=
his protocol indefinitely, exposing it conditionally, then a service bit wou=
ld make sense, but it remains a protocol change.

BIP61 is explicit:

=E2=80=9CAll implementations of the P2P protocol version 70,002 and later sh=
ould support the reject message.=E2=80=9C

e

> On Oct 17, 2019, at 12:54, Andreas Schildbach via bitcoin-dev <bitcoin-dev=
@lists.linuxfoundation.org> wrote:
>=20
> =EF=BB=BFOn 16/10/2019 18.43, John Newbery via bitcoin-dev wrote:
>=20
>> Following discussion on this mailing list, support for BIP 61 REJECT
>> messages was not removed from Bitcoin Core in V0.19. The behaviour in
>> that upcoming release is that REJECT messages are disabled by default
>> and can be enabled using the `-enablebip61` command line option.
>=20
> Is there a NODE_* bit we can use to pick peers that support this
> (useful!) feature?
>=20
>=20
> _______________________________________________
> bitcoin-dev mailing list
> bitcoin-dev@lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev