summaryrefslogtreecommitdiff
path: root/4f/dc212175c000aa98211e19f1eb9407b79eb992
blob: 9a1c13549b3b621d6ae8bfbfd53a3e9adc6f52bd (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
Return-Path: <marek@palatinus.cz>
Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org
	[172.17.192.35])
	by mail.linuxfoundation.org (Postfix) with ESMTPS id 4EA93CB8
	for <bitcoin-dev@lists.linuxfoundation.org>;
	Tue, 26 Jun 2018 17:11:48 +0000 (UTC)
X-Greylist: whitelisted by SQLgrey-1.7.6
Received: from mail-vk0-f50.google.com (mail-vk0-f50.google.com
	[209.85.213.50])
	by smtp1.linuxfoundation.org (Postfix) with ESMTPS id C66C717E
	for <bitcoin-dev@lists.linuxfoundation.org>;
	Tue, 26 Jun 2018 17:11:47 +0000 (UTC)
Received: by mail-vk0-f50.google.com with SMTP id f200-v6so3147460vke.0
	for <bitcoin-dev@lists.linuxfoundation.org>;
	Tue, 26 Jun 2018 10:11:47 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=palatinus-cz.20150623.gappssmtp.com; s=20150623;
	h=mime-version:in-reply-to:references:from:date:message-id:subject:to
	:cc; bh=9tOQaOKwfk8t6rGUtPCC9p8xZNhGSxYLvYiiBP/xvuw=;
	b=P8tZhCJ4S9KoN8dIjFCkM0ggnZNSp6d2v0PbtMdAH+l2H8M6xfVAbMLv6lkASIpOKf
	dJOmOJxhXehfA9SG+G2fS+azzr2Hrtp98wEoLW64AHmfz9Qd4NS/pCJ7seFSAEblrPFd
	Me1HoKbtbhE2W/482PX1ssNvoOAu2tCg51X2pxhZuY905huQWfbur9rAgjye9Lp2TAi1
	DWu2jBHniUCiGTJ/eWydRLUj5FHuGQJ24e1/0Y0xlzURYuffnj8Bg51k2xhDcrMWEa10
	hoZrrib+nSIwdsJJcE+C8CPeFeuTIbYHomUd31tCN/P2Hdu9ithwg8dCLFWT1iZLcquC
	fWBA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20161025;
	h=x-gm-message-state:mime-version:in-reply-to:references:from:date
	:message-id:subject:to:cc;
	bh=9tOQaOKwfk8t6rGUtPCC9p8xZNhGSxYLvYiiBP/xvuw=;
	b=Ba9y1pt+ced0/74/QPHcKrHkiIwi+aRC7pBItRNrBIAqQ22Cte017k7vy7nI2scCst
	Ijo54sgFJRdzc+/olKf0WbM0GW3qCOkh2/QFqKDF71q1UYQC1fZKVCjHWXi7LjsXGkTU
	XsvJx+r9Z1YhW3bcqG5wlExRioEo3rNiLTYu+1qmry0hVzoQaSZYRtN17HFAQ+GWBcCx
	trXPIab6xP8VPzgoDFXEMk8+JpZayoxk5jjzrHnE8vDUgRjqCkffYnoLhKpzGBmc1ocI
	wCMRh8eU+pcG6VVSAoByAVuepLDBTMZhFYjZneCUV9cup/tUEoySzR2tiMit/ASjDKqy
	29pg==
X-Gm-Message-State: APt69E1wfzbXSF7GL5lRUGB1HrtmhE+tL+O7Zi9Fq2jlc7XaFqfdHJrx
	/i3+J2/j0Ow31VM7aK2kAIZWT8NV9tcAZQonQS1M0A==
X-Google-Smtp-Source: AAOMgpc/T8YvHJoJ72YnSalzvc+MOMV5wH2HBtY2WIBL25mgQKiBtrUrflCnRQh0jPTWJPrWDbiYQi2cLpxxkRCw4t0=
X-Received: by 2002:a1f:a102:: with SMTP id
	k2-v6mr1530972vke.118.1530033106721; 
	Tue, 26 Jun 2018 10:11:46 -0700 (PDT)
MIME-Version: 1.0
Received: by 2002:ab0:40c6:0:0:0:0:0 with HTTP; Tue, 26 Jun 2018 10:11:05
	-0700 (PDT)
In-Reply-To: <87h8lpbi39.fsf@jb55.com>
References: <CAPg+sBhGMxXatsyCAqeboQKH8ASSFAfiXzxyXR9UrNFnah5PPw@mail.gmail.com>
	<CHCiA27GTRiVfkF1DoHdroJL1rQS77ocB42nWxIIhqi_fY3VbB3jsMQveRJOtsJiA4RaCAVe3VZmLZsXVYS3A5wVLNP2OgKQiHE0T27P2qc=@achow101.com>
	<21a616f5-7a17-35b9-85ea-f779f20a6a2d@satoshilabs.com>
	<20180621195654.GC99379@coinkite.com>
	<CAPg+sBgdQqZ8sRSn=dd9EkavYJA6GBiCu6-v5k9ca-9WLPp72Q@mail.gmail.com>
	<ljk5Z_a3KK6DHfmPJxI8o9W2CkwszkUG34h0i1MTGU4ss8r3BTQ3GnTtDTfWF6J7ZqcSAmejzrr11muWqYN-_wnWw_0NFn5_lggNnjI0_Rc=@achow101.com>
	<f8f5b1e3-692a-fc1e-2ad3-c4ad4464957f@satoshilabs.com>
	<TGyS7Azu3inMQFv9QFn8USr9v2m5QbhDRmiOI-4FWwscUeuIB9rA7mCmZA4-kwCJOMAx92fO7XICHtE7ES_QmIYLDy6RHof1WLALskGUYAc=@achow101.com>
	<c32dc90d-9919-354b-932c-f93fe329760b@satoshilabs.com>
	<87h8lpbi39.fsf@jb55.com>
From: Marek Palatinus <marek@palatinus.cz>
Date: Tue, 26 Jun 2018 19:11:05 +0200
Message-ID: <CAJna-HiJ9S8D_Jrw6ho_tTUEaF9bGxPnXmEUmUNRuJV-rDizPQ@mail.gmail.com>
To: William Casarin <jb55@jb55.com>, 
	Bitcoin Protocol Discussion <bitcoin-dev@lists.linuxfoundation.org>
Content-Type: multipart/alternative; boundary="000000000000d2392e056f8e97ba"
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID, HTML_MESSAGE, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
	smtp1.linux-foundation.org
Subject: Re: [bitcoin-dev] BIP 174 thoughts
X-BeenThere: bitcoin-dev@lists.linuxfoundation.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Bitcoin Protocol Discussion <bitcoin-dev.lists.linuxfoundation.org>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/bitcoin-dev>,
	<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/>
List-Post: <mailto:bitcoin-dev@lists.linuxfoundation.org>
List-Help: <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev>,
	<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Jun 2018 17:11:48 -0000

--000000000000d2392e056f8e97ba
Content-Type: text/plain; charset="UTF-8"

On Tue, Jun 26, 2018 at 6:58 PM, William Casarin via bitcoin-dev <
bitcoin-dev@lists.linuxfoundation.org> wrote:
>
> seems a bit overkill for how simple the format is, and pulling in a
> large dependency just for this is a bit silly. Although making it
> protobuf-compatible is an interesting idea, but I fear would be more
> work than is worth? I haven't looked closed enough at the protobuf
> encoding to be sure.
>
> > ...while at the same time, implementing "protobuf-based-BIP174" by
> > hand is roughly equally difficult as implementing the current BIP174.
>
> as a data point, I was able to build a simple serializer[1] in about an
> afternoon. I would much prefer to use this lib in say, clightning (my
> original goal), without having to have the larger protobuf dependency.
>
>
That was exactly matejcik's point; you can easily write protobuf-compatible
encoder/decoder for such simple structure in about an afternoon, if you
need. Or you can use existing protobuf parsers in matter of minute, if you
don't care about dependencies.

Also, many projects already have protobuf parsers, so it work in other way,
too; you need BIP174 parser as extra dependency/library, although you
already use protobuf library (like Trezor device does). For needs of
BIP174, the difference between ad-hoc format and protobuf is neglible, so
it is a mistake to introduce yet another format.

slush

--000000000000d2392e056f8e97ba
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><div class=3D"gmail_extra"><br><div class=3D"gmail_quo=
te">On Tue, Jun 26, 2018 at 6:58 PM, William Casarin via bitcoin-dev <span =
dir=3D"ltr">&lt;<a href=3D"mailto:bitcoin-dev@lists.linuxfoundation.org" ta=
rget=3D"_blank">bitcoin-dev@lists.linuxfoundation.org</a>&gt;</span> wrote:=
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">seems a bit overkill for how simple the form=
at is, and pulling in a<br>
large dependency just for this is a bit silly. Although making it<br>
protobuf-compatible is an interesting idea, but I fear would be more<br>
work than is worth? I haven&#39;t looked closed enough at the protobuf<br>
encoding to be sure.<br>
<span class=3D""><br>
&gt; ...while at the same time, implementing &quot;protobuf-based-BIP174&qu=
ot; by<br>
&gt; hand is roughly equally difficult as implementing the current BIP174.<=
br>
<br>
</span>as a data point, I was able to build a simple serializer[1] in about=
 an<br>
afternoon. I would much prefer to use this lib in say, clightning (my<br>
original goal), without having to have the larger protobuf dependency.<br>
<br></blockquote><div><br></div><div>That was exactly matejcik&#39;s point;=
 you can easily write protobuf-compatible encoder/decoder for such simple s=
tructure in about an afternoon, if you need. Or you can use existing protob=
uf parsers in matter of minute, if you don&#39;t care about dependencies.</=
div><div><br></div><div>Also, many projects already have protobuf parsers, =
so it work in other way, too; you need BIP174 parser as extra dependency/li=
brary, although you already use protobuf library (like Trezor device does).=
 For needs of BIP174, the difference between ad-hoc format and protobuf is =
neglible, so it is a mistake to introduce yet another format.</div><div><br=
></div><div>slush</div></div></div></div>

--000000000000d2392e056f8e97ba--