summaryrefslogtreecommitdiff
path: root/4e/94677c0fd30393bb0ada3118aee7b98ab4b14d
blob: 5179aba1e6962432cafc1d046aac70bf2fc3f4ad (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194]
	helo=mx.sourceforge.net)
	by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
	(envelope-from <mh.in.england@gmail.com>) id 1WkAt9-0004Ps-F7
	for bitcoin-development@lists.sourceforge.net;
	Tue, 13 May 2014 11:28:51 +0000
Received-SPF: pass (sog-mx-4.v43.ch3.sourceforge.com: domain of gmail.com
	designates 209.85.219.45 as permitted sender)
	client-ip=209.85.219.45; envelope-from=mh.in.england@gmail.com;
	helo=mail-oa0-f45.google.com; 
Received: from mail-oa0-f45.google.com ([209.85.219.45])
	by sog-mx-4.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128)
	(Exim 4.76) id 1WkAt8-0006wE-6N
	for bitcoin-development@lists.sourceforge.net;
	Tue, 13 May 2014 11:28:51 +0000
Received: by mail-oa0-f45.google.com with SMTP id l6so202191oag.32
	for <bitcoin-development@lists.sourceforge.net>;
	Tue, 13 May 2014 04:28:44 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.182.229.101 with SMTP id sp5mr21873736obc.52.1399980524609; 
	Tue, 13 May 2014 04:28:44 -0700 (PDT)
Sender: mh.in.england@gmail.com
Received: by 10.76.71.162 with HTTP; Tue, 13 May 2014 04:28:44 -0700 (PDT)
In-Reply-To: <CAEz79PoNZ=B+BsmHkHykeh4TY3q_EVmksAJagzKTFuTAHL-1pA@mail.gmail.com>
References: <CAEz79Prrpwi6SXyCpGesmkdau6vjtwELAhr6quXtFZ6_t1-y2A@mail.gmail.com>
	<CANEZrP1--8C0Tf=RF1Hi9sXq5wbUC1feBswkGMcwGxwgZ1UYKw@mail.gmail.com>
	<CAEz79PoNZ=B+BsmHkHykeh4TY3q_EVmksAJagzKTFuTAHL-1pA@mail.gmail.com>
Date: Tue, 13 May 2014 13:28:44 +0200
X-Google-Sender-Auth: mQ69QFD-K8aYYB_ZOenFaIr9uF8
Message-ID: <CANEZrP1_1E-EdEYAXW=STYJRReJPCuA4WiQshTim7z40Wfvbkw@mail.gmail.com>
From: Mike Hearn <mike@plan99.net>
To: "Warren Togami Jr." <wtogami@gmail.com>
Content-Type: multipart/alternative; boundary=001a1134c0f4dca82904f9465d78
X-Spam-Score: -0.5 (/)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
	See http://spamassassin.org/tag/ for more details.
	-1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for
	sender-domain
	0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider
	(mh.in.england[at]gmail.com)
	-0.0 SPF_PASS               SPF: sender matches SPF record
	1.0 HTML_MESSAGE           BODY: HTML included in message
	0.1 DKIM_SIGNED            Message has a DKIM or DK signature,
	not necessarily valid
	-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
X-Headers-End: 1WkAt8-0006wE-6N
Cc: Bitcoin Dev <bitcoin-development@lists.sourceforge.net>
Subject: Re: [Bitcoin-development] Regtest Address Version Change Proposal
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
	<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
	<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Tue, 13 May 2014 11:28:51 -0000

--001a1134c0f4dca82904f9465d78
Content-Type: text/plain; charset=UTF-8

And they can't just do

  NetworkParams.TESTNET = NetworkParams.REGTEST

at the start of a program that is connecting to regtest?

It's not like changing the address code is a huge problem or anything, but
it would disrupt a bunch of people and seems kind of annoying. Surely
there's a simpler way to work around this issue on their side? I mean their
code already has to know what network is *expected*, right, otherwise what
stops you accidentally trying to send coins cross chain?



On Tue, May 13, 2014 at 1:02 PM, Warren Togami Jr. <wtogami@gmail.com>wrote:

> bitcore guesses the network from the address version in several places in
> its code.  They don't want to change that.  Perhaps it wasn't the wisest
> approach for them to use.  I thought it might be simple to change the
> address version since its still relatively new and it isn't a real network.
>  Would it be too much work to change?
>
>
> On Tue, May 13, 2014 at 12:30 AM, Mike Hearn <mike@plan99.net> wrote:
>
>> Yes, bitcoinj supports and uses regtest mode. It would also have to be
>> changed.
>>
>> You didn't provide a rationale for this. What's the cost of having them
>> be the same?
>>
>>
>> On Tue, May 13, 2014 at 11:45 AM, Warren Togami Jr. <wtogami@gmail.com>wrote:
>>
>>> Hi folks,
>>>
>>> I propose changing all of the address versions in -regtest mode to be
>>> unique so they are no longer identical to testnet.
>>>
>>> https://en.bitcoin.it/wiki/List_of_address_prefixes
>>> For example, regtest pubkey hash addresses could begin with r or R.
>>>
>>> We need to know if any existing tools would need to be modified to
>>> support this change to regtest.  Do existing tools outside of pull tester
>>> expect regtest to have testnet addresses?  If the quantity of tools that
>>> currently handle regtest is small then we can modify them to the new
>>> address versions.
>>>
>>> Warren Togami
>>>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
>>> Instantly run your Selenium tests across 300+ browser/OS combos.
>>> Get unparalleled scalability from the best Selenium testing platform
>>> available
>>> Simple to use. Nothing to install. Get started now for free."
>>> http://p.sf.net/sfu/SauceLabs
>>> _______________________________________________
>>> Bitcoin-development mailing list
>>> Bitcoin-development@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/bitcoin-development
>>>
>>>
>>
>

--001a1134c0f4dca82904f9465d78
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">And they can&#39;t just do<div><br></div><div>=C2=A0 Netwo=
rkParams.TESTNET =3D NetworkParams.REGTEST=C2=A0</div><div><br></div><div>a=
t the start of a program that is connecting to regtest?</div><div><br></div=
><div>It&#39;s not like changing the address code is a huge problem or anyt=
hing, but it would disrupt a bunch of people and seems kind of annoying. Su=
rely there&#39;s a simpler way to work around this issue on their side? I m=
ean their code already has to know what network is <i>expected</i>, right, =
otherwise what stops you accidentally trying to send coins cross chain?</di=
v>
<div><br></div></div><div class=3D"gmail_extra"><br><br><div class=3D"gmail=
_quote">On Tue, May 13, 2014 at 1:02 PM, Warren Togami Jr. <span dir=3D"ltr=
">&lt;<a href=3D"mailto:wtogami@gmail.com" target=3D"_blank">wtogami@gmail.=
com</a>&gt;</span> wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex"><div dir=3D"ltr">bitcore guesses the network=
 from the address version in several places in its code. =C2=A0They don&#39=
;t want to change that. =C2=A0Perhaps it wasn&#39;t the wisest approach for=
 them to use. =C2=A0I thought it might be simple to change the address vers=
ion since its still relatively new and it isn&#39;t a real network. =C2=A0W=
ould it be too much work to change?</div>
<div class=3D"HOEnZb"><div class=3D"h5">
<div class=3D"gmail_extra"><br><br><div class=3D"gmail_quote">On Tue, May 1=
3, 2014 at 12:30 AM, Mike Hearn <span dir=3D"ltr">&lt;<a href=3D"mailto:mik=
e@plan99.net" target=3D"_blank">mike@plan99.net</a>&gt;</span> wrote:<br><b=
lockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px =
#ccc solid;padding-left:1ex">

<div dir=3D"ltr">Yes, bitcoinj supports and uses regtest mode. It would als=
o have to be changed.<div><br></div><div>You didn&#39;t provide a rationale=
 for this. What&#39;s the cost of having them be the same?</div></div><div =
class=3D"gmail_extra">


<br><br><div class=3D"gmail_quote"><div><div>On Tue, May 13, 2014 at 11:45 =
AM, Warren Togami Jr. <span dir=3D"ltr">&lt;<a href=3D"mailto:wtogami@gmail=
.com" target=3D"_blank">wtogami@gmail.com</a>&gt;</span> wrote:<br>
</div></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;bo=
rder-left:1px #ccc solid;padding-left:1ex"><div><div>
<div dir=3D"ltr">Hi folks,<div><br></div><div>I propose changing all of the=
 address versions in -regtest mode to be unique so they are no longer ident=
ical to testnet.</div><div><br></div><div><a href=3D"https://en.bitcoin.it/=
wiki/List_of_address_prefixes" target=3D"_blank">https://en.bitcoin.it/wiki=
/List_of_address_prefixes</a><br>



</div><div>For example, regtest pubkey hash addresses could begin with r or=
 R.</div><div><br></div><div>We need to know if any existing tools would ne=
ed to be modified to support this change to regtest. =C2=A0Do existing tool=
s outside of pull tester expect regtest to have testnet addresses? =C2=A0If=
 the quantity of tools that currently handle regtest is small then we can m=
odify them to the new address versions.</div>


<span><font color=3D"#888888">
<div><br></div><div>Warren Togami</div><div><br></div></font></span></div>
<br></div></div>-----------------------------------------------------------=
-------------------<br>
&quot;Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE=
<br>
Instantly run your Selenium tests across 300+ browser/OS combos.<br>
Get unparalleled scalability from the best Selenium testing platform availa=
ble<br>
Simple to use. Nothing to install. Get started now for free.&quot;<br>
<a href=3D"http://p.sf.net/sfu/SauceLabs" target=3D"_blank">http://p.sf.net=
/sfu/SauceLabs</a><br>_______________________________________________<br>
Bitcoin-development mailing list<br>
<a href=3D"mailto:Bitcoin-development@lists.sourceforge.net" target=3D"_bla=
nk">Bitcoin-development@lists.sourceforge.net</a><br>
<a href=3D"https://lists.sourceforge.net/lists/listinfo/bitcoin-development=
" target=3D"_blank">https://lists.sourceforge.net/lists/listinfo/bitcoin-de=
velopment</a><br>
<br></blockquote></div><br></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>

--001a1134c0f4dca82904f9465d78--