summaryrefslogtreecommitdiff
path: root/46/9faf54b5a983ab45b7c0734d52461baa2e7951
blob: 54397847fd49ba86e4ea8451e6b6430f39e96689 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191]
	helo=mx.sourceforge.net)
	by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
	(envelope-from <laanwj@gmail.com>) id 1Ws8BR-0005uO-1K
	for bitcoin-development@lists.sourceforge.net;
	Wed, 04 Jun 2014 10:12:37 +0000
Received-SPF: pass (sog-mx-1.v43.ch3.sourceforge.com: domain of gmail.com
	designates 209.85.223.175 as permitted sender)
	client-ip=209.85.223.175; envelope-from=laanwj@gmail.com;
	helo=mail-ie0-f175.google.com; 
Received: from mail-ie0-f175.google.com ([209.85.223.175])
	by sog-mx-1.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128)
	(Exim 4.76) id 1Ws8BP-0001lF-9C
	for bitcoin-development@lists.sourceforge.net;
	Wed, 04 Jun 2014 10:12:36 +0000
Received: by mail-ie0-f175.google.com with SMTP id y20so6758318ier.6
	for <bitcoin-development@lists.sourceforge.net>;
	Wed, 04 Jun 2014 03:12:29 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.50.92.42 with SMTP id cj10mr5474722igb.34.1401876749289;
	Wed, 04 Jun 2014 03:12:29 -0700 (PDT)
Received: by 10.64.60.195 with HTTP; Wed, 4 Jun 2014 03:12:29 -0700 (PDT)
In-Reply-To: <CANEZrP18nf0oK6fbnE59opXxfMdwiOOu4v99iGyXyGo_7NLuYA@mail.gmail.com>
References: <1401822421.27942.YahooMailNeo@web124505.mail.ne1.yahoo.com>
	<CANEZrP18nf0oK6fbnE59opXxfMdwiOOu4v99iGyXyGo_7NLuYA@mail.gmail.com>
Date: Wed, 4 Jun 2014 12:12:29 +0200
Message-ID: <CA+s+GJAmXmsivqg6R2HbiRC2-xc2sHSbsA-auYN8V0LCLS1d3g@mail.gmail.com>
From: Wladimir <laanwj@gmail.com>
To: Mike Hearn <mike@plan99.net>
Content-Type: multipart/alternative; boundary=047d7b10d0b5a9133b04faffddf3
X-Spam-Score: -0.6 (/)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
	See http://spamassassin.org/tag/ for more details.
	-1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for
	sender-domain
	0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider
	(laanwj[at]gmail.com)
	-0.0 SPF_PASS               SPF: sender matches SPF record
	1.0 HTML_MESSAGE           BODY: HTML included in message
	-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from
	author's domain
	0.1 DKIM_SIGNED            Message has a DKIM or DK signature,
	not necessarily valid
	-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
X-Headers-End: 1Ws8BP-0001lF-9C
Cc: "bitcoin-development@lists.sourceforge.net"
	<bitcoin-development@lists.sourceforge.net>, Ron <rdwnj@yahoo.com>
Subject: Re: [Bitcoin-development] # error "Bitcoin cannot be compiled
 without assertions." <<<<NOT
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
	<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
	<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Wed, 04 Jun 2014 10:12:37 -0000

--047d7b10d0b5a9133b04faffddf3
Content-Type: text/plain; charset=UTF-8

>
>
>  assert() should have *no* side effects, that is the problem.
>>
>
I'm pretty sure that all the side effects of assertions have been removed
before 0.9.0.

However, the assertion checks are extremely important to the proper sanity
of the client and network, so IMHO it's fair to still require building with
them enabled.

Wladimir

--047d7b10d0b5a9133b04faffddf3
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_extra"><div class=3D"gmail_quote"><blo=
ckquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #c=
cc solid;padding-left:1ex"><div dir=3D"ltr"><div class=3D"gmail_extra"><div=
 class=3D"gmail_quote">
<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-lef=
t:1px #ccc solid;padding-left:1ex"><div><div style=3D"color:#000;background=
-color:#fff;font-family:Courier New,courier,monaco,monospace,sans-serif;fon=
t-size:10pt">

<div><div><div style=3D"color:#000;background-color:#fff;font-family:Courie=
r New,courier,monaco,monospace,sans-serif;font-size:10pt"><div style=3D"col=
or:rgb(0,0,0);font-size:13.3333px;font-family:Courier New,courier,monaco,mo=
nospace,sans-serif;background-color:transparent;font-style:normal">

<tt>assert() </tt>should have <span style=3D"text-decoration:underline"><b>=
no</b></span> side effects, that is the problem.<br></div></div></div></div=
></div></div></blockquote></div></div></div></blockquote><div><br></div>
<div>I&#39;m pretty sure that all the side effects of assertions have been =
removed before 0.9.0.<br><br></div><div>However, the assertion checks are e=
xtremely important to the proper sanity of the client and network, so IMHO =
it&#39;s fair to still require building with them enabled.<br>
<br></div>Wladimir<br><br></div><br></div></div>

--047d7b10d0b5a9133b04faffddf3--