summaryrefslogtreecommitdiff
path: root/3d/402e8c55c1df685e804cb606052a7d201402ef
blob: 74e07dc2865c999967dd2d39720cd384cb33d096 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191]
	helo=mx.sourceforge.net)
	by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
	(envelope-from <jtimon@monetize.io>) id 1WaqLh-0006mD-8n
	for bitcoin-development@lists.sourceforge.net;
	Thu, 17 Apr 2014 17:43:45 +0000
Received: from mail-lb0-f178.google.com ([209.85.217.178])
	by sog-mx-1.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128)
	(Exim 4.76) id 1WaqLe-0000Iu-0s
	for bitcoin-development@lists.sourceforge.net;
	Thu, 17 Apr 2014 17:43:45 +0000
Received: by mail-lb0-f178.google.com with SMTP id s7so625080lbd.23
	for <bitcoin-development@lists.sourceforge.net>;
	Thu, 17 Apr 2014 10:43:35 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20130820;
	h=x-gm-message-state:mime-version:in-reply-to:references:date
	:message-id:subject:from:to:cc:content-type
	:content-transfer-encoding;
	bh=lfot2eoy1qOr1Mqi5rICL0wqsrirPYetMDOcVotFAak=;
	b=IZIv5fxiHgHU+Ts1t4+S7QAWQWCU31Q0MGzpRbhxWRsSQiD7RY/5xqKBkAuhLT3FzO
	SY1Laon+DgP46RdUBh5WS11dIf1hmvm+/LGLiSOzDZpge7ssTTbttZYsTDWKSDk2Pqxo
	gA175WAedNIsrBXLYNPba3fyGvJAi/Tk77eFk12nfSe38pjaXEqGTISpdi9doQKtYhQe
	E0S0Kt6aI7kwIe/Mi7E5qmco0lSsCPYUEsZs9L32wewdfNexjllpK2Q1LetRSP7A4mgI
	ZLg4j3PaG41u/J9sOiF/YVKW1RKj5rCSXjnKAoWXnwf4jDPyg8MuNQ2MCTWcT+8uKdIc
	SzgA==
X-Gm-Message-State: ALoCoQl/tBXhcSI5zgE3WeARMIu30PYxxIVTJhda6YZTz8nnaKDsG3/bu1EH3TOUE0L8yS5WLBRf
MIME-Version: 1.0
X-Received: by 10.112.131.65 with SMTP id ok1mr2053357lbb.51.1397756615230;
	Thu, 17 Apr 2014 10:43:35 -0700 (PDT)
Received: by 10.112.60.196 with HTTP; Thu, 17 Apr 2014 10:43:35 -0700 (PDT)
X-Originating-IP: [85.53.138.195]
In-Reply-To: <CABsx9T23Upk+eAaHa_dPa1hQEZO1RPRMv7HfiLzbSrR14Z+NSg@mail.gmail.com>
References: <CAC1+kJMrpx0tyE8d0wkwjBthhSPMCdr=9LrJHQFTF4G1vg4MAg@mail.gmail.com>
	<CABsx9T1HGwozy8pY+iStGZPmjenu0RQBVdtOy5ibiWG0BM4mZw@mail.gmail.com>
	<CAC1+kJPvzxsSDg3joraZbv_r1RroK9d6-v9O_15g6S7B46TwQg@mail.gmail.com>
	<CANEZrP3s9SpBWxLYMvF5cLK4UeKS2SdKOLpNr40NKGoAzh=3nw@mail.gmail.com>
	<CAC1+kJMxjNReSMxm=vDB-iYyXTqBvXq5_aw0Z3onds0zF-Oq=w@mail.gmail.com>
	<CABsx9T23Upk+eAaHa_dPa1hQEZO1RPRMv7HfiLzbSrR14Z+NSg@mail.gmail.com>
Date: Thu, 17 Apr 2014 19:43:35 +0200
Message-ID: <CAC1+kJOXgMY1N+5uyyQ3Z=w=db9LPrBha=0z_2r4ND4VpsS-Vw@mail.gmail.com>
From: =?ISO-8859-1?Q?Jorge_Tim=F3n?= <jtimon@monetize.io>
To: Gavin Andresen <gavinandresen@gmail.com>,
	Pieter Wuille <pieter.wuille@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
	See http://spamassassin.org/tag/ for more details.
X-Headers-End: 1WaqLe-0000Iu-0s
Cc: Bitcoin Dev <bitcoin-development@lists.sourceforge.net>
Subject: Re: [Bitcoin-development] Timed testing
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
	<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
	<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Thu, 17 Apr 2014 17:43:45 -0000

Thank you for all the explanations on how to use regtest to reproduce
the example scenarios.
It seems like a private mode wouldn't be particularly helpful for
testing so I won't create a pull request and will just work on the
private chains separately from bitcoind.

Going back to chainparam modes in general, I've heard Sipa complain
some times about regtest being too specific, arguing that some of the
behaviors should be specified as independent parameters instead of
chainparams attributes.
One example could be bool CChainPrams::MineBlocksOnDemand() (see
https://github.com/jtimon/bitcoin/commit/5bd4bc7f3694e46568c9276f0cb26402df=
b99718
).
If that was an independent parameter that people set to true when
using regtest, the blocktime param I was proposing for -timedtest
could also be implemented as an independent parameter without any need
for a new mode.

It's not clear to me if the timedtest parameter would be useful for
bitcoind testing or not, but it's just something I've noticed while
playing with this part of the code.
Sipa, is this the kind of thing you refer to when you say regtest is
too specific?
Do you have any suggestion on how to solve the issue as part of PR 3824?

Well, any suggestions from anyone on how to improve PR 3824 are
welcomed, I was just asking specifically to sipa because as said it is
my understanding that he had some complaints about regtest and I think
this is something simple enough for me to start contributing to
bitcoind. Specially given that I was going to review all that part of
the code to externally write the private mode anyway.

--=20
Jorge Tim=F3n

http://freico.in/