summaryrefslogtreecommitdiff
path: root/35/a9369959264e85d8fb94a0c7a370a15103bc4a
blob: 50fc2a0f3475687084f57dedd5229efc0d911678 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192]
	helo=mx.sourceforge.net)
	by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
	(envelope-from <mh.in.england@gmail.com>) id 1Ws7r8-000610-GB
	for bitcoin-development@lists.sourceforge.net;
	Wed, 04 Jun 2014 09:51:38 +0000
Received-SPF: pass (sog-mx-2.v43.ch3.sourceforge.com: domain of gmail.com
	designates 209.85.219.46 as permitted sender)
	client-ip=209.85.219.46; envelope-from=mh.in.england@gmail.com;
	helo=mail-oa0-f46.google.com; 
Received: from mail-oa0-f46.google.com ([209.85.219.46])
	by sog-mx-2.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128)
	(Exim 4.76) id 1Ws7r7-0004wO-AK
	for bitcoin-development@lists.sourceforge.net;
	Wed, 04 Jun 2014 09:51:38 +0000
Received: by mail-oa0-f46.google.com with SMTP id g18so7592865oah.33
	for <bitcoin-development@lists.sourceforge.net>;
	Wed, 04 Jun 2014 02:51:31 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.60.47.77 with SMTP id b13mr55206865oen.40.1401875491541;
	Wed, 04 Jun 2014 02:51:31 -0700 (PDT)
Sender: mh.in.england@gmail.com
Received: by 10.76.71.162 with HTTP; Wed, 4 Jun 2014 02:51:31 -0700 (PDT)
In-Reply-To: <1401822421.27942.YahooMailNeo@web124505.mail.ne1.yahoo.com>
References: <1401822421.27942.YahooMailNeo@web124505.mail.ne1.yahoo.com>
Date: Wed, 4 Jun 2014 17:51:31 +0800
X-Google-Sender-Auth: 6TGsjyQ372gB_-4q4S10JqJ2aDI
Message-ID: <CANEZrP18nf0oK6fbnE59opXxfMdwiOOu4v99iGyXyGo_7NLuYA@mail.gmail.com>
From: Mike Hearn <mike@plan99.net>
To: Ron <rdwnj@yahoo.com>
Content-Type: multipart/alternative; boundary=001a11c21116b15a7e04faff92d8
X-Spam-Score: -0.5 (/)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
	See http://spamassassin.org/tag/ for more details.
	-1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for
	sender-domain
	0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider
	(mh.in.england[at]gmail.com)
	-0.0 SPF_PASS               SPF: sender matches SPF record
	1.0 HTML_MESSAGE           BODY: HTML included in message
	0.1 DKIM_SIGNED            Message has a DKIM or DK signature,
	not necessarily valid
	-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
X-Headers-End: 1Ws7r7-0004wO-AK
Cc: "bitcoin-development@lists.sourceforge.net"
	<bitcoin-development@lists.sourceforge.net>
Subject: Re: [Bitcoin-development] # error "Bitcoin cannot be compiled
 without assertions." <<<<NOT
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
	<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
	<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Wed, 04 Jun 2014 09:51:38 -0000

--001a11c21116b15a7e04faff92d8
Content-Type: text/plain; charset=UTF-8

Hi Ron,

FYI your mail is being spamfoldered due to Yahoo's DMARC policy and the
brokenness of the SF.net mailing list software. I would not expect to get
replies reliably whilst this is the case. I think we should move away from
SF.net for hosting mailing lists personally, because it's this list that's
at fault not Yahoo, but until then you may wish to send to the list with a
different email address.

As to your question,

assert() should have *no* side effects, that is the problem.
>
> See
>
> http://books.google.com/books?id=L5ZbzVnpkXAC&pg=PA72&lpg=PA72&dq=Gotcha+%2328+Side+Effects&source=bl&ots=Rn15TlPmje&sig=tymHqta0aSANwaM2GaXC-1Di_tk&hl=en&sa=X&ei=uVKNU47fCcvTsAT6goHIBA&ved=0CCAQ6AEwAA#v=onepage&q=Gotcha%20%2328%20Side%20Effects&f=false
>
> a great book, BTW.  Everyone who thinks they know what they are doing when
> they write C++ should read this book!  They will realize that they don't
> know Jack [image: Roll Eyes]
>
> Why weren't these and all the other examples of amateur, i.e.,
> non-professional, software fixed way back in version 0.3.0 in 2010, before
> any more releases were done?  And why were these and other sub-standard
> coding practices continued and expanded in later releases, right up until
> the present?
>

Back in 2010 most code was still being written by Satoshi so perhaps you
should ask him. Regardless, it's very common for professional codebases to
require assertions be enabled. For example the entire Google C++ codebase
uses always-on assertions that have side effects liberally: it's convenient
and safe, when you have the guarantee the code will always run, and the
performance benefits of compiling out assertions are usually non-existent.

So for this reason I think Bitcoin Core currently will fail to build if
assertions are disabled, and that seems OK to me.

--001a11c21116b15a7e04faff92d8
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Ron,<div><br></div><div>FYI your mail is being spamfold=
ered due to Yahoo&#39;s DMARC policy and the brokenness of the SF.net maili=
ng list software. I would not expect to get replies reliably whilst this is=
 the case. I think we should move away from SF.net for hosting mailing list=
s personally, because it&#39;s this list that&#39;s at fault not Yahoo, but=
 until then you may wish to send to the list with a different email address=
.</div>
<div><br></div><div>As to your question,</div><div class=3D"gmail_extra"><d=
iv class=3D"gmail_quote"><br><blockquote class=3D"gmail_quote" style=3D"mar=
gin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div style=
=3D"color:#000;background-color:#fff;font-family:Courier New,courier,monaco=
,monospace,sans-serif;font-size:10pt">
<div><div><div style=3D"color:#000;background-color:#fff;font-family:Courie=
r New,courier,monaco,monospace,sans-serif;font-size:10pt"><div style=3D"col=
or:rgb(0,0,0);font-size:13.3333px;font-family:Courier New,courier,monaco,mo=
nospace,sans-serif;background-color:transparent;font-style:normal">
<tt>assert() </tt>should have <span style=3D"text-decoration:underline"><b>=
no</b></span> side effects, that is the problem.<br><br>See<br><a rel=3D"no=
follow" href=3D"http://books.google.com/books?id=3DL5ZbzVnpkXAC&amp;pg=3DPA=
72&amp;lpg=3DPA72&amp;dq=3DGotcha+%2328+Side+Effects&amp;source=3Dbl&amp;ot=
s=3DRn15TlPmje&amp;sig=3DtymHqta0aSANwaM2GaXC-1Di_tk&amp;hl=3Den&amp;sa=3DX=
&amp;ei=3DuVKNU47fCcvTsAT6goHIBA&amp;ved=3D0CCAQ6AEwAA#v=3Donepage&amp;q=3D=
Gotcha%20%2328%20Side%20Effects&amp;f=3Dfalse" target=3D"_blank">http://boo=
ks.google.com/books?id=3DL5ZbzVnpkXAC&amp;pg=3DPA72&amp;lpg=3DPA72&amp;dq=
=3DGotcha+%2328+Side+Effects&amp;source=3Dbl&amp;ots=3DRn15TlPmje&amp;sig=
=3DtymHqta0aSANwaM2GaXC-1Di_tk&amp;hl=3Den&amp;sa=3DX&amp;ei=3DuVKNU47fCcvT=
sAT6goHIBA&amp;ved=3D0CCAQ6AEwAA#v=3Donepage&amp;q=3DGotcha%20%2328%20Side%=
20Effects&amp;f=3Dfalse</a><br>
<br>a
 great book, BTW.=C2=A0 Everyone who thinks they know what they are doing=
=20
when they write C++ should read this book!=C2=A0 They will realize that the=
y=20
don&#39;t know Jack <img src=3D"https://bitcointalk.org/Smileys/default/rol=
leyes.gif" alt=3D"Roll Eyes" border=3D"0"></div><div style=3D"color:rgb(0,0=
,0);font-size:13.3333px;font-family:Courier New,courier,monaco,monospace,sa=
ns-serif;background-color:transparent;font-style:normal">
<br></div><div style=3D"color:rgb(0,0,0);font-size:13.3333px;font-family:Co=
urier New,courier,monaco,monospace,sans-serif;background-color:transparent;=
font-style:normal">Why weren&#39;t these and all the other examples of amat=
eur, i.e., non-professional, software fixed way back in version 0.3.0 in 20=
10, before any more releases were done?=C2=A0 And why were these and other =
sub-standard coding practices continued and expanded in later
 releases, right up until the present? <br></div></div></div></div></div></=
div></blockquote><div><br></div><div>Back in 2010 most code was still being=
 written by Satoshi so perhaps you should ask him. Regardless, it&#39;s ver=
y common for professional codebases to require assertions be enabled. For e=
xample the entire Google C++ codebase uses always-on assertions that have s=
ide effects liberally: it&#39;s convenient and safe, when you have the guar=
antee the code will always run, and the performance benefits of compiling o=
ut assertions are usually non-existent.</div>
<div><br></div><div>So for this reason I think Bitcoin Core currently will =
fail to build if assertions are disabled, and that seems OK to me.</div></d=
iv></div></div>

--001a11c21116b15a7e04faff92d8--